Standalone mode about plugin-xml HOT 9 CLOSED

I've noticed the same situation. Using it within a react app, compiler outputs:

Compiled with warnings.

./node_modules/prettier/index.js
Critical dependency: the request of a dependency is an expression

./node_modules/prettier/index.js
Critical dependency: the request of a dependency is an expression

./node_modules/prettier/index.js
Critical dependency: the request of a dependency is an expression

./node_modules/prettier/third-party.js
Critical dependency: the request of a dependency is an expression

./node_modules/prettier/parser-typescript.js
Module not found: Can't resolve '@microsoft/typescript-etw' in '/yada/yada/node_modules/prettier'

Note that in create-react-app, is not possible to configure the webpack aliases unless you eject or use the rewired package so this is important to address via this package itself.

I've submitted a PR which solves this issue.

from plugin-xml.

My webpack workaround:

{
  resolve: { alias: { prettier$: require.resolve('prettier/standalone') } }
}

from plugin-xml.

@viceice I'm about to release v0.4.0, once I do could you try again? I want to fully understand this issue

from plugin-xml.

Would it help if Prettier added the browser property to its package.json pointing to standalone.js?

from plugin-xml.

from plugin-xml.

@viceice I'm about to release v0.4.0, once I do could you try again? I want to fully understand this issue

Yes, but earliest on next week. But our ci will get the update as you publish it. So I can check the result.

from plugin-xml.

Does #55 solve this issue?

from plugin-xml.

@kddeisz, It does.

from plugin-xml.

Nice - I've release v0.7.1 with the change. Going to optimistically close this. Feel free to reopen if it's still an issue.

from plugin-xml.