prettier / plugin-lua Goto Github PK

current output

local variable =
	call_something_that_is_kind_of_long(with_some_long, arguments_that_are_long)

expected output

local variable = call_something_that_is_kind_of_long(
	with_some_long,
	arguments_that_are_long
)

There seems to be a bug when a conditional returns "end" it would break the parser.

if condition then
  return "end"
end

See danielpza@8a4c013

Input:

if foo then
    -- Run bar
    bar()
else
    -- Run baz
    baz()
end

Output:

if foo then
    -- Run bar
    bar()
    -- Run baz
else
    baz()
end

Currently when a file is formatted no blank newline is added to the end, it should be added.

The first line of the Readme states that this is a "🚧 Work in Progress! 🚧", and the first sentence states that "this plugin is ... still under active development." However, the last PR was merged in July of 2023, and the top of the issue list are items from 2021 that have not received any response or indications of review. The repo's primary author stated in April of 2023 on #16 that "I'm not really maintaining this these days."

If this repo is not in fact under active development or maintainenance, the readme should be changed to indicate that.

I apologize if I'm offending anyone by mentioning this. If my assesment of the state of the project is incorrect I will happily close this issue. Please also note that I'm not asking anyone to actively maintain this project, merely stating that its current status is not well reflected by the Readme.

current output

	assert(
		context:ReturnBabel(
			[[
				fetch("asset://garrysmod/data/a.txt")
				.then((response) => response.text())
				.then(a => console.log(a))
				.catch(a => console.warn(a))
			]]
		):await()
	)

expected output

	assert(
		context:ReturnBabel([[
				fetch("asset://garrysmod/data/a.txt")
				.then((response) => response.text())
				.then(a => console.log(a))
				.catch(a => console.warn(a))
			]]):await()
	)

input

call() -- line comment

call()

output

call() -- line comment
call()

expected output

call() -- line comment

call()

rtp.lua[error] rtp.lua: TypeError: locEnd is not a function
[error] at isNextLineEmpty (/usr/lib/node_modules/prettier/index.js:3572:42)
[error] at /usr/lib/node_modules/@prettier/plugin-lua/src/printer.js:410:7
[error] at /usr/lib/node_modules/prettier/index.js:14487:23
[error] at FastPath.each (/usr/lib/node_modules/prettier/index.js:14474:7)
[error] at FastPath.map (/usr/lib/node_modules/prettier/index.js:14486:10)
[error] at printBody (/usr/lib/node_modules/@prettier/plugin-lua/src/printer.js:384:8)
[error] at printNoParens (/usr/lib/node_modules/@prettier/plugin-lua/src/printer.js:28:14)
[error] at Object.genericPrint [as print] (/usr/lib/node_modules/@prettier/plugin-lua/src/printer.js:763:19)
[error] at callPluginPrintFunction (/usr/lib/node_modules/prettier/index.js:14718:18)
[error] at /usr/lib/node_modules/prettier/index.js:14649:47

Current output:

if variable == some.nested.object and variable2 == another.object or variable == another.object and variable2 == some.nested.object then return end

Expected something like that:

if variable == some.nested.object and variable2 == another.object or
    variable == another.object and variable2 == some.nested.object then 
	return 
end

I'd like to use this in the browser, however, trying it out with

• "@prettier/plugin-lua": "0.0.1",
• "prettier": "^2.2.1"

const prettier = require("prettier");
const plugin = require("@prettier/plugin-lua");

function format_lua(s) {
  return prettier.format(s, { parser: "lua" });
}

format_lua("function deepcopy(orig)
  local orig_type = type(orig)
     local copy

  if orig_type == 'table' then; copy = {}
  for orig_key, orig_value in next, orig, nil do
  copy[deepcopy(orig_key)] = deepcopy(orig_value)
          end
          setmetatable(
            copy,
            deepcopy(
              getmetatable(orig)))
      else
          copy = orig
      end
    return copy
  end")

gives:

format_lua("function deepcopy(orig)
           ^^^^^^^^^^^^^^^^^^^^^^^^

SyntaxError: Invalid or unexpected token
    at wrapSafe (node:internal/modules/cjs/loader:1024:16)
    at Module._compile (node:internal/modules/cjs/loader:1072:27)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1137:10)
    at Module.load (node:internal/modules/cjs/loader:973:32)
    at Function.Module._load (node:internal/modules/cjs/loader:813:14)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12)
    at node:internal/main/run_main_module:17:47

current output

do
	ent = function(sock)
		local contents =
			"ENT = {}; local ENT=ENT; " .. sock:receive(
				"*a"
			) .. "; scripted_ents.Register(ENT, '" .. who:sub(0, -5) .. "')"
	end
end

expected output

do
	ent = function(sock)
		local contents =
			"ENT = {}; local ENT=ENT; "
				.. sock:receive("*a")
				.. "; scripted_ents.Register(ENT, '"
				.. who:sub(0, -5)
				.. "')"
	end
end

Prettier sets useTabs to false and tabWidth to 2 by default, yet it is changed to true and 4 in this plugin. Is there any reason for this?

@vjeux After transferring this repo to the prettier org, I no longer have access to its "Settings" tab, so I can't rename it to plugin-lua to match the other repos. Could you either rename it for me or give me access (if you know how)? Also could you verify @SpiralP and I both still have write access to the repo?

Sorry to bother you 😅

I don't want the comments to be moved around, is there any way to disable this?

Input:

function x:PosToAbsolute( x, y )
    return ( x - 1 ) * self.width, ( y - 1 ) * self.height
end

Output:

function x:PosToAbsolute( x, y )
    return x - 1 * self.width, y - 1 * self.height -- <<== no parentheses
end

Adding -- prettier-ignore comment seems to have no effect.

The same with:

-- prettier-ignore-start
code
-- prettier-ignore-end

also with --[[ --]] block comments.

http://luajit.org/ext_ffi_api.html#literals