This issue has been migrated from the Forge. Read the original ticket here.

• Reporter: ckubitza
• Created at: Wed, 16 Aug 2017 15:59:49 +0200

I need to show the template variable "$total_tax_excl" in the tax-tab of invoices (it is not visible by default). For shipping costs this value is wrong (double value), but only if proportional tax calculation in legal-complience module is disabled.

I could successfully fix it when moving line 438 in classes/order/OrderInvoice.php (in function getShippingTaxesBreakdown()) out of the if clause. So this should be always calculated, not only when PS_ATCP_SHIPWRAP is enabled:
$sum_of_tax_bases += $row['total_tax_excl'];
But I could not say if it has any side impacts.

• How to reproduce the issue ?

Show the variable "$total_tax_excl" in the invoice tax-tab template. When an order with shipping (which is including tax) is placed, the value of total_tax_excl in the line of the shipping tax is wrong.

Hello, because my previously post was closed and I don't know how to re-open it and I don't know if my last reply could be seen so I create a new post.

The settings :
PS 1.7.5.2 (not 1.7.6 tested to try to reproduce the issue)
ps_legalcompliance activated
tax activated.
Prices showed only to a custom group of clients (groupe name = pro)
Prices showed tax exc.
PHP 7
Theme : ZOneTheme (but tried with classic theme)

The issue :
On product list, unit_price is showed tax inc (bad)
On product page, unit_price is showed tax exc (good)

On product-list, unit_price is displayed by ps_legalcompliance :
{hook h='displayProductPriceBlock' product=$product type='unit_price'}

On product page, unit_price is displayed by product-prices.tpl

 `{block name='product_unit_price'}

      {if $displayUnitPrice}

        <p class="product-unit-price sub">{l s='(%unit_price%)' d='Shop.Theme.Catalog' sprintf=['%unit_price%' => $product.unit_price_full]}</p>

      {/if}

    {/block}`

Tried with changing the theme to Classic. Same problem.

I don't know if it's linked but in ProductController.php I see :

` if ($product_full['unit_price_ratio'] > 0) {
        $unitPrice = ($productSettings->include_taxes) ? $product_full['price'] : $product_full['price_tax_exc'];
        $product_full['unit_price'] = $unitPrice / $product_full['unit_price_ratio'];
    }`

Thanks for your help !

Describe the bug

Error displayed when clicking on 'Add new page' link

Expected behavior

Redirection to CMS page

Steps to Reproduce

Steps to reproduce the behavior:

1. Install ps_legalcompliance module
2. Go to configuration page
3. Click on 'Add new page' link on legal content manager form
4. See error

Screenshots

Additional information

• PrestaShop version: 1.7.7.1 and branch 1.7.7.x (works fine on 1.7.6.9)
• PHP version: 7.2

The link to the shipping costs are not the right domain - in all subdomain are the from the main domain.

on the category lists in the footer works correct.

Reste, delete and a new installation without success.

Additionnal information
PrestaShop version: 1.7.5
PHP version: 7.2.14

Hi,

If shipping is always free the ps_legalcompliance add an advice in the cart "FREE (under conditons)"

But if you configure shipping is free from a custom amount for example free from 29 € the label (under conditions) is not shown. But there could be conditions for delivery in different countries.

(under conditions) Label with link to "Shipping" Page is gone.

Describe the solution you'd like
The Label (under condition) should always be shown if there is a custom amount for "Free shipping"

Describe alternatives you've considered
Self decision to enable/disable the Label (under condition) in module ps_legalcompliance.

Additional context
If shipping is free from a custom amount for example for "Europe" there could be NO free shipping for other countries. It is always better then to show the Label with Link to site "Shipping" with shipping conditions

If anybody know a short workaround I would be very happy to use it now ;-)

This issue has been migrated from the Forge. Read the original ticket here.

• Reporter: comfuse
• Created at: Tue, 5 Sep 2017 09:17:00 +0200

We run a multishop installation with four shops.
We need different CMS links for terms and conditions, imprints et cetera for each shop.
The "Legal compliance module" for german/austrian shops does not provide overall multishop capacities.
The problem goes beyond a simple functional nice-to-have:

• You choose "terms and conditions" for shop A in module settings. The page you choose comes from a set of CMS pages specific to shop A (When you try to choose different pages for shop B they overwrite the settings for shop A).
• You fill your cart in shop B. During checkout you click on "terms and conditions". The modal stays empty because CMS pages from shop A are not shared with shop B.
• This renders the module useless in a multishop setting.

This is an urgent request.

Just to quote myself:
_From a practical point of view it makes no sense just to make the inclusion of the revocation terms or privacy in the terms of trade comfirmation dependent from the fact, if there is any text content or not to be found in the cms "revocation terms" or "privacy". This is a conditio sine qua non, but more important is the fact that you click the option Include revocation in terms and conditions. _
And as PrestaShop always includes a dummy text here, your condition will be always true, which is nonsense!

Please see to this bugfix in my own fork: Nobodaddy#2

If you add a cms page to the mails with ps_legalcompliance, the content will be insert after the closing Tag.

Steps to reproduce the behavior:

1. Install ps_legalcompliance.
2. Add a cms page to a mail in the configuration.
3. Send a mail by register a new content or take an order.
4. Check the e-mail cource code.

PrestaShop version: 1.7.4

This issue has been migrated from the Forge. Read the original ticket here.

• Reporter: razaro
• Created at: Tue, 14 Nov 2017 22:39:13 +0100

Hi

If country have setting to NO display tax label "Display tax label (e.g. "Tax incl.")" on front office, product page, it will still display that label. Module ps_legalcomplience module is installed and have setting to display label. I have created one issue concerning that module also http://forge.prestashop.com/browse/NM-909.

But for this I think issue is in FrontController class in function

protected function getDisplayTaxesLabel()

If module is enabled and its tax label set to display that condition will always be true. so even for USA or other countries that do not use that label , or just user changed to disabled, it still will display tax label.

Thank you.

• How to reproduce the issue ?

Have module ph_complience installed and option "Tax 'inc./excl.' label" set to Yes.


In Location > Countries find USA and set "Display tax label (e.g. "Tax incl.")" option to NO.

Hello,

this is a feature request:

if you enable "show price from" in ps_legalcompliance it shows "from" price only in category list but NOT on product page. It should be shown on product page too.

a alternativ solution can also be to show the price range "from" price "to" price

We have in germany the PAngV (Preisangabenverordnung) (price regulation) and it says if there is an price range it HAS to be shown everywhere the price range excists. On product detail page too. So I beg you please to add the "from" label on product page too. Or the alternative solution with "from" price "to" price.

Specs

When the option enabled the price range underneath the price of the "Standard Combination/Attribut" displays "Price range from the lowest combination price to the highest combination price",
like it is here:

This issue has been migrated from the Forge. Read the original ticket here.

• Reporter: adrian
• Created at: Fri, 9 Feb 2018 14:21:59 +0100

When you install the Legal Compliance module, it adds a list of links with the header "Information" to the footer. Unfortunately, this header is not uppercase, so it doesn't fit in with the other headers in the footer.

I suggest changing line 27 of themes/classic/views/templates/hook/hookDisplayFooter.tpl from:

{l s='Information' d='Modules.Legalcompliance.Shop'}

to:

{l s='Information' d='Modules.Legalcompliance.Shop'}

• How to reproduce the issue ?

Install the Legal Compliance module with the Classic theme.

This issue has been migrated from the Forge. Read the original ticket here.

• Reporter: superoelk
• Created at: Mon, 15 Jan 2018 21:50:43 +0100

In the accessories (similar products on product page) there is no price per unit. This is mandatory by law in the EU.

• How to reproduce the issue ?

Open product page and scroll down to the product's accessories.