Code Monkey home page Code Monkey logo

Comments (6)

tblivet avatar tblivet commented on June 26, 2024

Hello @nicosomb 👋

I'm able to reproduce the issue, but I believe we cannot fix it without editing the core. The warning appears in debug mode when the .tpl file tries to get the image size dimensions to display it in a modal.

This functionality wasn't implemented in the classic theme, so maybe this feature can be postponed for later?

from hummingbird.

nicosomb avatar nicosomb commented on June 26, 2024

@amine-O what's your opinion about this issue?

from hummingbird.

amine-O avatar amine-O commented on June 26, 2024

If it's not implemented on Classic, I don't see the emergency of doing it now
@tblivet are you able to reproduce it also on the Classic theme ?

from hummingbird.

tblivet avatar tblivet commented on June 26, 2024

@amine-O In the Classic theme, we don't have this warning because the element that throws the warning is only introduced in Hummingbird.

from hummingbird.

amine-O avatar amine-O commented on June 26, 2024

Ok let's postpone it then, we'll see if it's needed later

from hummingbird.

Hlavtox avatar Hlavtox commented on June 26, 2024

No getimagesize call should be in the template, theme should be just the view. If some more info is needed, we should provide it from the core. 👍

from hummingbird.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.