Comments (5)
Hi @Klemart3D
Thank you for your report. Currently you seems to show a feature to add in Prestashop instead of a real issue, If you're agree with that, I can change this issue into a discussion to discuss with the tech-council and product-council
Waiting for your feedback
from hummingbird.
Hi @AureRita,
It's not a feature, it's a refactoring issue to have a more clean code, it's an issue for developers like me because some IDE like phpStorm showing it as an error (because of wrong smarty syntax used):
It can take less than one minute to fix that for team working on native PrestaShop themes, but if you prefer, I can open issue into hummingbird repository?
from hummingbird.
Let's transfer into hummingbird repo ! If you are willing to contribute, we would be happy to review your work 🤗
from hummingbird.
Hi @MatShir , thank you.
I made 2 pull requests :
- For Classic theme: PrestaShop/classic-theme#142
- For Hummingbird theme: #605
from hummingbird.
Fixed
from hummingbird.
Related Issues (20)
- Release v0.1.7 HOT 2
- The Min quantity config is always preselected regardless of the quantity in the cart
- In Order details page - If my product has a downloadable file, I can't download it
- In Shopping cart - If you check the Customized button, there's a warning HOT 6
- Incorrect URL redirection when using browser back button HOT 5
- Guest checkout: Use different invoice address : Can't order
- In product page - The Add to cart button is greyed out when I change quantity to 0 and back to a positive quantity
- Product page - Product price with a volume discount is incorrect until I add the product to my cart
- Tags are not displayed on product details page, quick view and product listing page when product has no image HOT 1
- missing types for `window.prestashop`
- In Shopping cart page, when you put 0 on the quantity and press Enter, the product won't be removed
- When you add a product with a minimal quantity to your cart, the product quantity should be updated
- Unusable menu dropdown when store logo is tall HOT 3
- For the module productcomments, the stars are not displayed on category page HOT 2
- v0.2.0 release does not contain zip packaged version of the theme HOT 1
- ps_mainmenu issue when too many items for one row
- N/A
- Test it hummingbird
- missing CSS class for InPost integration HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hummingbird.