pressly / lg Goto Github PK

I haven't understood what happened yet, but will try again on a later time. Anyway:

hugo@hp ~/play/lg/_example $ go run main.go 
# command-line-arguments
./main.go:55:34: cannot use r (type *chi.Mux) as type context.Context in argument to chi.ServerBaseContext:
	*chi.Mux does not implement context.Context (missing Deadline method)
./main.go:55:34: cannot use serverCtx (type context.Context) as type http.Handler in argument to chi.ServerBaseContext:
	context.Context does not implement http.Handler (missing ServeHTTP method)

I currently use a library that exposes a logrus.Entry and would love to use lg with it but currently the redirect only accepts a logrus.Logger. They seem to have basically the same interface, so it seems viable.

This package still imports github.com/pressly/chi/middleware, but that has been renamed to github.com/go-chi/chi/middleware. Is this package abandoned?

Hi,

Thanks for making this great library available!

We are using it and liking it. However, we don't need both a "request started" and "request complete" JSON log line to be logged, we only need the "request complete" line logged.

Is there an easy way to turn off the "request started" log emission? It's being created in NewLogEntry and maybe we could add a flag to supress this?

# Currently, we get two log lines per request in chi
{ ... "msg": "request started" ... }
{ ... "msg": "request complete" ... }

#We want only one log line per request in chi
{ ... "msg": "request complete" ... }

I could also fork this repo, but I'd prefer not to. Is there a reason for the "request started" log line? Given that the "request complete" log entry catches the interesting data wrt timing, and other fields we might add in our own code, I don't see the need for the "request started" line. It is slowing down our code noticeably and we are paying a third party log hosting company by the GB for hosting our logs, so we want to keep them as small as possible ...

The panic middleware will catch any panics, so I don't see any need for the "request started" line.

Any ideas?

Thanks!