Code Monkey home page Code Monkey logo

px-icon-set's Introduction

px-icon-set Build Status

Overview

Px-icon-set is a wrapper for the Predix icon set which leverages px-icon (a subcomponent of px-icon-set).

Usage

Prerequisites

  1. node.js
  2. npm
  3. bower
  4. webcomponents-lite.js polyfill

Node, npm and bower are necessary to install the component and dependencies. webcomponents.js adds support for web components and custom elements to your application.

Getting Started

First, install the component via bower on the command line:

bower install px-icon-set --save

Second, import the component in your application with the following tag in your head:

<link rel="import" href="/bower_components/px-icon-set/px-icon-set.html"/>

Finally, use the component in your application:

<iron-icon icon="px-fea:analytics"></iron-icon>


Documentation

Read the full API and view the demo here.

Local Development

From the component's directory...

$ npm install
$ bower install
$ gulp sass

From the component's directory, to start a local server run:

$ gulp serve

Navigate to the root of that server (e.g. http://localhost:8080/) in a browser to open the API documentation page, with link to the "Demo" / working examples.

GE Coding Style Guide

GE JS Developer's Guide



Known Issues

Please use Github Issues to submit any bugs you might find.

px-icon-set's People

Contributors

arcpato avatar arongraham-ge avatar benoitjchevalier avatar davidrleonard avatar evanjd avatar katemenkhaus avatar mdwragg avatar priyabrat1801 avatar randyaskin avatar runn-vermel avatar skistz avatar sks avatar talimarcus avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

px-icon-set's Issues

Table Icon

Small Table Icon proposal for APM Analysis

Q2 2018 introduces data tables into APM Analysis. This updates means we'll need to differentiate icons in the Plotted Tags section of the Tag Browser. Up until now, px-doc:chart was used to identify the widget type – it was always a chart.

image

image

Proposed Table Icon

In cases where the user opts for a data table instead, Analysis would update the icon to match the widget.

image

image

Timeline

The icon would need to be included in the Predix icon set before the end of Q2. I can provide the SVG when you're ready.

__VCAP_ID__ cookie is not secured

Hi,

My name is Kobi.
We are using px-icon-set as part of our applications that deployed in Predix.
We also using Tinfoil web scan to scan our app.
our latest scan find the following vulnerability:

URL | ..../bower_components/px-icon-set/px-icon.html
Method | GET
Variable | VCAP_ID
Element | cookie

according to tinfoil the fix should be:
Set the 'Secure' flag in the cookie, such that all cookies are served over a secure channel like HTTPS only

Expected behavior:
px-icon-set component response should not return insecure cookie.

Current behavior:
px-icon-set component response contains VCAP_ID cookie without secure flag.

Steps to reproduce:

  1. integrate px-icon-set in app x (import this component in your html)
  2. upload app x to predix.io
  3. browse to app x
  4. you can see this cookie as part of the response.

License problem

Hi, can you give this project a license so I can deploy it to webjars? Thanks!

Pull Requests

Team,

Are you accepting pull requests?

Regards,

Zaheer

px-doc:document-csv not appearing as expected

I tried to include px csv icon by first importing
<link rel="import" href="bower_components/px-icon-set/px-icon-set.html" />
and also tried by having below two files as an alternative

<link rel="import" href="bower_components/px-icon-set/px-icon.html" />
<link rel="import" href="bower_components/px-icon-set/px-icon-set-document.html" />

But appearing as show below which works fine for other icons like filter.Is there any other dependency needs to be added for document icons ?
excel download

Add Reset Icon

The APM Analysis team is requesting a "reset" icon for the some of the data visualization toolbars. Currently, they're using the "fullscreen" icon. Not ideal.

A quick fix would be to flip the Refresh icon on the vertical axis so that the arrow faces the opposite direction, like so:

image

Engineering says a CSS-flip would not work everywhere so a new icon would be best.

Missing icon from the stencils

The icon for Ingestion that appears on the px-stencils is not part of the icon set available for development.

screen shot 2017-09-28 at 11 45 00 am

Could you add it please?

Refresh icon getting cut around round edges when stroke width is increased.

Hi,

Trying to edit style on px-icon 'px-vis:refresh' by modifying its width, but the icon is getting cut around the edges.
Below image shows how it is getting cut at top and left when icreased stroke-with to 2.5px:
image

We even tried changing stroke-width (stroke-width: 3px) on demo page, similar error was seen.
Please let us know how to handle this.

Time Zone Icon

Analysis needs a 16px icon for timezone selection. We planned to use the font-awesome globe icon prior to Refresh.

image

Development is asking for an icon in-time for Q4.

Icons for APM Analysis

Add icons for APM analysis:
px-fea-time.svg
px-nav-compare.svg
px-nav-data-resolution.svg
px-nav-database.svg
px-nav-summary.svg
px-nav-timezone.svg
px-util-analysis.svg
px-util-asset.svg
px-util-attribute.svg
px-util-swap.svg
px-util-tag-group.svg
px-util-tag.svg

analysis_icons.zip

Icon Request: Healthcare Imaging Machine (Donut + table)

As the leading vendor of Imaging technology (MR, CT), GE Healthcare digital experiences could greatly benefit from the addition of an Imaging Machine icon much like Aviation/Rail benefit from plane/train icons.

For examples of the real machines, check these out for reference
https://www.google.com/search?q=imaging+machine&rlz=1C1GGRV_enUS753US753&source=lnms&tbm=isch&sa=X&ved=0ahUKEwiyqergscjVAhXDdpoKHfrXChYQ_AUICygC&biw=1366&bih=638

For examples of their iconic representation, reference these
https://www.google.com/search?rlz=1C1GGRV_enUS753US753&biw=1366&bih=638&tbm=isch&sa=1&q=imaging+machine+icons&oq=imaging+machine+icons&gs_l=psy-ab.3...161598.162531.0.162671.6.6.0.0.0.0.0.0..0.0....0...1.1.64.psy-ab..6.0.0.xQKyGpfA_FI

Thanks in advance for the consideration
Doug

Icon request: Resize Chart

Create an Icon for Resizing Smart Signal Charts

image

image

Use Case:

Enlarge or reduce the height of a SS chart. Charts can be made taller up to 2 times and made shorter up to 2 times from the tallest point.

Additional Screenshots:

image

image

Desired Doneness:

For this to be complete, the icon should be introduced into Predix by Tuesday 2/20/2018.

Icon Request: Extended Document Types

Our use case would benefit from having additional icons for the following file types:

Zipped files (a zipper on a page, or a page with the letters ZIP)
XML files (the letters XML on a page)
Power points (letters ppt or a pie chart on a page)
Code files as a catch all (a "</>" on a page)

"on a page" refers to the appearance of px-doc:document, a rectangle with a folded corner.

Thank you

QR Code and QR Code Scanner Icons

Submit an Issue

Expected behavior:

I expect there to be a QR code and a QR code scanner icon in the px-icon-set so I can use them in my application. Unfortunately, I am not able to use the px-dropdown the way I want to use it because the icon I need is unavailable.

For example:

<px-dropdown
  items='[{"key":"1","val":"iPhone"},{"key":"2","val":"Android"},{"key":"3","val":"Blackberry"},{"key":"4","val":"Windows Phone"},{"key":"5","val":"Flip Phone","disabled":true}]'
  sort-mode="key"
  button-style="icon"
  display-value="Select"
  icon="<<ERROR: no icon available>>"
  disable-clear>
</px-dropdown>

Ideas

px-obj:controller seems broken

In the compiled version of the icons, the controller icon has a broken piece of XML proecssing instruction in front of the actual SVG:

https://github.com/PredixDev/px-icon-set/blob/c152d734a8744d6bcab813eb7a5c88b8917bcaa4/px-icon-set-object.html#L14

Checking the source SVGs, comparing it against other icons, the controller seems to have the Illustrator generator comment at the top, while the other SVG's don't:
https://github.com/PredixDev/px-icon-set/blob/master/icons/src-obj/controller_32x32.svg?short_path=6ffc9ed

Data Resolution Icon

APM Analysis needs an icon to represent Data Resolution. We had planned to use the "signal" icon from Font-Awesome prior to the Refresh. "Signal" isn't the best choice, but it made the most sense given what font-awesome provided.

image

Development is asking for this icon in-time for Q4.

Add a Delta icon to px-icon-set

This request comes from APM-Analysis. A new feature being introduced in Q3 adds the ability to measure the delta between two points on certain charts. The icon would sit with the chart's toolbar:

image

I've created a "delta" icon, 22px but I need help with the art direction and getting the SVG into the system.

Icon request: nav:collapse, nav:expand left and right

Alternative Expand/Collapse Icons

• APM Analysis uses left/right collapse/expand icons
• An alternative set of icons would work (the current set faces up/down)

Refresh Icons

image

Current Context

The right sidebar move expands from and collapses to the right.
image

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.