pramalhe / concurrencyfreaks Goto Github PK

• DoubleInstanceLockGuard.class
• LongAdderExtRWLock.class
  

You don't have a license file in your repo, making your code impossible to reuse in a commercial or open-source context.

Could you please add a license? May I recommend you use Apache 2.0 because it's both business and open-source friendly (covers patents, copyright, contributions etc).

Here's what GitHub's own Choose-A-License site has to say about the Apache 2.0 license

But really, just pick a license, even if it is to say "we do not provide a copyright license at all, you cannot re-use this code" to reduce confusion. (Although I'd greatly prefer it if you used a liberal open-source license.)

Disclaimer: I am not a lawyer and this is not legal advice.

Hi!

All the lock implementation based on some spin (sched_yield), but you compare with pthread lock that could block, to get better comparison change the pthread from mutex to spin.
Note that when I tested with pthread_spinlock_t it give the best ops/s (So on when I changed the spin implementation to sched_yield in between).

J

In benchmarking, com/concurrencyfreaks/tests is missing which is used by BenchmarkListRelaxedvsVolatile.java

Which queue has the best deallocation behavior when a once large queue is shrunken? I'm looking for a FIFO queue which releases most of it's memory when shrinking again.

I greatly appreciate the work that you have put into this repository.

Reading through your papers and code has influenced a number of descisions that I made in my undergraduate disseration! I was wondering if you would be willing to add a CITATION.CFF file (link to documentation) inside of the repo in order to aid with correctly citing your work.

There doesn't appear to be a readindicators folder committed, but it is referenced in many of the CPP algorithms.

In C++ code c'tor needs to throw when maxThreads out of range. Calls to enqueue and dequeue should fail when tid out of range. Checking for those values being negative can be avoided by changing parameters from int to unsigned...
Jack Goral

You may want to modify the github project page to link to http://concurrencyfreaks.blogspot.com/ instead of http://www.concurrencyfreaks.com/