Code Monkey home page Code Monkey logo

my-favorite-superhero's Introduction

Hacktoberfest 2023

Hacktoberfest is DigitalOcean’s annual event that encourages people to contribute to open source throughout October. Much of modern tech infrastructure-including some of DigitalOcean’s own products-relies on open-source projects built and maintained by passionate people who often don’t have the staff or budgets to do much more than keep the project alive. Hacktoberfest is all about giving back to those projects, sharpening skills, and celebrating all things open source, especially the people that make open source so special. For the past 10 years, thousands of people-coders and non-coders alike-have participated in Hacktoberfest to support the projects they use and love, learn and practice skills that will enhance their careers, and meet new people who love open source as much as they do.

WhatsApp Image 2023-10-07 at 10 01 52_3e088db0

Contributions to this repository will count towards Hacktoberfest participation this year.

Welcome to My-Favorite-SuperHero

image

Welcome to the My Fav Superhero project! This web application allows you to search for your favorite superhero's image and discover random superhero images with just a click. Whether you're a superhero enthusiast or just looking for some fun, this project is for you.

About

image

More information about this project and Hactoberfest will found on the about page.

Contributor

image

Here are the wonderful contributors who have helped shape the My Fav Superhero project; some of them are listed on the contributor page.

Demo

You can see a live demo of the project here: My Fav Superhero Demo

🙌 Features

  • Search Superheroes: Enter the name of your favorite superhero, and the website will display the superhero's image along with some basic information.

  • Random Superhero: Click the "Random" button to discover random superhero images and learn about heroes you might not have known before.

⚡Tech Stack Used

HTML5 CSS3 JavaScript

🚀 Getting Started

To use the My Fav Superhero project, simply open the index.html file in your web browser. There's no need for complex setup or dependencies.

  1. Clone this repository to your local machine:

    git clone https://github.com/Prajwal0225/My-Favorite-SuperHero.git
  • Open the index.html file in your preferred web browser.

  • Start searching for your favorite superheroes or enjoy random hero discoveries.

If you want to contribute to this project then check out CONTRIBUTING.md file.

Issue Assignment Guidelines and Collaboration Process 📌

  • 📝 Issue Assignment: Before you start working on any issues, please make sure that the issue is assigned to you. If it's a new issue, create one if it doesn't already exist. 📌

  • 👤 One person will be assigned one issue at a time. When you raise a pull request for that issue, only then can you create the next issue. Work on one issue at a time, and once the pull request for that issue gets merged, you can create another issue. This approach allows maximum contributors to have a chance to contribute, resulting in more work being done on the repository. 🏃‍♂

  • 🚫 Avoid Direct PRs: Refrain from creating direct pull requests (PRs) for issues that are already assigned to someone else. This helps prevent duplicated efforts and keeps our work organized. Even if an issue is not assigned to anyone, you should create the issue first. Only when a maintainer assigns it to you, you can then raise a PR. 🚧

  • 👉Please submit a pull request within 2 to 3 days after you have been assigned an issue. 😊 Failure to do so may result in the reassignment of the issue to another contributor. 🔄

  • 🤝 Collaboration: If you find that an issue is already assigned to someone and you're interested in working on it, feel free to comment on the issue. If the first assigned person isn't able to complete the task or doesn't create a PR, we can reassign the issue to ensure it's addressed properly. Normally, we assign the issue to the person who created it. If they are not interested in working on it, we assign it to someone who is interested. You can comment if you want to work on it. 💬

Your cooperation is greatly appreciated, and it helps us maintain an efficient and collaborative development process. 🙌 Happy coding! 🚀

Project Maintainers


Prajwal

Madhura

Our Beloved Contributors 😍



✨✨ A big thanks to all our contributors who have made this project better with their valuable contributions! We appreciate your efforts and dedication.

DON'T FORGET TO ⭐ THIS REPOSITORY !!

Back to top

my-favorite-superhero's People

Contributors

akhilender-bongirwar avatar aryan1982 avatar bhavya-anand19 avatar divyansh-4 avatar divyansh14kr avatar ferdiansyah0611 avatar harshd008 avatar harshhgithub avatar hrishap avatar ir786921 avatar ishikagoyal02 avatar love-sonkar avatar lusifer65 avatar madhurafulkar avatar manipandit avatar mldamico avatar pavilion-devs avatar pinaka-pani-18 avatar piyushk79 avatar pragati-deshmukh011 avatar prajwal0225 avatar pranavnk15 avatar pushkar1713 avatar sakshin021 avatar samrat2k03 avatar saurav2208 avatar sebastianshrisunder avatar suhas-sensei avatar usman-rizwan avatar w3schools-test avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

my-favorite-superhero's Issues

update navbar

can you assigned to me i can fix and improve the navbar

Folk dances

Creating an Indian map clicking on each state will direct us to folk dances using html and css

Refactor getSearchSuperHero Function for Improved Readability and Robust

The getSearchSuperHero function currently retrieves superhero data from an external API and updates the DOM based on the response. While the core functionality is in place, there is room for improvement in terms of code readability and error handling.

Proposed Changes:

Improve Code Readability:

Enhance variable naming to make the code more self-explanatory.
Consider breaking down the functionality into smaller, more focused functions or using comments to clarify the code's purpose.
Enhance Error Handling:

Implement more detailed error handling to provide meaningful error messages and potentially offer a fallback mechanism for users in case of errors.
Ensure that error messages are clear and informative, aiding debugging efforts.
Documentation:

Document the function with comments or JSDoc-style documentation to explain its purpose, parameters, and expected behavior.
Provide a brief explanation of how the function interacts with the DOM and external APIs.
Testing:

If not already in place, consider writing unit tests to validate the function's behavior under various scenarios, including error cases.
By addressing these points, we can make the getSearchSuperHero function more maintainable and user-friendly, while also ensuring that it handles errors gracefully.

Implement Dynamic Year Display in Footer

Currently, the year in the footer is hardcoded, which means it doesn't automatically update to the current year. To improve the user experience and ensure the accuracy of the year displayed, we should make it dynamic.

Proposed Solution

Implement a mechanism that dynamically fetches and displays the current year in the footer. This way, users will always see the correct year without manual updates.

Improve Button Design and container width

Hey Prajwal,

I hope you're doing well. I wanted to bring up an issue regarding the design of our buttons, the input search field, and the container width for certain elements, including the need for rounded corners on images.

The current button design may need improvement in terms of user experience and visual aesthetics. Additionally, the input search field is crucial, and we should ensure it is user-friendly. Please consider these aspects and any potential changes. I also suggest maximizing the container width for specific elements and adding rounded corners to images to enhance our overall interface. Your expertise is highly valuable, and I trust your judgment in making our product more user-friendly and visually appealing. Let's discuss this further in our upcoming design meeting. Thank you for your attention to these design concerns, Prajwal.

Website Needs a more lively background

Although the background is soothing ,but it can be made much attractive if we add a fantastic background image with some transitions on hovering over.

The links in header are not working.

1 issue - Even though the UI looks good but the links in the header are not working, it goes to a 404 error page.

2 issue - I searched Spiderman, but it didn't fetched the images of him. So it may be that the api used doesn't contain the images of some superheros.

3 issue- The hover button of the search button is grayish and not going with the website.

4 issue- As soon as the user enter the name of the superhero and press the enter button the website does not search the hero until the search button is clicked. I would like to add the enter key search functionality to the search.

Please assign this issues to me under HacktoberFest 2023 so that I can start working on it.

Fix Inconsistent Footer Placement for Improved User Experience

Description

The footer in our project is currently inconsistent. On the home page, it is not consistently at the bottom of the page, and when searching for superhero images, it is loaded in a way that causes the footer to shift down. This inconsistency affects the visual appeal and user experience of our project.

Expected Behavior

The expected behavior is to have a consistent footer placement throughout the project. The footer should always be at the bottom of the page, regardless of whether users are on the home page or searching for superhero images. This will provide a more uniform and visually pleasing user experience.

Screenshot

Home Page
image
When Searching Favourite Hero
image

Additional Context

Resolving this issue is essential for improving the overall visual appeal and user experience for our project's users. Inconsistencies in the footer placement can give the impression of an unpolished user interface. Ensuring that the footer remains consistently at the bottom of the page will contribute to a more professional and user-friendly design.

  • I have read the Contributing Guidelines.

Backup font

Current css only has one font, include a generic font family as a fallback in case the custom font fails to load

Enhance Superhero Image Size for Better Aesthetics

Description:
The current display of the superhero image after searching appears smaller and does not provide an attractive user experience. To improve the visual appeal of our project, we need to increase the size of the displayed image.

Image :
increase the image size

Task Details:
Increase the size of the displayed superhero image for better aesthetics.

Enhance API Key Security

The current implementation exposes the Superhero API key directly in the client-side JavaScript code. It's not recommended to expose your API keys in client-side code as it can be accessed by anyone. Consider moving it to a server-side environment or using environment variables.

Impact

Exposing the API key presents a security risk for potential misuse of the key if discovered. It's a best practice to avoid embedding secrets in client-side code.

Moving the key to a server-side env var or secrets service will improve security and prevent leakage of the key.

Improvement of searchbar

Searchbar is swallowing some texts as we see it on a small screen. I want to fix this issue if you assign it to me.

Before Screenshot
Screenshot (16)

After
Screenshot (17)

Assign this issue to me. It will be a pleasure to work on this project.

Add a customized scrollbar

  • To improve the website's design I would like to add a customized scrollbar.
  • This will enhance the user experience.

Search Bar UI

Hey i would suggest that when user focus on the search bar the text would clear up
It would be more user friendly.

Screenshot (51)

Adding About Page

Adding About Page would be enhance the website experience
Assign me this task under Hacktoberfest
about

Update readme

I want to update readme file. I will add information about Hacktoberfest and contributors of this repository.

Improve the navigation bar

I want to work on the naviagtion bar and try to improve/implement the following changes

  • Change the background color
  • Change the font and also add change color property on hover
  • Centre the 3 elements (home, about, contributors).

Navigation Button UI and other UI changes

The search button is not aligned properly with the search bar. The download button can be better placed under the image to create an even look. The hover color of the "Random Hero" button can be changed to a one which is more relevant to the current UI.

Create Navigation Bar with Home, About, and Contributors Sections

Description:
We're looking to enhance the user experience of our website by implementing a navigation bar that will provide easy access to essential sections. This navigation bar should include sections like Home, About, and Contributors.

Task Details:

Navigation Bar Design: Develop a simple and user-friendly navigation bar that aligns with our website's style and layout.
Home Section: This is the link to our website's main page, which will remain unchanged.
About Section: Create a 'About' page with an H1 tag that says "Coming Soon".
Contributors Section: Similarly, generate a 'Contributors' page with an H1 tag indicating "Coming Soon."
Responsive Design: Ensure the navigation bar functions well on all screen sizes and devices, maintaining a pleasing appearance and usability.

We will add the Code to the About and Contributors page afterward.

Testing the workflows

  • This is a dummy issue which is used for testing the comment-on-issue workflow.
  • Hope it will be working now.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.