Hello there, would you mind improving the peer dependency specification of the esbuild-node-externals package? It currently specifies
esbuild: ^0.13.0 which leads to yarn complaining when upgrading esbuild to v0.14. The reason is because the ^ only allows newer versions that do not increment the first non-zero portion of the version. In your readme you write that esbuild from version 0.8 is supported, so I suggest something like esbuild: >0.8.

Or probably better if you want to check for breaking changes with each release that bumps the minor version counter you could specify a range: esbuild: 0.8 - 0.13.

If you want to play around with the version specifier, there's this site: https://semver.npmjs.com/

There are some breaking changes in 0.13 release (https://github.com/evanw/esbuild/releases), but it seems to work fine for this plugin.

I would want to make external just one package, sometimes two. There's externals in webpack. It is useful for packages that have binaries.

If you agree, I can submit a PR.

First of all, thank you for this awesome plugin!

However, I run into an issue. Some npm dependencies aren't marked as external. When I check the onResolve code, turns out that it only checks the first part of args.path, split by the forward slash character. This made the plugin misses some package such as @typegoose/typegoose, since it will compare it to @typegoose and will return mismatch!

On the meantime, I have forked your repo and provided my solution on this issue. You might want to implement it, or maybe you have your own fix.

esbuild 0.15 has been released and this error occurs during npm install. --force is needed to ignore the error.

npm ERR! Found: [email protected]
npm ERR! node_modules/esbuild
npm ERR!   dev esbuild@"^0.15.5" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer esbuild@"0.12 - 0.14" from [email protected]
npm ERR! node_modules/esbuild-node-externals
npm ERR!   dev esbuild-node-externals@"^1.4.1" from the root project

Hi :)

I found a potential bug in the plugin's onResolve hook. When i have a scoped package in my allowList like @myrepo/foobar and want to import a subpath of it @myrepo/foobar/logging the plugin would ignore bundling of the package and set external: true for the package.

Example:

// in plugin
esbuild.build({
  // ...
  plugins: [nodeExternalsPlugin({
    allowList: ['@myrepo/foobar']
  })],
});

// in code
import logging from '@myrepo/foobar/logging'

Outcome: The plugin would mark @myrepo/foobar as external.
Expected: The plugin would NOT mark @myrepo/foobar as external

Thanks for the lib btw :)

Consider a pnpm monorepo:

packages/foo (depends on axios, bar)
packages/bar (depends on express)

I would like to have foo and bar compiled, but keep axios and express as external.

If I create the build script for foo:

const { build } = require('esbuild')
const { nodeExternalsPlugin } = require('esbuild-node-externals')

build({
  // ...
  plugins: [
    nodeExternalsPlugin({
      allowList: ['bar']
    })
  ]
})

then foo, bar and express are compiled, and only axios is considered external.

Ideally, I would like the plugin to handle the monorepo setup automatically (recognize that bar is not even a package inside node_modules without having to specify any option, not even allowList).

Hey there! I was attempting to debug a tree-shaking issue I was seeing and identified that when I include this package, esbuild's out-of-the-box tree-shaking fails to execute. I have a repro that you can view here: dustinsgoodman/serverless-microservices-graphql-template#85

What I'm finding is if I include this plugin, I have my node_modules bundled up separately like I want, but then my main bundle is still including all imported functions regardless of use in the app. There are screenshots in the linked PR highlighting the lack of tree-shaking if you look for at the "sqs" imports.

Let me know what additional information I can provide.

The package has a peerdependency on esbuild 0.12-0.16. https://github.com/pradel/esbuild-node-externals/blob/main/esbuild-node-externals/package.json

I do not know if code changes are needed to support esbuild 0.17 but checking for those and then bumping the peer dependency is needed to enable users to install esbuild 0.17 along with this package.

Hi, awesome plugin!

Would you consider supporting allowlist in the same fashion as the webpack plugin? The idea is that dependencies included in the allowlist would be bundled in the output.

Alternatively I can submit a PR?

Currently, this package requires esbuild within this version range:

"peerDependencies": {
    "esbuild": "0.12 - 0.18"
  },

Alternatively, if there is some way to do within esbuild core what this packages is doing for versions after 0.18, could we document it within the readme? I did a quick look at the changelog in esbuild but am unclear on whether its enhancements make this package unneeded.

Thank you 😄