pr1mer-tech / waffle-grid Goto Github PK

run-sequence dev-dependency is out of date.

The gutter is currently being placed only on one side of the column, shifting the whole layout on mobile.

It definitely needs a build in Scss and Sass. If you are too busy, I can do a PR 😊.

It would be awesome to have Waffle support column, pushes, and pull values as col-3.5-of-12 or push-2.5-of-12 or pull-3.5-of-12. Currently entering values with remainders seems to breaking those column sizes.

there is a typo
npm install waffel-grid
instead of
npm install waffle-grid

I had an error because of it, but I was curious enough to check the npm itself

Love the framework, and it's all good having it available on npm. But since it's CSS framework, would be super helpful to have it also available via bower.
Would be great to have a it as a bower dependency 😄

The global site variables don't work. For example {{site.cdn}} Just outputs blank, whilst {{site.baseurl}} works just fine

The site is showing the README instead of showing the site in the /docs folder

Some of the links doesn't work, and it's extremely annoying!

Note: for support questions, please use stackoverflow. This repository's issues are reserved for feature requests and bug reports.

• **I'm submitting a ... **

  • feature request
  • bug report
  • support request => Please do not submit support request here, see note at the top of this template.

• Do you want to request a feature or report a bug?
  Most of the grid classes can be customized with the exception of the helper clases
  https://github.com/lucasgruwez/waffle-grid/wiki/Using-the-grid#helper-classes

• What is the current behavior?
  Currently you cannot prefix these classes which creates conflicts with other packages.

• What is the expected behavior?
  Allow to have a scss variable you can set to prefix helper classes/

Hi Lucas,

thank you for Waffle, it is a bless for me! 👍

I'm updating to 1.3.4 and I see that if I have:

• grid
• • row
• • • col col-5-of-12 push-1-of-12 col-m-4-of-4 m-un-push
• • • col col-5-of-12 col-m-4-of-4

to have a 1551 layout, I get an asymmetry when layout is reduced to "m".

This happens because "col" has a margin:10px, but m-un-push is setting margin: 0;

In my case this is solved by replacing margin: inherit; but I understand milage may vary

(no dev here, sorry)

Hope this help,
Daniele

Hi,

I'm using this in SPA context and as a global dependency that isn't getting scoped by setting a scoped attribute, it's affecting generic classes of scoped components with classes like center, right, etc'. If you could give an option to scope these, it solves my issue.

The download button is cut between Download and v1.2.0, as the button seems to be too large.

It seems the docs are no long coherent as this variable is nowhere to be found. How do you generate different columns for mobile now?

When you try to download the grid from the website, GitHub throws a 404 error...

Hi @lucasgruwez,

just a question on the .grid class on why the need for the display: flex; and flex-direction: column;?
Flex columns rely on height being set to utilise some of the other flex properties like justify-content, etc.

The main properties of the .grid class seem to be acting more like a container then a grid wrapper.
Seems like more of a special case - as your example on the site doesn't require it.

Just curious as a fellow flex framework dev. 😁