Code Monkey home page Code Monkey logo

Comments (6)

ppete2 avatar ppete2 commented on September 25, 2024

Hello, I just tried it with https://ppete2.github.io/Leaflet.PolylineMeasure/demo3.html which uses th option clearMeasurementsOnStop: false.
On a local copy of this site, I changed option to clearMeasurementsOnStop: true.

Both cases are working without errors. So maybe it's because your site which uses the Measure add-on isn't using the latest version of the script? If you open the file "Leaflet.PolylineMeasure.js" you should read "Version: 2018-10-22" in the first lines.

Maybe it's a problem with npm as you mentioned. Please read what I wrote in chapter "Package manager install" in my add-ons manual.

from leaflet.polylinemeasure.

bodryi avatar bodryi commented on September 25, 2024

Definitly yes, the problem exists only in npm package "leaflet.polylinemeasure": "^2.0.0", I wrote about it in UPD2 part of my issue.

If I understood you correctly, you're not going to update your plugin at npm registry? I use npm to manage my dependencies, so it will be mush better to mange all of them in the same style.

from leaflet.polylinemeasure.

ppete2 avatar ppete2 commented on September 25, 2024

I'm not going to update npn files myself, since I'm no packet manager expert, and added the packet manager things just because some users asked me to do. If you want updated npn-files, you either have to update them yourself via a Pull request here. Or ask some of the guys, who initially did provide this files, to help you.

If you are a packet manager expert, and just a few lines within a files have to be changed I exeptionally would do this for you. In this case tell me exactly what lines in what files I have to change.

from leaflet.polylinemeasure.

bodryi avatar bodryi commented on September 25, 2024

@ppete2 OK, I understood. Here's a guide how to publish your package to npm registry: https://hackernoon.com/how-to-publish-your-package-on-npm-7fc1f5aae600.

Required fields are already filled in your package.json if I'm not mistaken and you only need to change version from 1.0.0 to at least 2.0.1, because 1.0.0 and 2.0.0 are published by someone and then run npm publish.

from leaflet.polylinemeasure.

ppete2 avatar ppete2 commented on September 25, 2024

Hi, I think I therefor have to download extra software (npn?) etc... not just change a few textlines at github.
Sorry, but I won't do this. But if you want fix this on your own using npn software, you're welcome. I also did a search for my plugin here: https://www.npmjs.com/search?q=polyline%20measure and noticed that 3 different entries are refering to my addon. So you perhaps should think about what of them to update - just 1, or each 3 ?

from leaflet.polylinemeasure.

bodryi avatar bodryi commented on September 25, 2024

You're only responsible for your own repo and don't need to update any of them. I found, that someone already published your plugin here: https://www.npmjs.com/package/leaflet.polylinemeasure.latest.

It's strange, that third party people need to publish package instead of maintainer, but it's your solution and I have nothing to do with it.

I think, that we can close issue, because it's clear, how to fix this bug. Thank you for quick replies.

SOLUTION: install latest version from repo link or find leaflet.polylinemeasure published by someone without this bug.

P.S. npm - node package manage, if you're frontend developer, I guess there's 99% that you already have it installed because it's delivered with node.js.

from leaflet.polylinemeasure.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.