postedin / ember-ckeditor Goto Github PK

Loving this package and trying to install on a brand new installation of Ember 4.8 (CLI)

Running into an issue with @glimmer/manager.js ~line 825

function modifierCapabilities(managerAPI, optionalFeatures) {
    if (optionalFeatures === void 0) {
      optionalFeatures = {};
    }

    if (true
    /* DEBUG */
    && managerAPI !== '3.22') { // << Error here, managerAPI is 3.13
      throw new Error('Invalid modifier manager compatibility specified');
    }

    return buildCapabilities({
      disableAutoTracking: Boolean(optionalFeatures.disableAutoTracking)
    });
  }

Seems to be a version mismatch with @ember/render-modifiers

Upgrading to "@ember/render-modifiers": "^2.0.4" seems to do the trick .. but I'm not really set up to test whether this fix is viable for release.

Any advice would be appreciated. I've created a fork of ember-ckeditor and using that in the meantime.

Kudos once again for this addon, it works so well with the latest builds of CKEditor and I'm using it with a custom build and some customizations.

I'm trying to write some sanity tests for my app and I'd like to test the editor using QUnit.

I did a bit of digging and the typeIn helper actually works with contenteditable fields, discussion here: emberjs/ember-test-helpers#793

As far as I can tell, at its core the editor has a contenteditable field, something along these lines:

I've tried writing a test to simply enter some text

test('Clear Text', async function (assert) {

  // Set any properties with this.set('myProperty', 'value');
  // Handle any actions with this.set('myAction', function(val) { ... });
  await render(hbs`<MyWhiteboard />`);
  
  await typeIn('.ck.ck-content.ck-editor__editable', 'This is a test');
  assert.dom('button.clear-text').exists();
  await click('button.clear-text');

});

From what I can tell, it finds the element and fires off all the events but nothing ever appears in the editor.

As I write this now I'm starting to wonder if we ought to use CKEditorInspector or something like the getData and setData helpers. (https://ckeditor.com/docs/ckeditor5/latest/framework/guides/development-tools.html#testing-helpers)

I'll give it a try and follow up!