postcodeservice / postcode-magento2 Goto Github PK

To Reproduce
Steps to reproduce the behavior:

1. Configure the postcode module in test mode.
2. Try to checkout an item
3. Click on 'proceed' on first step of checkout after filling all the required fields

Expected result
Go to the next step of the checkout.

Actual result
Nothing happens. No console erros, no application logs entries. The street field is filled in as expected (a.k.a. the module is working)

Workaround
None found (yet)

** Please complete the following information**

• Magento version: 2.4.3-p2
• PHP version: PHP 7.4
• Postcode module version: 1.5.1

To Reproduce
Steps to reproduce the behavior:

1. Go to a checkout page
2. Enter a valid postcode
3. Wait for validation

Expected result
A valid postcode should always return a street and city and place them in the corresponding field. The address and city fields should become visible for the end user.

Actual result
No address is being returned and an error is being displayed, telling the end user that the address is invalid and they have to manually enter an address. The street field is visible, but the city fields stays hidden.

After changing the postcode (for example from lowercase to uppercase) a second check is done, which does return a street and city. The street field is being field with the data returned from the API, but the city field stays hidden.

When going to the payment step, the city is empty as well, rendering an error for the user.

Workaround
None

Screenshots

Please complete the following information

• Magento version: 2.4.3-p1
• PHP version: 7.4.28
• Extension version: 1.5.1

Additional information

In some cases the module returns a PHP error. However, these error do seem related to the problem, since they don't happen at the same moment the end user is in the checkout. I'm still including the error here, because maybe this is still related.

TypeError: Argument 5 passed to TIG\Postcode\Plugin\Checkout\Model\GuestPaymentInformationManagement::beforeSavePaymentInformation() must be an instance of Magento\Quote\Api\Data\AddressInterface, nul
l given, called in /data/web/magento2/vendor/magento/framework/Interception/Interceptor.php on line 121 and defined in /data/web/magento2/vendor/tig/postcode-magento2/Plugin/Checkout/Model/GuestPaymentInformationManagement.php:62
Stack trace:
#0 /data/web/magento2/vendor/magento/framework/Interception/Interceptor.php(121): TIG\Postcode\Plugin\Checkout\Model\GuestPaymentInformationManagement->beforeSavePaymentInformation()
#1 /data/web/magento2/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Checkout\Model\GuestPaymentInformationManagement\Interceptor->Magento\Framework\Interception\{closure}()
#2 /data/web/magento2/generated/code/Magento/Checkout/Model/GuestPaymentInformationManagement/Interceptor.php(32): Magento\Checkout\Model\GuestPaymentInformationManagement\Interceptor->___callPlugins()
#3 [internal function]: Magento\Checkout\Model\GuestPaymentInformationManagement\Interceptor->savePaymentInformation()
#4 /data/web/magento2/vendor/magento/module-webapi/Controller/Rest/SynchronousRequestProcessor.php(95): call_user_func_array()
#5 /data/web/magento2/vendor/magento/module-webapi/Controller/Rest.php(188): Magento\Webapi\Controller\Rest\SynchronousRequestProcessor->process()
#6 /data/web/magento2/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Webapi\Controller\Rest->dispatch()
#7 /data/web/magento2/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Webapi\Controller\Rest\Interceptor->___callParent()
#8 /data/web/magento2/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Webapi\Controller\Rest\Interceptor->Magento\Framework\Interception\{closure}()
#9 /data/web/magento2/generated/code/Magento/Webapi/Controller/Rest/Interceptor.php(23): Magento\Webapi\Controller\Rest\Interceptor->___callPlugins()
#10 /data/web/magento2/vendor/magento/framework/App/Http.php(116): Magento\Webapi\Controller\Rest\Interceptor->dispatch()
#11 /data/web/magento2/generated/code/Magento/Framework/App/Http/Interceptor.php(23): Magento\Framework\App\Http->launch()
#12 /data/web/magento2/vendor/magento/framework/App/Bootstrap.php(264): Magento\Framework\App\Http\Interceptor->launch()
#13 /data/web/magento2/pub/index.php(29): Magento\Framework\App\Bootstrap->run()
#14 {main} [] []

As a merchant I'd like to have the Postcode Service with compatibility with Hyva checkouts so that I have a code base ready for implementation.

Submitting issues through Github

Please follow the guide below

• Put an x into all the boxes [ ] relevant to your issue (like this: [x])
• Use the Preview tab to see what your issue will actually look like.
• We may ask some questions or ask you to provide addition information after you placed your request.

Make sure you are using the latest version: https://tig.nl/totale-aanbod-extensies/postcode-service-magento-2/

Issues with outdated version will be rejected.

• [ X ] I've verified and I assure that I'm running the latest version of the TIG Postcode Magento 2 extension.

What is the purpose of your issue?

• [ X ] Feature request (request for a new functionality)
• Bug report (encountered problems with the TIG PostNL Magento 2 extension)
• Extension support request (request for adding support for a new extension)
• Other

If the purpose of your issue is a feature request

• As a merchant I would like to be able to install Postcode on the upcoming Magento 2.3 version in order to stay up-to-date with the latest security patches.

If the purpose of your issue is about anything else, please describe your issue here

• Magento 2.3 has a lot of changes, especially in the frontend. Magento version 2.3 will most likely break the extension in its current form. Changes will be required to make the extension compatible with the latest version.

Question
Hey, I was wondering why the house number field is not marked as a required field. The hidden magento field still gives an error and prevents the user from going to the next step of the checkout without any visible error messages, causing possible confusion.

I assumed this was the intended behaviour given the fact that this is also looks to be the case for the examples in the readme.

To Reproduce
Steps to reproduce the behavior:

1. Add products to basket
2. Continue
3. Login as customer
4. Proceed to shipping
5. Proceed to payment
6. Add discount code

Expected result
Discount code gets applied

Actual result
Order is stuck with loading spinner wheel

Workaround
don't apply discount

Screenshots
If applicable, add screenshots to help explain your problem.

** Please complete the following information**

• Magento 2.2.4
• Postcode_magento2 1.3.3

To Reproduce
Steps to reproduce the behavior:

1. Enable another country next to BE and NL. For example Germany
2. Go to checkout
3. Select Germany

Expected result
TIG Street is hidden and not required

Actual result
TIG Street is shown and required. Now there are two street fields

Workaround
None, I'm wrting some JS for fixing this bug and other TIG bugs

• Magento version: [Magento 2.4.5]
• PHP version: [8.1]

Question

When this extension is enabled, the edit link in the checkout for a newly added address disappears, comparing it to a stock Magento installation.

I see it is coming from this line: https://github.com/tig-nl/postcode-magento2/blob/master/view/frontend/web/template/shipping-address/address-renderer/default.html#L27

My question is, why is the edit link hidden/not visible?

The new customer account implementation does not check if the module is enabled for the store view. This means the javascript code that hustles the fields is always loaded.

Expected behaviour

Frontend implementation respects enabled/disabled status at store level.

When you split address fields to have separate values for street, housenumber and extension this is not compatible with display in the customer account.

For this to work nicely we set customer/address/street_lines to 1. Otherwise we have 3 street lines in the checkout. The customer account address form now shows 1 line, but without housenumber and extension that were filled in the checkout.

Additionally, going back to the checkout with a saved address, you get an error "Address" cannot contain more than 1 lines.

Please rephrase the following line:

The file Plugin/View/Page/Config/Renderer.php adds some css files to the head, according to the specific chosen configuration. But these css file act as blocking resources, which results in high loading times that affect the performance scores.

Suggestions and background

It would be great that those css files are refactored to .less, and maybe add a class to the body (instead of adding css files to the head), so the classes in the less files would apply.

Magento:2.2.6
TIG Magento 2 Postcode extension: 1.1.11
Checkout usage: Two Step Checkout Blank

At the checkout page I get this message.

Notice: Undefined index: dataScopePrefix in xxxx/vendor/tig/postcode-magento2/Plugin/Address/LayoutProcessor.php on line 122

Is it oke to ignore this message using this edit?

$billingFields['children']['form-fields']['children'] = $this->processAddress(
$billingFields['children']['form-fields']['children'],
'', <<-- // $billingFields['dataScopePrefix'],
[]
);

We found fatal errors in the php logfile.

[11-Dec-2018 23:11:13 UTC] PHP Fatal error:  Uncaught Error: Call to a member function getExtensionAttributes() on null in /sitepath/vendor/tig/postcode-magento2/Plugin/Address/Management/GuestPayment.php:68
Stack trace:
#0 /sitepath/vendor/magento/framework/Interception/Interceptor.php(121): TIG\Postcode\Plugin\Address\Management\GuestPayment->beforeSavePaymentInformation(Object(Magento\Checkout\Model\GuestPaymentInformationManagement\Interceptor), 'afasdfsfsefa...', 'afewfef@sfsdf...', Object(Magento\Quote\Model\Quote\Payment\Interceptor), NULL)
#1 /sitepath/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Checkout\Model\GuestPaymentInformationManagement\Interceptor->Magento\Framework\Interception\{closure}('afasdfsfsefa...', 'afewfef@sfsdf...', Object(Magento\Quote\Model\Quote\Payment\Interceptor), NULL)
#2 /var/domain in /sitepath/vendor/tig/postcode-magento2/Plugin/Address/Management/GuestPayment.php on line 68

\TIG\Postcode\Plugin\Address\Management\GuestPayment::beforeSavePaymentInformation

$attributes = $billingAddress->getExtensionAttributes();
        if (empty($attributes)) {
            return [$cartId, $email, $paymentMethod, $billingAddress];
        }

Maybe its better to check if billingAddress is not null and have ExtensionAttributes.

Because of Plugin/Address/LayoutProcessor.php:157 in BE the core group component is used while the TIG component is used for NL: view/frontend/web/js/view/form/fields.js. Now the housenumber and additions are not merged on the street field in BE.

To Reproduce
Steps to reproduce the behavior:

1. Make sure to have an account with an address.
2. Try to change and save the street and house number.

Expected result
A complete address (including street field)

Actual result
An address where the street field is not present.

Workaround
None (That I know of)

Screenshots
See attached screenshot.

** Please complete the following information**

• Magento version: 2.4.3-p1
• PHP version: 7.4.8
• TIG Postcode extension version: 1.4.1

Maybe not a bug per se. But I didn't know how to report it in another way.

To Reproduce
Steps to reproduce the behavior:

1. Go to checkout
2. Remove the checkbox for "Billing and shipping address are the same"

Expected result
I expect the dropdown menu with different addresses to show, so I can select another address. Just like Magento native behavior.

Actual result
Instead, the extension adds a new button called "Edit". After clicking this button, the dropdown does show up. But this step is unnecessary and a bit confusing.

Workaround
Actually use the button :)

Screenshots
See below

** Please complete the following information**

• Magento version: 2.4.3-p1
• PHP version: 7.4.8
• TIG Postcode extension version: 1.4.1

I am testing the module together with Mageplaza checkout but after installing your extension I am getting a blank page when opening onestepcheckout. After changing below file I can open it again only the fields are not positioned on sortOrder 3 but are placed at the bottom.

File: postcode-magento2/Plugin/Mageplaza/AddressHelper.php

row 32: namespace TIG\Postcode\Plugin\MagePlaza;

change: namespace TIG\Postcode\Plugin\Mageplaza;

As a user I want postcode validation when I insert/update my address in my account address book.

Although available in the checkout the customer account address book allows me to fill in any value.

Magento 2.3.2
Theme: Magento/luma
tig/postcode-magento2: 1.2.4
Checkout usage: Two Step Checkout Luma
House number field: Street address line 1

On the shipping step fill address details via success postcode autocomplete and go to the payments step
the house number available in the shipping info

select payment method and change billing address by another valid postcode and house number and house number disappears from shipping address info

To Reproduce
Using:

• Magento OS 2.4.3-p2
• tig/postcode-magento2 1.5.1

Steps to reproduce the behavior:

1. Run bin/magento setup:upgrade after installing the module using composer

Expected result
No errors

Actual result

Unable to apply data patch TIG\Postcode\Setup\Patch\Data\AddTigEavAttributes for module TIG_Postcode. Original exception message: The attribute can't be saved.

After some quick debugging, this happens with the attribute tig_housenumber in the addAttributeToForms method the moment $this->attributeRepository->save() is called.

Workaround
None

Screenshots
None

Please complete the following information

• Magento version: OS 2.4.3-p2
• PHP version: 7.4.30

Extra
This is on a nearly empty Magento installation, only contains a couple of 3rd party modules.
If you are unable to reproduce, please let me know and I'll put some more time in trying to find better steps to reproduce

Thanks!

Hi,

This extension works great on the default checkout page of Magento 2. In most of our projects we're using the OneStepCheckout from Mageplaza. Are there any plans to support this extension?

Regards,
Silvan

Question
I noticed that the latest tag v1.2.5 is not available on Packagist, could you please check and or update the package there?

The current module required magento/module-quote 101.0.5, but is locked at that version.
Since Magento 2.2.7 uses magento/module-quote 101.0.6, can you update the composer.json, so it also supports 101.0.6?

Question
Hello, with the Amasty OneStepCheckout we can rearrange the shipping and billing fields. But I have no succes rearranging the address fields.

I would like to display the postcode/housenumber (shipping-address-fieldset) first, after that the address (street) field. How can I accomplish that? Thank you in advance!

To Reproduce
Steps to reproduce the behavior:

1. Enable Onestepcheckout
2. Sort and enable postcode, tig_housenumber, tig_housenumber_additional and tig_street field

Expected result
Postcode field is rendered before tig_housenumber and tig_housenumber_additional

Actual result
Postccode field is sometimes rendered before tig_housenumber, sometimes completly elsewhere

Workaround
None, I'm wrting some JS for fixing this bug and other TIG bugs

• Magento version: [Magento 2.4.5]
• PHP version: [8.1]

To Reproduce
Steps to reproduce the behavior:

1. Go to checkout, country NL, with locale nl_NL
2. Fill in a non-existing postcode/housenr combination

Expected result

1. A Dutch error message (as present in the translation file in your module)
2. A Dutch label for the house number addition field

Actual result
Message and field label are English. (looking at the module I noticed 'house number', 'housenumber', 'house number addition' and 'housenumber addition' being used random.

Workaround

1. I've created a patch for the error message making it translatable in view/base/web/js/postcode-handler/postcode-nl.js
2. Add translations in theme

Screenshots
If applicable, add screenshots to help explain your problem.

** Please complete the following information**

• Magento version: 2.4.3-p2
• PHP version: 7.4

Magento ver. 2.2.3
postcode-magento2 version:1.1.3
OneStepCheckout : onestepcheckout/iosc (onestepcheckout.com)

At checkout, I'm getting above error mentioned in the title.

You can also check the image below.

Magento ver. 2.2.3
postcode-magento2 version:1.1.7

vendor/tig/postcode-magento2/Plugin/Address/Management/Shipping.php

    $attributes = $address->getExtensionAttributes();

In Above line it's return NULL and Billing.php working fine.

So in Billing address it saving house number properly in Street and in Shipping it's not.. So what could be wrong?

We experience our header appearing at the bottom of the checkout. I found that removing layout="checkout" from view/frontend/layout/checkout_index_index.xml fixes the issue. A module should not set the layout for an existing handle, in my opinion.

To Reproduce
This is probably template or custom work related.

Expected result
Header showing as normal

Workaround
Remove layout="checkout" from view/frontend/layout/checkout_index_index.xml

** Please complete the following information**

• Magento version: 2.3.5-p1

Is it compatible?

To Reproduce
Steps to reproduce the behavior:

1. Add product to cart and go to checkout
2. Use below address details.
3. Go to next step of checkout

Name: John Doe
Postcode: 1012JS
House number: 1
Country: The Netherlands
Phone: +31612345678

Expected result
I am expecting the template/layout on the last step of checkout to reflect what I filled in (there are 2 blocks with the address) So I would expect something like this:

John Doe
Dam 1
1012JS Amsterdam
Nederland
T: +31612345678

Actual result
John Doe
Dam 1 90
1012JS Amsterdam
Nederland
T: +31612345678
tig_housenumber
1
tig_housenumber_addition

tig_street
Dam

PS: Notice the extra '90' in the street field. This comes from an older address I filled in (I think).

Workaround
None (yet)

Screenshots

** Please complete the following information**

• Magento version: Magento 2.4.3-p2
• PHP version: 7.4

Are there any plans to make this compatible with PHP 8.0/8.1?

To Reproduce
Steps to reproduce the behavior:

1. Setup Magento 2.4.0/2.4.1/2.4.2 and install postcode-magento2
   postcode-magento2
2. Enable as much payment methods as possible
3. Try to order a product
4. Try to select a payment method

Expected result
Switching will go instant, like a stock Magento 2 shop.

Actual result
Switching is delayed. Every switch will cause you a few seconds with only 4 (internal) payment methods enabled. When you enable 10 payment methods (for example, you are using a PSP and are offering Paypal, Mastercard, etc), the wait time will grow exponentially. With 10 payment methods it will take you around 20 seconds to switch.

Workaround
None

Screenshots
Video:
https://user-images.githubusercontent.com/14849044/108263908-20c0ab80-7167-11eb-8251-19555dda5349.mov

** Please complete the following information**

• Mageto 2.4.2/2.4.1/2.4.0
• PHP version: using PHP 7.3

Lastest plugin version: 1.3.1
Magento 2.3.3

To Reproduce
We have not been able to reproduce the issue yet, still this issue is a pattern and happend since the latest update from version 1.2.x to 1.3.1

Expected result
Housenumber in both the shipping address section and billing address section.

Actual result
The shipping address has no house number in some cases.
The billing address has the housenumber, but somehow the shipping address is empty, only the street.

We thought maybe because it merged all on streetline 1, now we have the house number and addition on streetline 2 and still the issue occurs.

Workaround
None

Screenshots
If applicable, add screenshots to help explain your problem.

** Please complete the following information**

• Magento version: 2.3.3

I'm when running setup:upgrade i'm getting this message:

Unable to apply data patch TIG\Postcode\Setup\Patch\Data\AddTigEavAttributes for module TIG_Postcode. Original exception message: The attribute can't be saved.

I'm uising Magento 2.4.5 and extension version 1.5.1

To Reproduce
Steps to reproduce the behavior:

1. Update extension from 1.4.1 to 1.5.1 using composer
2. execute setup:upgrade

Expected result
The process finishes without any error messages

Actual result
The process finishes with the following error message:

Unable to apply data patch TIG\Postcode\Setup\Patch\Data\AddTigEavAttributes for module TIG_Postcode. Original exception message: The attribute can't be saved.

Workaround
None

Screenshots

** Please complete the following information**

• Magento version: Magento 2.4.5
• PHP version: 8.1

To Reproduce
Steps to reproduce the behavior:

1. Go to checkout
2. Fill in correct postcode and housenumber
3. TIG street field is automatically filled in. Example: 'Hoofdstraat'
4. TIG housenumber field is automatically filled in. Example: '8'
5. Click on TIG street field, if your browser has autofill/auto complete enabled, choose a option. Example 'hfdstraat'
6. TIG street field is changed
7. Street field is merged with old value and new value. After payment, the street field is something like: 'Hoofdstraat hfdstraat, 8 8'

Expected result
Or the autofill value is used (hfdstraat) or the autofill function is disabled on tig_street and tig_housenumber

Actual result
Both values are used and merged

Workaround
None, I'm wrting some JS for fixing this bug and other TIG bugs

• Magento version: [Magento 2.4.5]
• PHP version: [8.1]

The latest version of this module doesn't install on a fresh 2.3.6 installation.

composer require tig/postcode-magento2
Using version ^1.3 for tig/postcode-magento2
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for tig/postcode-magento2 ^1.3 -> satisfiable by tig/postcode-magento2[1.3.0].
    - Can only install one of: magento/module-checkout[100.4.0, 100.3.6].
    - Can only install one of: magento/module-checkout[100.4.0, 100.3.6].
    - Can only install one of: magento/module-checkout[100.4.0, 100.3.6].
    - Conclusion: install magento/module-checkout 100.4.0
    - Installation request for magento/module-checkout (locked at 100.3.6) -> satisfiable by magento/module-checkout[100.3.6].

To Reproduce
Steps to reproduce the behavior:

1. Install both modules on latest version
2. Enable Postcode Checkout for NL, disable Postcode check in PostNL module
3. Go to checkout and fill shipping address
4. Go to second step

Expected result
The billing address should display the data filled in from shipping address (assuming billing address = same)

Actual result
House number is displayed twice. (Postcode module combines street & number in street field, PostNL module adds template which adds a number field after it)

Workaround
I've overridden three templates from PostNL module to prevent this issue:
TIG_PostNL/web/template/billing-address/details.html
TIG_PostNL/web/template/shipping-address/address-renderer/default.html
TIG_PostNL/web/template/shipping-information/address-renderer/default.html

Screenshots
If applicable, add screenshots to help explain your problem.

** Please complete the following information**

• Magento version: 2.4.3-p2
• PHP version: PHP 7.4

To Reproduce
Steps to reproduce the behavior:

1. Make sure to have an account with an address with an housenumber addition field filled in.
2. Try to change change to an address from a client account (frontend) where the housenumber addition field in not used.

Expected result
A complete address where the housenumber addition field is not filled in.

Actual result
The housenumber field still shows the data before the edit (e.g. de data for this field is not changed on save)

Workaround
None (That I know of)

** Please complete the following information**

• Magento version: 2.4.3-p1
• PHP version: 7.4.8
• TIG Postcode extension version: 1.4.1

To Reproduce
Steps to reproduce the behavior:

1. Make sure you have an account with an address with a housenummer addition (3rd street field).
2. Make sure to edit the address from your customer account (frontend)

Expected result
All the right data in the right fields.

Actual result
The streetname fields gets populated by the housenumber

Workaround
Just change/edit the data.

Screenshots
See attachment

** Please complete the following information**

• Magento version: 2.4.3-p1
• PHP version: 7.4.8
• TIG Postcode extension version: 1.4.1

From update 1.1.11 you require magento/module-quote 101.0.5 or higher but magento 2.1.16 has 100.1.10

Magento 2.3.2
Theme: Magento/luma
tig/postcode-magento2: 1.2.4
Checkout usage: Two Step Checkout Luma
House number field: Street address line 1

On the shipping step fill address details via success postcode autocomplete and go to the payments step
the house number available in the shipping info

refresh the page and house number disappears from shipping address info

To Reproduce
Steps to reproduce the behavior:

1. Start new session, add something to cart
2. Go to checkout with Netherlands as default and Postcode Checkout for NL enabled

Expected result
While NL is selected as country, until postcode/house number are filled, street and city fields are hidden.

Actual result
Street field (tig_street) is shown, only city field is hidden

Workaround
I've created a patch for now, changing 'visible' to 'false' in Plugin/Model/ResourceModel/Country/CollectionPlugin.php

Screenshots
If applicable, add screenshots to help explain your problem.

** Please complete the following information**

• Magento version: 2.4.3-p2
• PHP version: PHP 7.4

Submitting issues through Github

Please follow the guide below

• Put an x into all the boxes [ ] relevant to your issue (like this: [x])
• Use the Preview tab to see what your issue will actually look like.
• We may ask some questions or ask you to provide addition information after you placed your request.

Make sure you are using the latest version: https://tig.nl/totale-aanbod-extensies/extensie-postcode-service/

Issues with outdated version will be rejected.

• I've verified and I assure that I'm running the latest version of the TIG Postcode Magento extension.

What is the purpose of your issue?

• Feature request (request for a new functionality)
• Bug report (encountered problems with the TIG Postcode Magento extension)
• Extension support request (request for adding support for a new extension)
• Other

If the purpose of your issue is a feature request

• As a merchant or developer I’d like to be able to update to Magento 2.3.1 with the Postcode extension installed in order to stay up-to-date with the latest Security patches.

TIG support

• Please ask your question in English to ensure that your issue can help other people internationally. Nevertheless we will respond in English.

To Reproduce
Steps to reproduce the behavior:

1. Sign in to a customer account
2. Go to the customer address book
3. Change an address in the address book, or create a new address
4. Fill in the form with an invalid postcode. For example, enter 2 digits in the postcode field.

Expected result
An error should display, stating that the entered postcode is invalid. The button to submit the form should be disabled. The customer should not be able to send the form and change their address.

Actual result
A warning is displayed when leaving the postcode field. When submitting the form an error is displayed, but the form is still being sent and the customer has changed their account to an account with an invalid address.

Workaround
None

** Please complete the following information**

• Magento version: Magento 2.4.2
• PHP version: 7.3.28

To Reproduce
Steps to reproduce the behavior:

1. Go to 'My account'
2. Try to add new address
3. It will fail with error displaying the address could not be saved
4. there is an error logged in system.log. See below.

System.log error

2021-10-25 13:54:34] main.CRITICAL: Exception message: Notice: Undefined offset: 0 in /data/web/magento2/vendor/tig/postcode-magento2/Services/Address/StreetFields.php on line 92
Trace: <pre>#1 TIG\Postcode\Services\Address\StreetFields->mergeTypeOne() called at [vendor/tig/postcode-magento2/Services/Address/StreetFields.php:65]
#2 TIG\Postcode\Services\Address\StreetFields->parse() called at [vendor/tig/postcode-magento2/Plugin/Address/Management/CustomerForm.php:82]
#3 TIG\Postcode\Plugin\Address\Management\CustomerForm->afterExtractData() called at [vendor/magento/framework/Interception/Interceptor.php:146]
#4 Magento\Customer\Model\Metadata\Form\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153]
#5 Magento\Customer\Model\Metadata\Form\Interceptor->___callPlugins() called at [generated/code/Magento/Customer/Model/Metadata/Form/Interceptor.php:68]
#6 Magento\Customer\Model\Metadata\Form\Interceptor->extractData() called at [vendor/magento/module-customer/Controller/Address/FormPost.php:124]
#7 Magento\Customer\Controller\Address\FormPost->_extractAddress() called at [vendor/magento/module-customer/Controller/Address/FormPost.php:223]
#8 Magento\Customer\Controller\Address\FormPost->execute() called at [vendor/magento/framework/Interception/Interceptor.php:58]
#9 Magento\Customer\Controller\Address\FormPost\Interceptor->___callParent() called at [vendor/magento/framework/Interception/Interceptor.php:138]
#10 Magento\Customer\Controller\Address\FormPost\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153]
#11 Magento\Customer\Controller\Address\FormPost\Interceptor->___callPlugins() called at [generated/code/Magento/Customer/Controller/Address/FormPost/Interceptor.php:23]
#12 Magento\Customer\Controller\Address\FormPost\Interceptor->execute() called at [vendor/magento/framework/App/Action/Action.php:111]
#13 Magento\Framework\App\Action\Action->dispatch() called at [vendor/magento/module-customer/Controller/Address.php:128]
#14 Magento\Customer\Controller\Address->dispatch() called at [vendor/magento/framework/Interception/Interceptor.php:58]
#15 Magento\Customer\Controller\Address\FormPost\Interceptor->___callParent() called at [vendor/magento/framework/Interception/Interceptor.php:138]
#16 Magento\Customer\Controller\Address\FormPost\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/anowave/ec/Plugin/App/Action/Context.php:148]
#17 Anowave\Ec\Plugin\App\Action\Context->aroundDispatch() called at [vendor/magento/framework/Interception/Interceptor.php:135]
#18 Magento\Customer\Controller\Address\FormPost\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153]
#19 Magento\Customer\Controller\Address\FormPost\Interceptor->___callPlugins() called at [generated/code/Magento/Customer/Controller/Address/FormPost/Interceptor.php:32]
#20 Magento\Customer\Controller\Address\FormPost\Interceptor->dispatch() called at [vendor/magento/framework/App/FrontController.php:245]
#21 Magento\Framework\App\FrontController->getActionResponse() called at [vendor/magento/framework/App/FrontController.php:212]
#22 Magento\Framework\App\FrontController->processRequest() called at [vendor/magento/framework/App/FrontController.php:147]
#23 Magento\Framework\App\FrontController->dispatch() called at [vendor/magento/framework/Interception/Interceptor.php:58]
#24 Magento\Framework\App\FrontController\Interceptor->___callParent() called at [vendor/magento/framework/Interception/Interceptor.php:138]
#25 Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/module-store/App/FrontController/Plugin/RequestPreprocessor.php:99]
#26 Magento\Store\App\FrontController\Plugin\RequestPreprocessor->aroundDispatch() called at [vendor/magento/framework/Interception/Interceptor.php:135]
#27 Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/module-page-cache/Model/App/FrontController/BuiltinPlugin.php:75]
#28 Magento\PageCache\Model\App\FrontController\BuiltinPlugin->aroundDispatch() called at [vendor/magento/framework/Interception/Interceptor.php:135]
#29 Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153]
#30 Magento\Framework\App\FrontController\Interceptor->___callPlugins() called at [generated/code/Magento/Framework/App/FrontController/Interceptor.php:23]
#31 Magento\Framework\App\FrontController\Interceptor->dispatch() called at [vendor/magento/framework/App/Http.php:116]
#32 Magento\Framework\App\Http->launch() called at [vendor/magento/framework/App/Bootstrap.php:264]
#33 Magento\Framework\App\Bootstrap->run() called at [pub/index.php:29]

My debug info
It fails because of abscense of index 0. I dumped the input of that function, it looks like this:

array(3) {
[1]=> string(10) "Stationsstraat"
[2]=> string(0) ""
[3]=> string(0) ""
}

Expected result
The address being added to the address book.

Actual result
No change in address book. the address is not saved.

Workaround
None

** Please complete the following information**

• Magento version: 2.4.3-p1
• PHP version: 7.4.8
• TIG Postcode version: 1.4.0

To Reproduce
Steps to reproduce the behavior:

1. Add a discount coupon code from the admin
2. Try to use the coupon code in the checkout in frontend (not from the cart)
3. The spinner keeps spinning without a result

Expected result
I expect the coupon code to be applied.

Actual result
Loader spinner just keeps spinning.

Workaround
None (that I know of). Only way to make the coupon field working is to disable tig postcode extension

Screenshots

• Magento version: Magento 2.4.3-p1
• PHP version: 7.4.8
• tig/postcode-magento2: 1.4.0

The StreetFields service create the street field based on set configuration. The customer account implementation does not use this service and always returns a three item array in CustomerForm. We use the setting to store the address in one line so the form on customer/address/edit/id/1 returns an error "Adres" mag niet meer dan 1 regels bevatten..