Im using ksp 1.8

While flying ships powered by solar panels with this mod installed, the electric charge will randomly get stuck to max and will not deplete even when transmitting data. this happens even if the ship is behind a planet. it changes between stuck and normal while time warping long distances. just entering warp for a moment doesnt cause it to change. It also doesnt happen on nuclear ships though kerbal atomics has its own problems.

Also the solar planner in the VAB does not display solar power correctly. In one case it was saying it should be 150% but it actually was 300%. It also does not take into account other stars.

In flight the menu that lists production and consumption does show the correct numbers for nft propulsion engine, but much lower ones, even though the engines themselves are consuming the correct amount and the VAB planner does show the correct values

Also what would happen if i removed this mod? would the nft mods break?

Hello, I was told to share this issue and I hope I´m in the right place.
An exception is thrown when loading the game, I have a lot of mods and am not a mod maker so I can´t tell you much more, DBS doesn´t work in-game. Here are my mod list and my KSP.log so you can orient yourself:

KSP.log

Moved to issue from #39 .

Is there supposed to be a settings file available? I keep getting this in the KSP.log:

[LOG 15:22:39.208] [Dynamic Battery Storage]: Settings: Started loading
[LOG 15:22:39.208] [Dynamic Battery Storage]: Settings: Couldn't find settings file, using defaults
[LOG 15:22:39.209] [Dynamic Battery Storage]: Settings: Finished loading

Hi Chris,

I'd like to add support for my RealBattery mod. IMHO there are 2 things to do:

• Overthink your algorithm at RefreshVesselElectricalData Don't assume if its a producer it can't be a consumer as well. Why? My batteries are dynamically switching from being a consumer (thats when the battery is charging up) to being a producer (discharging the battery gives EC to the resource pool)
• extend PowerConsumer and PowerProducer

PR #4

This issue is mirrored from shadowmage45/SSTULabs#814 .

Environment

Latest version of KSP (1.7.3)

Mods:

• SSTU Labs (and all its dependencies)
• Any mod with dependency Dynamic Battery Storage (e.g. Near Future Solar)

Steps to recreate

1. Launch KSP with mods showed above;
2. In any save game, build a vessel with battery storage and any SSTU container;
3. See the log spam in console

^ Example vessel

I suppose it's caused by DynamicBatteryStorage not supporting SSTU's boiloff power usage system.

Getting this exception thrown constantly while burning the Z-Pinch Fusion Engine from another of your mods. Note that the number included in ##### gradually grows as the engine burns.

Light is an item (0.06 EC/s) in the Power Comsumption, but it is summed into the Power Generation

JNSQ Moho showed as 11Gm, that is not mean, since Moho Pe: 11Gm, Ap: 17Gm.

Also in the GUI it is a slider, so it is difficult to set, for example, 17Gm

Need to make this mod turn itself off when Kerbalism is installed in order to not confuse users.

As Kopernicus changes the ModuleDeployableSolarPanel to KopernicusSolarPanels, that makes all solar panels hidden in the Systems Manager UI. Within DynamicBatteryStorageSettings.cfg, you have a KopernicusSolarPanel in Handlercategory which doesn't catch the name of the current module, but adding module = KopernicusSolarPanels as well as the related partmodulehandler appears to fix the issue.

I'm seeing the same exception constantly in the logs; it's causing performance issues and attached electric engines don't work.

[EXC 15:52:57.850] InvalidOperationException: Operation is not valid due to the current state of the object
	System.Linq.Enumerable.Single[ConfigNode] (IEnumerable`1 source, System.Func`2 predicate, Fallback fallback)
	System.Linq.Enumerable.Single[ConfigNode] (IEnumerable`1 source, System.Func`2 predicate)
	DynamicBatteryStorage.ModuleCryoTankPowerHandler.GetFuelTypes ()
	DynamicBatteryStorage.ModuleCryoTankPowerHandler.Initialize (.PartModule pm)
	DynamicBatteryStorage.VesselElectricalData.SetupDataHandler (.PartModule pm)
	DynamicBatteryStorage.VesselData.RefreshData (Boolean fromScratch, System.Collections.Generic.List`1 vesselParts)
	DynamicBatteryStorage.VesselData..ctor (System.Collections.Generic.List`1 vesselParts)
	DynamicBatteryStorage.VesselElectricalData..ctor (System.Collections.Generic.List`1 vesselParts)
	DynamicBatteryStorage.VesselDataManager.RefreshVesselData ()
	DynamicBatteryStorage.VesselDataManager.FixedUpdate ()

mod list:

{
	"kind": "metapackage",
	"abstract": "A list of modules installed on the auto KSP instance",
	"name": "installed-auto",
	"license": "unknown",
	"version": "2019.08.25.11.17.50",
	"identifier": "installed-auto",
	"spec_version": "v1.6",
	"recommends": [
		{
			"name": "MechJeb2"
		},
		{
			"name": "NearFutureConstruction"
		},
		{
			"name": "NearFuturePropulsion-XenonHETs"
		},
		{
			"name": "DistantObject-default"
		},
		{
			"name": "KerbalJointReinforcementNext"
		},
		{
			"name": "NearFutureLaunchVehicles"
		},
		{
			"name": "NearFuturePropulsion"
		},
		{
			"name": "NearFutureSolar"
		},
		{
			"name": "NearFutureSpacecraft"
		},
		{
			"name": "NearFutureSpacecraft-OrbitalLFOEngines"
		},
		{
			"name": "CommunityTechTree"
		},
		{
			"name": "StationPartsExpansionRedux"
		},
		{
			"name": "NearFutureElectrical"
		},
		{
			"name": "KerbalAtomics-NTRModSupport"
		},
		{
			"name": "B9PartSwitch"
		},
		{
			"name": "ModuleManager"
		},
		{
			"name": "CommunityResourcePack"
		},
		{
			"name": "KerbalAtomics"
		},
		{
			"name": "NearFutureSolar-Core"
		},
		{
			"name": "NearFutureProps"
		},
		{
			"name": "CryoTanks-Core"
		},
		{
			"name": "CryoTanks"
		},
		{
			"name": "KerbalAtomics-NFECompatibility"
		},
		{
			"name": "KerbalPlanetaryBaseSystems"
		},
		{
			"name": "CommunityCategoryKit"
		},
		{
			"name": "Chatterer"
		},
		{
			"name": "DMagicOrbitalScience"
		},
		{
			"name": "EnvironmentalVisualEnhancements"
		},
		{
			"name": "EnvironmentalVisualEnhancements-HR"
		},
		{
			"name": "KAS"
		},
		{
			"name": "KIS"
		},
		{
			"name": "NehemiahEngineeringOrbitalScience"
		},
		{
			"name": "ProceduralFairings"
		},
		{
			"name": "SCANsat"
		},
		{
			"name": "EasyVesselSwitch"
		},
		{
			"name": "K2CommandPodCont"
		},
		{
			"name": "ContractConfigurator"
		},
		{
			"name": "ScienceAlert"
		},
		{
			"name": "ProceduralFairings-ForEverything"
		},
		{
			"name": "ClickThroughBlocker"
		},
		{
			"name": "ToolbarController"
		},
		{
			"name": "FASA"
		},
		{
			"name": "HideEmptyTechNodes"
		},
		{
			"name": "IndicatorLights"
		},
		{
			"name": "InterstellarFuelSwitch"
		},
		{
			"name": "InterstellarFuelSwitch-Core"
		},
		{
			"name": "CryoEngines"
		},
		{
			"name": "NovaPunchRebalanced"
		},
		{
			"name": "ReStock"
		},
		{
			"name": "Science-Full-Reward"
		},
		{
			"name": "TACLS"
		},
		{
			"name": "KSPInterstellarExtended"
		},
		{
			"name": "PatchManager"
		},
		{
			"name": "TweakScale"
		},
		{
			"name": "NovaPunchRebalanced-Freyja"
		},
		{
			"name": "NovaPunchRebalanced-Odin"
		},
		{
			"name": "NovaPunchRebalanced-Thor"
		},
		{
			"name": "ReStockPlus"
		},
		{
			"name": "xScienceContinued"
		},
		{
			"name": "Science-Full-Transmit"
		},
		{
			"name": "ContractConfigurator-FieldResearch"
		},
		{
			"name": "BackgroundResources"
		},
		{
			"name": "DistantObject"
		},
		{
			"name": "DynamicBatteryStorage"
		},
		{
			"name": "DeployableEngines"
		},
		{
			"name": "NearFutureElectrical-Core"
		}
	]
}

Reproduce by creating a stack

probe core
fuel tank (full of enriched uranium)
reactor
fuel tank (empty, set to depleted uranium)
cryo tank (fill with argon)
hall effect engine

it shouldn't matter, but I also had a ton of sensors etc on it but I think the above replicates it.

Can provide screenshots if you have issues replicating.

Launching, reverting back to the VAB, and removing a part from the vessel triggers an exception in DynamicBatteryStorage version 2.0.1:

[ERR 22:14:49.616] Exception handling event onPartRemove in class EditorVesselDataManager:System.NullReferenceException: Object reference not set to an instance of an object
  at DynamicBatteryStorage.EditorVesselDataManager.RemovePart (.Part p) [0x00000] in <filename unknown>:0 
  at DynamicBatteryStorage.EditorVesselDataManager.onEditorVesselPartRemoved (HostTargetAction`2 p) [0x00000] in <filename unknown>:0 
  at EventData`1[GameEvents+HostTargetAction`2[Part,Part]].Fire (HostTargetAction`2 data) [0x00000] in <filename unknown>:0 

[EXC 22:14:49.804] NullReferenceException: Object reference not set to an instance of an object
        DynamicBatteryStorage.EditorVesselDataManager.RemovePart (.Part p)
        DynamicBatteryStorage.EditorVesselDataManager.onEditorVesselPartRemoved (HostTargetAction`2 p)
        EventData`1[GameEvents+HostTargetAction`2[Part,Part]].Fire (HostTargetAction`2 data)
        UnityEngine.Debug:LogException(Exception)
        EventData`1:Fire(HostTargetAction`2)
        Part:setParent(Part)
        EditorLogic:detachPart(Part)
        EditorLogic:<SetupFSM>m__1F()
        KerbalFSM:RunEvent(KFSMEvent)
        KerbalFSM:updateFSM(KFSMUpdateMode)
        KerbalFSM:UpdateFSM()
        EditorLogic:Update()

I've reproduced this in a new sandbox save in KSP 1.7.3 (on Linux, though I doubt that matters) with no mods besides DynamicBatteryStorage. Test vessel was a Stayputnik, FL-T200 fuel tank, and Terrier engine, with a launch clamp attached to the fuel tank. After going to the launchpad and then doing "revert to vehicle assembly", removing the engine triggered the exception above.

KSP mods should have v3.5 here:

https://github.com/ChrisAdderley/DynamicBatteryStorage/blob/b840e9939367bbdb7d6238bbdc2eef844420b95d/Source/DynamicBatteryStorage/DynamicBatteryStorage.csproj#L13

Originally reported by forum user Tonka Crash at:

https://forum.kerbalspaceprogram.com/index.php?/topic/183869-mods-with-wrong-net-target-framework/

I have a lot of mods, I think Kerbalism is the prime suspect. So everything works great until I slap on the antenna when it slows down. It's not game breaking but it is annoying, I love stocking up on the comms. IF I delete the antenna, then the NRE immediately stops and the lag ends, its back to normal.

Here's the relevant part of the logs, lmk if you need more. I'm going to take a look at the code myself maybe this weekend.

[EXC 23:14:49.585] NullReferenceException: Object reference not set to an instance of an object
DynamicBatteryStorage.GenericFieldDataHandler.GetValueEditor ()
DynamicBatteryStorage.ModuleDataHandler.GetValue ()
DynamicBatteryStorage.VesselData.get_CurrentConsumption ()
DynamicBatteryStorage.UI.UIElectricalView.UpdateHeaderPanelData ()
DynamicBatteryStorage.UI.UIElectricalView.Update ()
DynamicBatteryStorage.UI.DynamicBatteryStorageUI.Update ()
[EXC 23:14:50.069] NullReferenceException: Object reference not set to an instance of an object
DynamicBatteryStorage.GenericFieldDataHandler.GetValueEditor ()
DynamicBatteryStorage.ModuleDataHandler.GetValue ()
DynamicBatteryStorage.VesselData.get_CurrentConsumption ()
DynamicBatteryStorage.UI.UIElectricalView.UpdateHeaderPanelData ()
DynamicBatteryStorage.UI.UIElectricalView.Update ()
DynamicBatteryStorage.UI.DynamicBatteryStorageUI.Update ()
[EXC 23:14:50.707] NullReferenceException: Object reference not set to an instance of an object
DynamicBatteryStorage.GenericFieldDataHandler.GetValueEditor ()
DynamicBatteryStorage.ModuleDataHandler.GetValue ()
DynamicBatteryStorage.VesselData.get_CurrentConsumption ()
DynamicBatteryStorage.UI.UIElectricalView.UpdateHeaderPanelData ()
DynamicBatteryStorage.UI.UIElectricalView.Update ()
DynamicBatteryStorage.UI.DynamicBatteryStorageUI.Update ()
[EXC 23:14:51.116] NullReferenceException: Object reference not set to an instance of an object
DynamicBatteryStorage.GenericFieldDataHandler.GetValueEditor ()
DynamicBatteryStorage.ModuleDataHandler.GetValue ()
DynamicBatteryStorage.VesselData.get_CurrentConsumption ()
DynamicBatteryStorage.UI.UIElectricalView.UpdateHeaderPanelData ()
DynamicBatteryStorage.UI.UIElectricalView.Update ()
DynamicBatteryStorage.UI.DynamicBatteryStorageUI.Update ()

Currently the mod is wildly inaccurate in calculating ec usage by data transmitters (reads 9.3 ec/s when it should be 0.02 ec/s) probably b/c kerbalism changes how science transmission works.

Hi Nertea, been testing the refactor and I'll post any feedback or issues I have here.

1. In the VAB planner I found that if I check a part that is disabled by default such as an engine or transmitter, it becomes unchecked as soon as a change is made to the craft. It could be a bit tedious having to re-enable say a cluster of ion engines everytime you add a battery or change capacitor discharge rate or whatever.

2. If possible, I think adding support for life support EC consumption for the popular life support mods (TAC, USI, Snacks, Kerbalism) could be nice. Perhaps its not as easy as it sounds? With Amp Year and TAC, the module life support shows up in the amp year planner at least, but without a value.

3. Looks like capacitors have the opposite problem to no.1, they are always automatically checked when a change is made.

4. Capacitors appear under batteries in the consuption side of the UI. However it seems to contribute just fine as a power source in the calculations.

This UI is v v cool btw :) Far easier than amp year.

Hi

I'm getting more and more frustrated with this mod letting clicks through the windows, causing my ships to lose parts or misplacing them. Sometimes it's just an annoyance, most times it causes me having to redo half of the ship.

Why not add ClickThroughBlocker functionality to it? From what I read it's not too complicated a procedure.

https://www.dropbox.com/s/q895hs6j3ipu23f/20191111-210709.809.mp4?dl=0

• Mean Solar Altitude - are showed values 1000 times smaller?
  100% efficiency at 13Mm from the Sun
• Body Orbital Height - from 1km right away to 1Mm, can't be set to 100km, 200km, 500km.

Would you consider adding an option for scaling the window size? I find the text to be right on the edge of what I can manage to read, a little bigger would be a huge help to me and others that have vision issues.

Hi.

I see there is SSTUPowerHandlers in repository. Although it isn't added to project. Does it mean that SSTU solar panels aren't supported?

Thank you in advance for reply.

Hi Chris,

one of those 2 lines is throwing NRE's if there are no consumers:

https://github.com/ChrisAdderley/DynamicBatteryStorage/blob/master/Source/DynamicBatteryStorage/DynamicBatteryStorageUI.cs#L158-L159

Errors from KSP.log:

NullReferenceException: Object reference not set to an instance of an object
at DynamicBatteryStorage.DynamicBatteryStorageUI.PowerWindow (Int32 windowId) [0x00000] in :0
at UnityEngine.GUI.CallWindowDelegate (UnityEngine.WindowFunction func, Int32 id, UnityEngine.GUISkin _skin, Int32 forceRect, Single width, Single height, UnityEngine.GUIStyle style) [0x00000] in :0

(Filename: Line: -1)

GUI Error: You are pushing more GUIClips than you are popping. Make sure they are balanced)

(Filename: Line: 422)

Reproduce:

• Launch a new vessel with only one part (any probecore will do)
• open GUI (CTRL + SHIFT + k)
• warp >= 100

Details see here:
https://forum.kerbalspaceprogram.com/index.php?/topic/186207-112x-dynamic-battery-storage-electricalthermal-planning-and-timewarp-compensation-july-21/page/8/&tab=comments#comment-3996348

KSP Version 1.7.3 Both DLC's
Dynamic Battery Storage version 2.02.0 (installed via CKAN)

Logs
ArgumentNullException: Argument cannot be null. Parameter name: type at System.Activator.CheckType (System.Type type) [0x00000] in <filename unknown>:0 at System.Activator.CreateInstance (System.Type type, BindingFlags bindingAttr, System.Reflection.Binder binder, System.Object[] args, System.Globalization.CultureInfo culture, System.Object[] activationAttributes) [0x00000] in <filename unknown>:0 at System.Activator.CreateInstance (System.Type type, System.Object[] args, System.Object[] activationAttributes) [0x00000] in <filename unknown>:0 at System.Activator.CreateInstance (System.Type type, System.Object[] args) [0x00000] in <filename unknown>:0 at DynamicBatteryStorage.VesselElectricalData.SetupDataHandler (.PartModule pm) [0x00000] in <filename unknown>:0 at DynamicBatteryStorage.VesselData.RefreshData (Boolean fromScratch, System.Collections.Generic.List1 vesselParts) [0x00000] in :0
at DynamicBatteryStorage.VesselData..ctor (System.Collections.Generic.List1 vesselParts) [0x00000] in <filename unknown>:0 at DynamicBatteryStorage.VesselElectricalData..ctor (System.Collections.Generic.List1 vesselParts) [0x00000] in :0
at DynamicBatteryStorage.VesselDataManager.RefreshVesselData () [0x00000] in :0
at DynamicBatteryStorage.VesselDataManager.FixedUpdate () [0x00000] in :0 `

is spamming about every second

also Dynamic Batter Storage Offline

See post-kerbin-mining-corporation/NearFutureElectrical#121.

It should basically be a re-name of the ModuleActiveRadiator handler.

For reference;

• https://github.com/UmbraSpaceIndustries/MKS/blob/master/FOR_RELEASE/GameData/UmbraSpaceIndustries/MKS/Parts/Ranger_HeatPump.cfg
• https://github.com/UmbraSpaceIndustries/UmbraSpaceIndustries/blob/DEVELOP/USITools/USITools/ModuleHeatPump.cs

Could an enhancement be added to the planner to toggle between the current orbital options, to a landed at surface mode? Then just have a flat calculation for how long the night time is on the selected body.

Add support for life support mods, specifically

• Snacks
• USI-LS (if possible)
• TAC (if possible

Would it be possible for this mod to work with TAC life support mod, because I have the issue of running out of electricity when time warping which results in my kerbals dying. The mod works great with other means of power consumption though(TAC life support drains electric charge per kerbal just to keep them alive). If it wouldn't be possible does anyone know of an alternate solution to this.

the module "KopernicusSolarPanel" is going to be overhauled completely in the next kopernicus release and it will no longer replace the stock SolarPanel modules

The module itself will also be renamed to "KopernicusSolarPanels" which will trigger some NRE for mods that refer to "KopernicusSolarPanel"

I am torn between keeping an empty "KopernicusSolarPanel" module to avoid breaking mods that might refer to it, but at the same time if the issues don't show up people will not know that they need to change their mods.

I noticed that this mod refers to "KopernicusSolarPanel" so if you need help with switching to the new ones just let me know

Relates to #48 and #53

Hi Chris,

• System: Windows 10 x64
• KSP: v1.7.3
• Dynamic Battery Storage: v2.0.5.0

I keep getting this exception:

[EXC 15:20:03.505] InvalidOperationException: Operation is not valid due to the current state of the object
	System.Linq.Enumerable.Single[ConfigNode] (IEnumerable`1 source, System.Func`2 predicate, Fallback fallback)
	System.Linq.Enumerable.Single[ConfigNode] (IEnumerable`1 source, System.Func`2 predicate)
	DynamicBatteryStorage.ModuleCryoTankPowerHandler.GetFuelTypes ()
	DynamicBatteryStorage.ModuleCryoTankPowerHandler.Initialize (.PartModule pm)
	DynamicBatteryStorage.VesselElectricalData.SetupDataHandler (.PartModule pm)
	DynamicBatteryStorage.VesselData.RefreshData (Boolean fromScratch, System.Collections.Generic.List`1 vesselParts)
	DynamicBatteryStorage.VesselData..ctor (System.Collections.Generic.List`1 vesselParts)
	DynamicBatteryStorage.VesselElectricalData..ctor (System.Collections.Generic.List`1 vesselParts)
	DynamicBatteryStorage.VesselDataManager.RefreshVesselData ()
	DynamicBatteryStorage.VesselDataManager.FixedUpdate ()

https://github.com/ChrisAdderley/DynamicBatteryStorage/blob/63f8a4aecf14ba5e11e9dd88805f64db28fe6dcb/Source/DynamicBatteryStorage/Handlers/Power/NFTPowerHandlers.cs#L103-L111

As far as I can tell Single raises an InvalidOperationException on the following conditions:

• No element satisfies the condition in predicate.
• More than one element satisfies the condition in predicate.
• The source sequence is empty.

I can't tell exactly which one of the above conditions happens here.

Please tell me if you need more information.

Thanks a lot!

Log file (2.8 MB; warning 768 MB when decompressed):
KSP.zip

First occurrence at line 51593.

I was thinking that it could be a potential QoL improvement if the Celestial Body selector button in the electrical panel could increment ++ with a left click and -- with a right click so that you don't have to cycle all the way through all the bodies if you accidentally pass the one you need.