poolski / puppet-beats Goto Github PK

HI,

We control our apt repos local and don't use the public ones. Could you add a "manage_repo" override so we could skip the public repo?

Greetings,

I am a security researcher, who is looking for security smells in Puppet scripts. I noticed instances of empty passwords. Empty passwords increase the guessability of passwords. The Common Weakness Organization (CWE) identifies use of empty passwords as a security weakness (https://cwe.mitre.org/data/definitions/258.html).

I suggest that to follow the strong password guidelines, and manage passwords with hiera.

Any feedback is appreciated.

Source: https://github.com/poolski/puppet-beats/blob/master/manifests/outputs/elasticsearch.pp

Hi @poolski ,

Thanks for the module. I've added a pull request to add a couple of configuration attributes

• The first one is to decouple the 'load' and the 'processes' monitoring. In some of my machines, I wanted to have only the fist one.
• The second one is to pass extra configuration to the metricbeat. I'm using this to pass the 'filesystem.ignore_types' (see [1]). I thought it would be better to create a generic parameter than to call it filesystem filter, which would help only for this particular use case.

Could you please take a look at it?

Thanks,
pablo

[1] https://www.elastic.co/guide/en/beats/metricbeat/5.6/metricbeat-metricset-system-filesystem.html#_filtering

Hi,

I will soon create a new branch, where I have moved away from file concat based on erb template. The new module will be based on Puppet Hashes, merge them together and then I'm reusing this template to make a structured and sorted yaml representation out of the hash.

I will keep the same structure in the module, but I'm just not a big fan of file concatenation and erb templating. Hope you will give it a go when it's ready