polyccon / crumbs Goto Github PK

Good test coverage on server-side

use build script to add dummy data to database

Make at least one database test

We need to create a getdata.js with the right sorting in the query.

We need to create a server.js file.

Create pages for

• Browsing (index.html)
• Adding biscuit (add-biscuit.html)
• viewing details of a single biscuit (biscuit-detail.html)
• Adding feedback (review and rating)

Which inserts new rows into database tables.

See example:
https://github.com/foundersandcoders/pg-workshop/blob/master/solutions/src/queries/postData.js

handler.js should deal with endpoints:
(not sure if this all makes sense, feel free to modify!)

• '/' display - handler.home - home page with (4?) biscuits in order of most recently added
• '/add-biscuit' - handler.addBiscuit (shows form)
• '/new-biscuit' - handler.newBiscuit (deals with form data submitted from /add-biscuit)
• '/filter-biscuits' - handler.filterBiscuits - (will have querystring which determines our sql query - use url module to parse) parses querystring (using url module) and queries database, sends results in response to be inserted into dom (to be displayed on index.html)
• '/biscuit-detail' - handler.biscuitDetail - (might have querystring indicating which biscuit to display??) (queries db for biscuit id and displays info using dom manipulation (into biscuit-detail.html)

• '/add-feedback' - handler.addFeedback - (might have querystring indicating which biscuit feedback relates to???) p
• '/new-feedback' - handler.newFeedback - (receives submitted data and uses postData.js to insert data into database)

We need the redirect the add biscuit page to the biscuit browser page after the user has submitted data

After tests have run, you need to press CTRL + C to terminate them.
(possibly to do with pool/connection/timeout...??)

Remove these for consistency :)

In this file https://github.com/polyccon/Crumbs/blob/master/src/handler.js#L9-L16

You are defining the extensions, but what happens if you add png files, then add svg files to serve. You will constantly be adding to this list.

Have you thought about an alternative?

You could just split the url to get the ext.

var ext = url.split('.')[1];
// this will give you the extension as long as you have the url. which you can get from the request. 

Good test coverage on the client-side

As we all know naming is hard but is probably the most important part of this process.

You have split out your routes and handlers in different files, which would be fine if your naming was consistent across both the files.
https://github.com/polyccon/Crumbs/blob/master/src/router.js#L7 the route is /get but the actual handler is called queryGetData try to keep some consistency in the naming, never assume that because you have this line

'/get': handlers.queryGetData,

that users will know exactly the method to look for in the handler and vice-versa.

Be more specific. What type of data are you getting? https://github.com/polyccon/Crumbs/blob/master/src/queries/getData.js#L2 it looks like biscuits, then call the endpoint biscuits and then your method get-biscuits.

Create the form submission request called by the submit button on the add biscuit page. Talks to the new_biscuit endpoint on the server

ie db_build.sql

travis builds will fail unless we set up our database on travis

It would be great if you could add input validation to avoid script injection.

Sorry for breaking your site... and for my bad spelling 😨

when we test that we can insert into the database, our 'select' query must be inside the callback passed into the 'insert' query (or the selection may finish before the insertion)

https://github.com/polyccon/Crumbs/blob/master/test/database.test.js#L58

OR use returning: https://www.postgresql.org/docs/9.5/static/dml-returning.html

router.js should have endpoints:

• '/'
• '/add-biscuit' (shows form)
• '/new-biscuit' (deals with form data submitted from /add-biscuit)
• '/filter-biscuits' (will have querystring which determines our sql query - use url module to parse)
• '/biscuit-detail' (will have querystring indicating which biscuit to display??)

• '/add-feedback' (might have querystring indicating which biscuit feedback relates to???)
• '/new-feedback'