Code Monkey home page Code Monkey logo

ios-sdk-pollfish's People

Contributors

fotism23 avatar kaspanvo avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ios-sdk-pollfish's Issues

The API is not view controller friendly

Hi,
i'm using pollfish in one of my apps and and creating this issue because the API is not very view-controller friendly. In my 2cents opinion, developers should be able to present the survey, if available, from any view controller with a simple method, such as:

Pollfish.showFromViewController(viewController: UIViewController) throws

which may throw when the survey is not available.
Moreover, the red 'pollfish' badge should be optional and you should allow developers to choose whether they want that badge or simply present the survey in a more iOS friendly way. I know that it is possible to call Pollfish.initWithPosition(...) and then hide(), but this is very nice because the survey will stick to the current view controller.
Last thing: if the current view controller is smaller than the screen (like an alert dialog), the survey will be smaller as well.

Hope it helps.
/Andrea

Undefined symbols for architecture arm64

"OBJC_CLASS$_PollfishParams", referenced from:
objc-class-ref in myLib.a(MyController.o)
(maybe you meant: OBJC_CLASS$_PollfishParamsObj)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

UI APIs called from background threads

FYI in the latest version of your SDK (available via Cocoapods) - 4.3.5 - Xcode 9 reports at least two cases of UIView methods being called in background threads.

screen shot 2018-03-28 at 11 16 36

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.