pokey / command-server Goto Github PK

Hello,

Very often when running Windows inside a virtual box virtual machine and using Cursorless I get the above issue. It seems to come and go at random. I cannot pin down the reason why it's happening. When it happens, using the take command until it works makes it resolve. I'm wondering if it is a weird time stamping issue.

If there are multiple vscode instances running, only one of them will accept commands. Commands intended for the others will go to whichever one opened first, I believe.

In order to make it easier for people to use Talon for development, we'd like to support the command server when VSCode is running in a web browser. The approach is roughly as follows:

• Leverage Rango's RPC to inject a payload into the window object
• Inject a function onto the window object that the command server can use to send a response payload. Could possibly leverage some code Rango used to have for modifying the window object. See also this SO post
• Issue a keypress from Talon to tell the command server to read from the window object
• Read from the window object in the command server extension and run the command like usual
• Send the response back via the injected callback

MINGW64 /c/command-server_fork (main)
$ pnpm install
 WARN  deprecated [email protected]: This package has been renamed to @vscode/test-electron, please update to the new name
Downloading registry.npmjs.org/typescript/4.9.5: 11.62 MB/11.62 MB, done
Packages: +231
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 232, reused 169, downloaded 62, added 231, done

dependencies:
+ minimatch 3.1.2 (9.0.3 is available)
+ rimraf 3.0.2 (5.0.5 is available)

devDependencies:
+ @types/glob 7.2.0 (8.1.0 is available)
+ @types/mocha 8.2.3 (10.0.6 is available)
+ @types/node 15.14.9 (20.11.25 is available)
+ @types/rimraf 3.0.2 (4.0.5 is available)
+ @types/vscode 1.87.0
+ @typescript-eslint/eslint-plugin 4.33.0 (7.1.1 is available)
+ @typescript-eslint/parser 4.33.0 (7.1.1 is available)
+ eslint 7.32.0 (8.57.0 is available)
+ glob 7.2.3 (10.3.10 is available)
+ mocha 8.4.0 (10.3.0 is available)
+ typescript 4.9.5 (5.4.2 is available)
+ vscode-test 1.6.1 deprecated

MINGW64 /c/command-server_fork (main)
$ pnpm compile

> [email protected] compile C:\command-server_fork
> tsc -p ./

src/commandRunner.ts:1:27 - error TS7016: Could not find a declaration file for module 'minimatch'. 'C:/command-server_fork/node_modules/.pnpm/[email protected]/node_modules/minimatch/minimatch.js' implicitly has an 'any' type.
  If the 'minimatch' package actually exposes this module, consider sending a pull request to amend 'https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/minimatch'

1 import { Minimatch } from "minimatch";
                            ~~~~~~~~~~~


Found 1 error in src/commandRunner.ts:1

 ELIFECYCLE  Command failed with exit code 2.

this is building from Windows.

NOTE: this is not blocking me because I don't need the code using minimatch.

Whenever the built in terminal of VS Code has focus, commands issued using user.vscode are no longer working. Instead you get a time out in talon log.

For example:

1. Open a VS Code window and focus the built in terminal.
2. Say please
3. Nothing happens, except the following error showing up in talon log:

talon.scripting.talon_script.TalonScriptError: 
 in script at /home/simon/.talon/user/knausj_talon/apps/vscode/vscode.talon:16:
 > user.vscode('workbench.action.showCommands')
Exception: Timed out waiting for response

I am on

• Ubuntu 20.04
• talon beta v0.3.1-41-g7516 (41)
• knausj_talon 644d330be80bddfe7bfc314a15903185b3111cf7
• VS Code 1.72.2
• Command Server Plugin v0.8.2

Maybe this is a Linux thing, but I have no idea why focusing the terminal would stop command server from reading files...

Hello, dear Pokey,

command-server is a really great extension, but , sounds like that it can not run inside codespace of github.

Do you have any idea about how to running it inside of codespace(almost a web ide)?

Thank you for you great job!

Have a nice day.

• Switch to ctrl/cmd-shift-f11
• Add settings to avoid terminal stealing keystroke
• Fix conflict with #8