Comments (4)
vbaranov
commented on May 28, 2024
@varasev were you planning to include this feature request to refactored contracts?
from poa-network-consensus-contracts.
varasev
commented on May 28, 2024
@vbaranov I wasn't, because this is a separate task, but if it's necessary, I'll give this task higher priority and include it in the current set of tasks that should be implemented before hard-fork.
from poa-network-consensus-contracts.
vbaranov
commented on May 28, 2024
@varasev no, this is a lower priority than block reward and additional emission
from poa-network-consensus-contracts.
varasev
commented on May 28, 2024
This was implemented and covered by tests in #113
I didn't include a calling of finalization function inside vote method because there can be a blocking (in case of any errors) if _finalizeBallot reverts, so the last validator won't be able to vote in this case and will be confused.
Therefore I suggest this implementation that assumes any validator should call finalize method separately by the same principle that works now.
These changes cover poanetwork/RFC#8.
from poa-network-consensus-contracts.
Related Issues (20)
- (Bug) KeysManager: there is no restrictions who can execute migration functions HOT 1
- (Feature) PoaNetworkConsensus.isValidatorFinalized function HOT 1
- (Fix) removeVotingKey and removePayoutKey shouldn't revert if voting/ payout key is already removed HOT 1
- (Improvement) Voting DApp creates a lot of requests to call data from smart-contracts HOT 5
- Fix solc usage HOT 4
- (Fix) Auto decrease min threshold when validator is removed HOT 1
- (Feature) VotingToManageEmissionFunds should allow canceling new ballot by its creator for 15 minutes after it's created HOT 1
- (Update) Update truffle package to 5.0
- (Update) Review the value of the depth of changing mining keys
- (Update) Using of different events for different actions
- (Fix) Add checking for contract's existence to VotingToChangeProxyAddress.createBallot
- Get rid of limitation when an account could receive coins only once per every block HOT 1
- Add ability to get total amount of coins minted by Block Reward feature HOT 1
- (Fix) VotingToManageEmissionFunds.canBeFinalizedNow function
- (Question) Are the deployed contracts versioned? HOT 3
- (Update) Introduce min ballot duration in VotingToManageEmissionFunds contract like in other VotingToChange* contracts HOT 1
- (Update) Registration of several bridge in RewardByBlock HOT 10
- (Update) Add `contactEmail` and `isCompany` fields to ValidatorMetadata contract HOT 1
- Question about PoaNetworkConsensus contract validator states HOT 2
- I transferred POA NETWORK to my MetaMask wallet on the xDai network and I can't find the currency in my wallet so I can convert or transfer it.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from poa-network-consensus-contracts.