Comments (2)
Hi @ngyam,
Yes, you're right, the isValidator
shouldn't return true
until the pending validator set is not finalized (the finalizeChange
is called). The isValidator
is lying for the newly added or removed validator in the period of time when the validator set is already changed but not yet finalized (several blocks between callings of the addValidator
and finalizeChange
).
We, unfortunately, missed this moment and didn't fix it when we were working on the last hard fork. However, the isValidatorFinalized
getter can be used instead to determine if the specified address is a finalized validator.
For the current version of PoaNetworkConsensus
contract, it's recommended to use the getValidators()
getter: if some address is in the current validator set, that address will be in the returned array of the getValidators()
. The getValidators()
always returns an actual validator set taking into account the finalization.
Thank you for this issue - we should fix this when we have next hard fork which we'll ever do.
from poa-network-consensus-contracts.
Hi @varasev
Thanks for the clarification!
from poa-network-consensus-contracts.
Related Issues (20)
- (Bug) KeysManager: there is no restrictions who can execute migration functions HOT 1
- (Feature) PoaNetworkConsensus.isValidatorFinalized function HOT 1
- (Fix) removeVotingKey and removePayoutKey shouldn't revert if voting/ payout key is already removed HOT 1
- (Improvement) Voting DApp creates a lot of requests to call data from smart-contracts HOT 5
- Fix solc usage HOT 4
- (Fix) Auto decrease min threshold when validator is removed HOT 1
- (Feature) VotingToManageEmissionFunds should allow canceling new ballot by its creator for 15 minutes after it's created HOT 1
- (Update) Update truffle package to 5.0
- (Update) Review the value of the depth of changing mining keys
- (Update) Using of different events for different actions
- (Fix) Add checking for contract's existence to VotingToChangeProxyAddress.createBallot
- Get rid of limitation when an account could receive coins only once per every block HOT 1
- Add ability to get total amount of coins minted by Block Reward feature HOT 1
- (Fix) VotingToManageEmissionFunds.canBeFinalizedNow function
- (Question) Are the deployed contracts versioned? HOT 3
- (Update) Introduce min ballot duration in VotingToManageEmissionFunds contract like in other VotingToChange* contracts HOT 1
- (Update) Registration of several bridge in RewardByBlock HOT 10
- (Update) Add `contactEmail` and `isCompany` fields to ValidatorMetadata contract HOT 1
- I transferred POA NETWORK to my MetaMask wallet on the xDai network and I can't find the currency in my wallet so I can convert or transfer it.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from poa-network-consensus-contracts.