pnpm store doesn't have symlink files after version 8.7 about pnpm HOT 6 CLOSED

We should fix this. Here's the reason:

Our in-house tarball extractor currently skips symlinks.

from pnpm.

This PR should fix it: #7705

from pnpm.

Thanks @bitofsky for look into it. We will for sure backport the fix to v8 too. We just need to cover it with a test. I don't want us to break it again in the future.

from pnpm.

No, actually it is a problem with side-effects cache. When we upload side-effects cache to the store, we don't upload symlinks correctly, I guess. I get the same issue with pnpm v8.6.12

from pnpm.

I assume this issue is the same as #7253

from pnpm.

@zkochan Hello? I have found an issue in cafs/src/addFilesFromDir.ts.
In version pnpm 8.6.12, symbolic links are recognized as files, but starting from version pnpm 8.7.0, symbolic links are not recognized as files anymore.
The changes between the two versions are as follows:

[email protected]

    const files = await fs.readdir(currDir) // readdir returns an array of strings
    await Promise.all(files.map(async (file) => {
      ...
      const stat = await fs.stat(fullPath) // stat returns a Stats object
      if (stat.isDirectory()) {
        ...
      }
      if (stat.isFile()) { // symbolic links are considered files

[email protected]

    const files = fs.readdirSync(currDir, { withFileTypes: true }) // readdirSync returns an array of Dirent objects
    for (const file of files) {
        if (file.isDirectory()) {
            ...
        }
        if (file.isFile()) { // symbolic links are not considered files
            ...
        }

Dirent objects and Stats objects return different results when the isFile() method is called on symbolic linked files.
While Dirent objects return false when the isFile() method is called on symbolic linked files, Stats objects return true.

10272392 -rw-rw-r-- 1 bitofsky bitofsky  2 Feb 23 16:06 origin.txt
10272393 lrwxrwxrwx 1 bitofsky bitofsky 10 Feb 23 16:09 link.txt -> origin.txt
> node
> require('fs').readdirSync('.', {withFileTypes:true}).find(f => f.name === 'link.txt').isFile() // readdirSync returns an array of Dirent objects
false
> require('fs').statSync('./link.txt').isFile() // statSync returns a Stats object
true

However, starting from [email protected], symbolic links are correctly recognized again.
The code checking for isFile() in the if condition has been removed and replaced with else.

    const files = fs.readdirSync(dir, { withFileTypes: true })
    for (const file of files) {
        if (file.isDirectory()) {
            ...
        } else { // symbolic links are considered files
            ...
        }

I believe the code modified in version 9.0.0-alpha.5 should be reflected in the version 8 series as well, or the code after 8.7 should be modified as follows.

-       } else if (file.isFile()) {
+       } else if (file.isFile() || file.isSymbolicLink()) {

Thank you.

from pnpm.