Code Monkey home page Code Monkey logo

Comments (6)

passionate-bram avatar passionate-bram commented on June 1, 2024

Pnpm is specified in engines field on the workspace:

"pnpm": ">=9"

I'm not familiar with the codebase, just wanting to make a small contribution elsewhere, but surely it is not wise to require unreleased major versions of your own project in order to properly set up your own repository.
If the repository supports the current major version (8) then at least the code can be worked on, once the major lands you can swap out the parts of the codebase that use the new v9 features. Note that this assumes that the changes in pnpm would not lead to changes in the actual build output of pnpm project.

from pnpm.

zkochan avatar zkochan commented on June 1, 2024

It isn't unreleased. It is published and you can install it. 9.0.0-alpha.5 is published.

from pnpm.

passionate-bram avatar passionate-bram commented on June 1, 2024

It isn't unreleased. It is published and you can install it. 9.0.0-alpha.5 is published.

Perhaps add a note to CONTRIBUTION.md detailing this edge-case. Additionally, I don't want to install a prerelease version on my entire system just to make a contribution to this repository.

from pnpm.

zkochan avatar zkochan commented on June 1, 2024

You can downgrade pnpm after the contribution. Testing the next version of pnpm is more important than developer experience for new contributors.

from pnpm.

passionate-bram avatar passionate-bram commented on June 1, 2024

You can downgrade pnpm after the contribution. Testing the next version of pnpm is more important than developer experience for new contributors.

Lets document the edge-case then in CONTRIBUTING, because I actually really appreciated the clear documentation on how to get started.

from pnpm.

zkochan avatar zkochan commented on June 1, 2024

ok

from pnpm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.