Code Monkey home page Code Monkey logo

Comments (8)

VesaJuvonen avatar VesaJuvonen commented on July 28, 2024

Thx for reporting this issue. We did do some modifications on the model recently, but the intention was not to change this to require one-by-one apply on site level. We'll have a look on the changes and will perform needed updates.

from pnp-tools.

SPDoctor avatar SPDoctor commented on July 28, 2024

It would make sense to have an option to make it recursive. I don't think it should apply recursively by default - in general you expect commands to not apply recursively by default.

from pnp-tools.

VesaJuvonen avatar VesaJuvonen commented on July 28, 2024

This solution relies on the UserCustomAction collection entry for the JS file. This was originally set at the site collection level in the original scripts, which meant that all sites in site collection had it. With the latest updates on the process, responsiveness is only applied in site level (Web.UserCustomAction), which is why @JessKCan is seeing a difference compared to older version.

This means that it's not specifically recursive, setting was rather applied in the site collection level in past. We'll work on having this option in the future as well.

from pnp-tools.

SPDoctor avatar SPDoctor commented on July 28, 2024

The current solution is just to enable you to use custom assets, so it is the underlying PowerShell cmdlet in SharePointPnP.PowerShell commands (Enable-SPOResponsiveUI) that needs to be re-visisted to include that behaviour. I suggest raising an issue against SharePointPnP.PowerShell for adding an optional -Recursive parameter to both Enable-SPOResponsiveUI and Disable-SPOResponsiveUI.

from pnp-tools.

VesaJuvonen avatar VesaJuvonen commented on July 28, 2024

I would not do this as recursive - rather as option to set it in site collection or in site level. Since if it's done recursively on site level, it's much more difficult to maintain and control than as one site collection setting.

from pnp-tools.

SPDoctor avatar SPDoctor commented on July 28, 2024

Okay, but assume still needs change to cmdlet because base class for that is SPOWebCmdlet. Perhaps by convention it could apply to site collection if the web is the root web? Or have to set an explicit parameter as well?

from pnp-tools.

JessKCan avatar JessKCan commented on July 28, 2024

Thanks so much for looking into it.

from pnp-tools.

VesaJuvonen avatar VesaJuvonen commented on July 28, 2024

This one was fixed in the October release. It targets again properly at the site collection level by default. This was a bug with the previous releases, but if you update to latest version, it works as expected again cross site collection in classic sites.

from pnp-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.