pnp / graph-connectors-samples Goto Github PK

I used the Graph Connectors API as in this sample to push items into the graph index to an external system (example: https://mydemoclient.freshservice.com/a/solutions/articles/123456789). Connector works great. I see results in SharePoint Search, I can see items in Graph Explorer. Copilot can even answer a question and provide a citation to the KB/solution articles that are in the Graph.

The issue is that the citation links in M365 Copilot don't link to the source system. It is missing an href/url so you hover over it and click and it does nothing.

My links work fine in SharePoint search, I can navigate to the article in the external system. Links to external items from another connector work fine (using the native MS Graph connector for ServiceNow) in both search results and Copilot citations. So I don't think it is a Copilot bug. I believe the bug is missing info/documentation on what properties you need to set on an external item in the graph to make Copilot citation links work.

I've tried: url, titleUrl, accessUrl and a host of others like webdavUrl.

Has anyone else run into this issue and found a solution? Can you update this sample repo with a fix?

Keep the standard folder structure like:

.
│ .idea
└── src
├── main
│ ├── java
│ │ └── com.simpleproject
│ │ └── SimpleClass.java
│ └── resources
└── test
├── java
│ └── com.simpleproject
│ └── SimpleClassTest.java
└── resources

Let's update the Python markdown sample to use the Microsoft Graph Python SDK GA version which was released on Nov 1

Right now, for the Sample Gallery connector we use a bash setup script. While it works fine on macOS, it's hard to use on Windows unless you've got WSL. Having an equivalent script in PowerShell would make it easier to run the sample on Windows.

I can't order/sort the result (highlighted issue in the snapshot, 2 showing first then 1) using the MS SQL Connector despite of being defined in SQL query to do so. I have not tried custom built connector at this time, but I do see that from screenshots that the results are in random in its display pattern.

I'll appreciate any tips to overcome the issue.

Thanks,

In readme step 4, It need user to open "resultType.json" file, but only found "resultLayout.json" instead.
https://github.com/pnp/graph-connectors-samples/tree/main/samples/nodejs-typescript-food-catalog#4-create-the-result-type-template

cc @garrytrinder

In following the steps for Simulated debugging with Dev Proxy and its failing. Confirm for following Debug locally against a real Microsoft 365 tenan also fails.

I'm running Windows Version 10.0.22631 Build 22631, Visual Studio 2022 Enterprise edition Version 17.9.6, Microsoft .NET Framework 4.8.09032.

Grpc.Core.RpcException
  HResult=0x80131500
  Message=Status(StatusCode="Internal", Detail="Error starting gRPC call. HttpRequestException: Requesting HTTP version 2.0 with version policy RequestVersionOrHigher while unable to establish HTTP/2 connection.", DebugException="System.Net.Http.HttpRequestException: Requesting HTTP version 2.0 with version policy RequestVersionOrHigher while unable to establish HTTP/2 connection.")
  Source=Grpc.Net.Client
  StackTrace:
   at Grpc.Net.Client.Internal.HttpContentClientStreamWriter`2.<WriteAsyncCore>d__19`1.MoveNext()
   at Grpc.Net.Client.Internal.HttpContentClientStreamWriter`2.<WriteCoreAsync>d__15.MoveNext()
   at Microsoft.Azure.Functions.Worker.Grpc.GrpcWorkerClientFactory.GrpcWorkerClient.<SendStartStreamMessageAsync>d__8.MoveNext()
   at Microsoft.Azure.Functions.Worker.Grpc.GrpcWorkerClientFactory.GrpcWorkerClient.<StartAsync>d__7.MoveNext()
   at Microsoft.Azure.Functions.Worker.WorkerHostedService.<StartAsync>d__3.MoveNext()
   at Microsoft.Extensions.Hosting.Internal.Host.<<StartAsync>b__15_1>d.MoveNext()
   at Microsoft.Extensions.Hosting.Internal.Host.<ForeachService>d__18`1.MoveNext()
   at Microsoft.Extensions.Hosting.Internal.Host.<StartAsync>d__15.MoveNext()
   at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.<RunAsync>d__4.MoveNext()
   at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.<RunAsync>d__4.MoveNext()
   at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.Run(IHost host)
   at Program.<Main>$(String[] args) in C:\src\graph-connectors-samples\graph-connectors-samples\samples\dotnet-csharp-graphdocs-ttk\Program.cs:line 82
 
  This exception was originally thrown at this call stack:
    [External Code]
 
Inner Exception 1:
HttpRequestException: Requesting HTTP version 2.0 with version policy RequestVersionOrHigher while unable to establish HTTP/2 connection.

Hi @waldekmastykarz ,

In the sample: https://github.com/pnp/graph-connectors-samples/tree/main/samples/nodejs-typescript-food-catalog
reading through the samples and noticed in some cases the diagrams do not represent well in dark mode on GH.

Its only some of them, those with swim lanes seem fine:

Albeit this is a very cool sample, with the explanations and learnings around the multiple ingestion scenarios - GREAT WORK!! Both of you @garrytrinder and @waldekmastykarz

First off thank you for this sample! Its a great idea!

The readme file states setting user settings with "AzureAd:" but in the GraphService.cs its looking for "EntraId:".

Rather than change my self wanted @mohammadamer to confirm this is correct to adjust.

On changing, it did not throw an error about not finding ClientId. But after waiting 5 mins it did not show up in Search And Intelligence center.

The readme also had the wrong command arguments: they should be provision-connection not create-content.

The readme for this sample would be useful to explain what permissions scopes are required for the Azure AD / Entra Id app.

It would be useful if it outputted more verbose messages in the command line to explain what it actually did rather than closing silently.

As an example, when i ran load-content after doing provision-connector I just got "ERROR" on every single time it tried to index item without any detailed error messages.

npm run createConnection failed

[email protected] createConnection
node createConnection.js

Creating connection...
TypeError: Cannot destructure property 'id' of 'config.connector' as it is undefined.
at createConnection (file:///C:/Users/ksc.IPIWE/Downloads/pnp%20graph-connectors-samples%20main%20samples-nodejs-javascript-solutiongallery/createConnection.js:7:11)
at main (file:///C:/Users/ksc.IPIWE/Downloads/pnp%20graph-connectors-samples%20main%20samples-nodejs-javascript-solutiongallery/createConnection.js:52:11)
at file:///C:/Users/ksc.IPIWE/Downloads/pnp%20graph-connectors-samples%20main%20samples-nodejs-javascript-solutiongallery/createConnection.js:60:1
at ModuleJob.run (node:internal/modules/esm/module_job:194:25)

Hi,
Tried the MSlearnCatalog solution. followed the steps you have mentioned but after uploading the manifest in the teams admin center and giving the required permissions I am receiving the error in the attachment. Could anyone please give some valuble inputs to resolve it.

Thank you for creating this useful sample library!

I used the REST Countries sample with Powershell as basis for a Graph Connector used for Copilot. Would it be possible to complement that sample with a few lines of code describing how to connect via PowerShell if the REST API uses OAuth2 with a token?

Best regards,
Daniel