pmndrs / market Goto Github PK

Hi @SaraVieira ,
when I try to access the page directly: https://market.pmnd.rs/models/categories/technology

I get the following error:

OH NO
500 - Something went wrong

The download links for all the matcaps I checked link to "/material/undefined" which returns an error 500

Example: https://market.pmnd.rs/material/basic-1 https://market.pmnd.rs/material/clay-white

Right now the ordering of assets only goes one way, it would be nice to be able to toggle that

Important files:

Order: src/helpers/store/utils.js
Search: src/components/Search.js

Hey guys! Really happy to see this repo spring to life!

When I spoke with @drcmda a couple of weeks ago we talked about some way of sharing pre-made materials for prototyping. Things like metals, bricks, concrete, wood planks, and so on, all optimized for Three.js.

There are two ways materials are usually shared - either as a texture pack, or as a complete surface. The texture pack is easy, you just put the maps in a zip file (you also have to get/create the textures, of ccourse).

However, this doesn't capture other surface settings like refraction ratio, color, transparency, normal scale, etc.

I like what you're doing with the JSX code snippet beside the model download, we could do the same for the materials:

const [tex, roughnessTex, normalTex] = useLoader(THREE.TextureLoader, [texURL, roughnessTexURL, normalTexURL])

<mesh
	  <boxGeometry attach="geometry" args={[0.6, 0.6, 0.6]} />
	  <meshStandardMaterial attach="material" 
		    map={tex}
		    roughnessMap={roughnessTex}
		    normalMap={normalTex}
		    transparent 
		    opacity="0.25"
		    // ... etc.
	  />
/>

This does tie everything in to R3F quite strongly though. What about adding plain JS beside the JSX?

P.S. I know that donut! 😆
https://market-phi.vercel.app/model/donut

I wasn't able to quickly find it in the code base -- but if it isn't resolved by tomorrow I'll submit a PR. However, the preset menu color is the same as the background color. Images below. I would recommend color: #212224; or something similar to the menu color.

Original:

Recommendation:

The UserMenu is hidden by other elements, it's not a problem until you are into "request an asset page" and the logout button is hidden.

I think is a z-index fix, let me know if I can contribute, at least with these
small issues

An option to include types when using the "Copy JSX Scene Graph" feature for models would be super handy!

Right now I'm just downloading the model and getting a scene graph with types from https://gltf.pmnd.rs/.

It looks like an extra types parameter could be optionally passed to @react-three/gltfjsx if say different button was clicked?

I suppose an extension to this feature request could also be optional types for the other features too - but I'm particularly keen for copying JSX with types.

If there's interest for this, I'd also be happy to try contributing 🙂

https://github.com/pmndrs/drei-assets

Would it make sense to host those assets here as well?

Independently, HDRIs and LUTS are good candidates for categories here.

I tried the various downloads for this model , Three.js works fine but the React-three-fiber starter projects renders black without model and gives me an console error 'GLTFLoader.js:149 RangeError: Invalid typed array length: 4 at new Uint8Array () at GLTFLoader.parse (GLTFLoader.js:254) at Object.onLoad (GLTFLoader.js:169) at XMLHttpRequest. (three.module.js:34742)'

Status is 200 for the model but as I said it only renders a black window, how can this be resolved?

Can I help to migrate javascript files to typescript?

when running prettier I always get an issue:

❯ yarn prettier
yarn run v1.22.5
$ prettier --list-different '**/*.{js,jsx,md}'
README.md
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Very useful yeah

The page stuck while loading data, so I thought I didn't click the link.

Hello
I would ask what is the licence of this repository?

Thanks you

At the moment the sidebar in the individual assets feels kinda buggy because leva only shows up a couple of seconds after

Pushing it to the top would be a great addition

A page that is already doing something similar is the request page, the title is inserted there and not in the layout

Hi @SaraVieira ,
when i try to open any HDRIs element i open the page i get the following message in the page:

An unexpected error has occurred.

Example: https://market.pmnd.rs/hdri/forrest-slope

Hi @SaraVieira ,
It would be interesting to indicate the number of views for each model.

Matcaps are great for prototyping and I've seen them in a number of production projects too.

There are loads of matcaps here:
https://github.com/nidorx/matcaps

According to the readme on that repo, the matcaps were gathered from various sources and are not the work of the repo owner. So it should be fine for us to co-host them here if we like.

The /favorites page is down (500)

and when running it locally it keeps redirecting to root

Hi @SaraVieira ,
when I try to access the page directly: https://market.pmnd.rs/hdris/categories/night

I get the following error:

OH NO
500 - Something went wrong

Hi! Quick suggestion. Currently downloads use the .gltf extension with binary resources embedded as Data URIs. This adds 20-30% to the size of that binary data, and increases loader parsing time, compared to a binary .glb or to a .gltf with its binary resources in separate files. I'd recommend providing a .glb instead, or a ZIP containing .gltf and other files.

Hi @SaraVieira , it would be interesting to also have the possibility of having the multilingual site.
Example: Spanish, Italian, German etc.

Should only be able to leave a comment when logged in

Right now we have three different info components:

• src/components/MaterialInfo.js
• src/components/ModelInfo.js
• src/components/HDRIInfo.js

Even though all of these are basically the same, this could easily be only one component that showed the buttons by the type of asset it is

I changed the supabase key to my own and added the profiles to the supabase table, but an error popped up and it was not resolved.
I want to implement login and model upload in the local environment, is there any information I can refer to?

Hi @SaraVieira , it would be interesting to also have the possibility to use the site in a dark mode version.

The environment leva dropdown in the asset info component is broken.

only city works, the other options don't render the model at all

Clicking "Download MapCap" results in a 500. Direct link works great.

https://market.pmnd.rs/material/undefined

Can the assets on the market be installable straight from npm?
I think that will make them more accessible instead of downloading them and moving them to the project folder.

I was thinking something like @fontsource

React three fiber starter project can use:

<Environment path="" files={path to hdri} background={true} />

Files that generate code are in src/helpers/code

Hi @SaraVieira ,
when I try to access the page directly: https://market.pmnd.rs/materials/categories/matcaps

I get the following error:

OH NO
500 - Something went wrong

Should only be possible when logged in

I couldn't find a "report issue" or similar on the new market site (which is amazing btw) so I'm posting here instead. Do let me know if I should report this somewhere else.

Description

• Some vehicles have inside-out wheels and other faces (eg. sides of fire truck)

Expectation

• No faces should be inside out on vehicles

Specs

• Windows 10
• Chrome 90.0.4430.212 (Official Build) (64-bit)

Examples with issue

Firetruck

Delivery Truck

Examples without issue

• Some vehicles don't have this issue, though use similar / identical wheels

Police Car

SUV

Hi @SaraVieira ,
there seems to be a problem with the following model:
https://market.pmnd.rs/model/jack

The URL produced after clicking "Copy JSX Scene Graph" on a model contains a leading slash, which causes an error if you paste it into your project.

E.g. the scene graph copied for the avacado is:

/*
Auto-generated by: https://github.com/pmndrs/gltfjsx
*/

import React, { useRef } from 'react'
import { useGLTF } from '@react-three/drei'

export default function Model(props) {
  const group = useRef()
  const { nodes, materials } = useGLTF(
    '/https://market-assets.fra1.cdn.digitaloceanspaces.com/market-assets/models/avocado/model.gltf'
  )
  return (
    <group ref={group} {...props} dispose={null}>
      <mesh
        geometry={nodes.avocado.geometry}
        material={materials.brownDarkest}
        scale={[0.53, 0.53, 0.53]}
      />
    </group>
  )
}

useGLTF.preload(
  '/https://market-assets.fra1.cdn.digitaloceanspaces.com/market-assets/models/avocado/model.gltf'
)

By contrast, the URL produced when clicking "Copy Primitive Import" is correct.

Running on Firefox, Windows, I'm noticing that the hover transition is played rapidly while mousing over labels.

This stops when no longer mousing over a thumbnail and can persist while the cursor is still.

Example: https://market.pmnd.rs/model/nessdghaj

Hi @SaraVieira, using the browser of a mobile device I get this:

Maybe it's a project related problem: https://github.com/pmndrs/leva

Would adding a page dedicated for sounds effects be a good idea? or should we leave that to other sites such as https://freesound.org/?

How about adding an option to submit a paid asset? that would give creators an incentive to submit their work while earning them money.

I was thinking something similar to https://contributor.flaticon.com/

It can't be dragged back again as the text eats the click event. Is it possible to disable dragging on Leva entirely?

Hi @SaraVieira ,

I noticed that there are more models than indicated on the main page.
For example this is the latest model shown in the home: https://market.pmnd.rs/model/wood-bucket

But on the page itself, going to see the next one, one is indicated, by clicking on next, the following message appears: An unexpected error has occurred.

But reloading the page loads a template.

From here on, the same thing happens with the following models.

Hi @SaraVieira, in edit materials the back button does not seem to work.
First I'm on this page:
https://market.pmnd.rs/model/dogue
Then I click on the "Edit materials" button and I am in this page:
https://market.pmnd.rs/editor/dogue

When I try to go back it doesn't work.

Description

• If I try to request a new asset nothing happens
• There is no network request performed in the network panel after clicking request button

Steps to reproduce

• Click "Request an Asset"
• Enter details in 3 form fields
• Click "Request"
• Nothing happens

Expectation

• Clicking "Request" submits and updates page with new request

Hi @SaraVieira ,
It would be interesting to sort by ascending or descending size.