Code Monkey home page Code Monkey logo

artisan-beans's People

Contributors

pmatseykanets avatar segadora avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

artisan-beans's Issues

PHP 8.0 support

Can this be updated to run on PHP 8.0 sometime soon? It might be as simple as a composer.json update.

laravel 9 upgrade

I encountered a conflict with composer when trying to run the package on the latest Laravel release (v9.49.0) or the soon-to-be-released version 10. Specifically, pmatseykanets/artisan-beans v4.2.0 requires illuminate/support ~6.0|~7.0|~8.0, but illuminate/support[v8.0.0, ..., v8.11.2] requires PHP ^7.3, which is not satisfied by the PHP version (8.0.27) I'm using.

Upon reviewing the package's source code, I found that its requirements are set to "php": "^7.2|^8.0" and "illuminate/support": "~6.0|~7.0|~8.0". According to Laravel's upgrade documentation, the package's code should be compatible with versions 9 and 10.

To address the issue, I plan to add versions 9 and 10 to the composer requirements and test if everything is still working as expected.

Registering commands in register()

Should commands be registered in boot?

https://github.com/pmatseykanets/artisan-beans/blob/master/src/ArtisanBeansServiceProvider.php#L20

As mentioned previously, within the register method, you should only bind things into the service container. You should never attempt to register any event listeners, routes, or any other piece of functionality within the register method. Otherwise, you may accidentally use a service that is provided by a service provider which has not loaded yet.

https://laravel.com/docs/5.4/providers#the-register-method
https://laravel.com/docs/5.3/providers#the-register-method

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.