pmatos / nora Goto Github PK

LLVM provides dyn_cast for downcasts. We should use those goodies from the LLVM lib.
Search for static_cast, and there are mostly the places where dyn_cast can be used.

Templatize downcast of ExprNode to ValueNode

We already do this manually in interpreter.cpp at least once and more situations like these will happen.

Remove ArithPlus and possibly other AST nodes that are runtime

The current nodes that should be part of runtime should be removed and added to the environment during a prepareRuntime method executed at Interpreter construction time.

Interpret let-values

Split writer from dumper

We need a Writer class that writes Racket values, as opposed to the dumper who is supposed to dump ASTNodes.

An example where these differs is values.

The Writer should write (values 1 2) as

1
2

while the Dumper should dump it as

(values 1 2)

Closure test crashes nora

The following test crashes nora:

;; RUN: norac %s | FileCheck %s
;; CHECK: 12
(linklet () ()
  (define-values (fn) (values 0))
  (let-values (((x) (values 2)))
     (set! fn (lambda (y) (+ x y))))
  (let-values (((x) (values 3)))
     (fn 10)))

There's a warning from ubsan as well:

Cannot set undefined identifier.
Expected lambda expression in Application.
/home/pmatos/dev/nora/src/include/interpreter.h:43:52: runtime error: member call on null pointer of type 'ast::ValueNode'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/pmatos/dev/nora/src/include/interpreter.h:43:52 in
UndefinedBehaviorSanitizer:DEADLYSIGNAL
==23846==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x000000000000 (pc 0x56310e36d3d7 bp 0x7ffebfb63690 sp 0x7ffebfb63650 T23846)
==23846==The signal is caused by a READ memory access.
==23846==Hint: address points to the zero page.
    #0 0x56310e36d3d7 in Interpreter::getResult() const /home/pmatos/dev/nora/src/include/interpreter.h:43:52
    #1 0x56310e36cae7 in main /home/pmatos/dev/nora/src/main.cpp:53:26
    #2 0x7f2ef4c3c78f  (/usr/lib/libc.so.6+0x2378f) (BuildId: 4a4bec3d95a1804443e852958fe59ed461135ce9)
    #3 0x7f2ef4c3c849 in __libc_start_main (/usr/lib/libc.so.6+0x23849) (BuildId: 4a4bec3d95a1804443e852958fe59ed461135ce9)
    #4 0x56310e33aa74 in _start (/home/pmatos/dev/nora/build/bin/norac+0x164a74) (BuildId: ff1360b6f90819159bf3d99f7e8a9ddb2f700ae2)

UndefinedBehaviorSanitizer can not provide additional info.
SUMMARY: UndefinedBehaviorSanitizer: SEGV /home/pmatos/dev/nora/src/include/interpreter.h:43:52 in Interpreter::getResult() const
==23846==ABORTING

I also think that even once this is fixed nora will print 13, rather than 12.

pmatos / nora Goto Github PK

nora's Issues

Recommend Projects

Recommend Topics

Recommend Org