plushtoast / dsa5-foundryvtt Goto Github PK

Hi,

I found some modules interfere with the dsa5-system.

• Autocomplete Whispers: Rolls from Chat are executed twice while this module is active.
• Clocks: The whole actor-sheet is a clock. Not possible to access it's data.

Describe the bug
Hi, ich finde den Meister der Improvisation (Erschwernisse durch
fehlendes Werkzeug um 2 senken) aber nicht den Meister der improvisierten Waffen (keine Nachteile bei Nutzung improvisierter Waffen). Eventuell verwirre ich aber auch die Regeln und das gilt als eins?

To Reproduce
Steps to reproduce the behavior:
Fähigkeit nicht bei den items vorhanden

Make sure to press enter after you edited the value.
This behaviour will be changed.

Any Equipment should be able to take an artifact effect

Changing money values is currently a bit cumbersome, let's improve on that.

When you roll for a sickness / poison, you can enter the enemy modifier manually, but you have to invert the value.
Input field says "Zähigkeit", and the target has a value of 2, you have to enter -2 to work correctly.

When you declare a token as target, it automatically does it right, but regular users may get incorrect results without noticing.

Wenn man im Kompendium für Kampftechniken eine eben jener öffnet und oben rechts auf "im Chat öffnen" klickt, wird nur das generische Bild in den Chat gepostet, die Beschreibung nicht. Bei anderen Items (zB Ausrüstung) wird auch die Beschreibung in den Chat gepostet.

Describe the bug
Module 1.1.0
If you lock the character sheet, the fields for values (abilities, spells etc.) are still open and can be edited.
When changing values directly in the field, it is possible to set any value (not sure if this is a bug or by design to overcome the restrictions of the rules if wanted).
If you change values directly in the field, then change them later on with + and - buttons, they sometimes snap back to old values entered manually.

To Reproduce
Steps to reproduce the behavior:
Select one talent, Switch between locked/unlocked sheet, change values with +/- symbols and directly in the field, roll inbetween each change and check against what value it rolls.

Expected behavior
Changes for values should be possible or not possible, independent of how you set them.
Validity check should either happen or not, independent of how you set a value ("maximaler fertigkeitswert erreicht...")

Desktop (please complete the following information):
win10, running as GM

Additional context
Suggestions:

• Lock/Unlock FW fields via separate option ("Change Values directly - recommended for char creation only" or similar)
• When locked, only allow changes via symbols +/-
• Allow to ignore rule limitations via options (select, if you want to hard-limit values, only show a warning, or don't check at all, for different areas like magic, abilities etc.)

Describe the bug
GRW 1.0, Premade Character (Elwene)
If you roll for a Eigenschaft, it shows "NaN" for the modificators.

To Reproduce
Roll on KL, IN etc.

Probably some sort of buttonlist to select skills like "finte" and their step including and then calculating the modifiers.
Any suggestions on how to proceed are welcome.

Describe the bug
v1.1
When you hit a critical attack, the text states that the enemies defense is halved.
The tooltip text indicates that it rolls agains the original value, not the halved value.

To Reproduce

1. Start Combat via combat tracker, roll INI
2. Declare a token as target
3. Attack with the token according to combat tracker
4. Hit a critical confirmed hit
5. Use Parade with the token declard as target, chat shows it rolls against original value (in this case 8, for the ork with his säbel)

Expected behavior
Roll against the halved value, or change the tooltip text if that is the problem.

Screenshots

Desktop (please complete the following information):
win10

Sidenote:
The presented information for rolls in the chat are wonderful, but the damage rolls only show the dice roll values. technically, this makes sense, but for a user it's a bit confusing - you see a rolled 2 and the crit damage ends up 20.
Maybe change it later on and separate the attack roll and the damage roll, and in the damage roll print the dice roll plus weapon base damage plus additional modifier (schadensschwelle, sonderfertigkeiten etc). very low priority.

When you have a trait influencing your roll (ie. Nachteil "Persönlichkeitsschwäche: Vorurteile (Adlige)"), you can't read the whole name in the window with the roll modificators (the pre-roll pop-out window).

Making that window resizeable would help.

Additional consideration: For certain traits like Persönlichkeitsschwäche, the GM must decide if the roll gets the -1 modificator or not. Currently, this modifier is always considered true.

• Instead of just showing all the modificators, make them as a list with tickboxes to de-/activate them when needed (in the pre-roll window)
• Make the trait itself "optional" with a tickbox. If such traits are affecting a roll, ask the user via promt if they should be considered.
• Currently, you have to correct a "wrong" modifier via manual values. If it stays like that, it should be mentioned in the wiki or manual.

Während ich alles per Drag&Drop auf den Charakterbogen ziehen kann (eigens erstellte Waffen, Vor- und Nachteile, Sonderfertigkeiten) kann ich jedoch keine Spezies auf den Charakterbogen ziehen, weder die vier mitgelieferten noch eine eigen erstellte Spezies. Es passiert nichts. Charaktererschaffung wie im Wiki aufgeführt ist nicht möglich.
Ich habe dies sowohl ohne ausgewählte Module als auch mit sowie auf Englisch und auf Deutsch versucht. Es geschieht leider nichts. Auch wenn ich mich mit einem Browser (Chrome und Firefox wurden getestet) einklinke, gelingt dies nicht.
Ich weiß leider, was ich noch beitragen kann, um den Fehler nachzuvollziehen...Aber lasst es mich wissen!

Hi, ich versuche eine Holfzfällerin anzulegen, diese kämpft mit einer Holzfälleraxt 2h oder einem Beil. Was muss ich tun um die dort auch anzeigen zu lassen?

Describe the bug

Bei 5 LeP sollte ein Actor eine weitere Schmerzstufe bekommen. Dem ist nicht immer so. Das Wildschwein zb aus dem Schnellstartabenteuer bekommt erst bei LeP 0 Schmerz 4.

To Reproduce

1. Installiere und initialisiere Schnellstartabenteuer
2. Ziehe Wildschweintoken auf Karte
3. Klicke auf Token
4. Gib für LeP einen Wert von 5 oder weniger ein.

Expected behavior
Schmerz 4

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Linux Mint
• Browser Foundry App
• Version 0.7.9

Describe the bug
When you request damage rolls from the players via Journal, the roll works fine. But the option to automatically assign the damage doesn't work.

To Reproduce
Open journal entry as GM.
Send a roll request to the chat (i.e. damage roll on the first bridge, pinned journal entry)
Click on the chat entry to roll damage
Right-click on the damage, select to deduct the damage from health.

Tested options, same behaviour

• as GM and as player
• with and without selecting a token
• with and without declaring a token as target
• with and without activating a battle

Expected behavior
deduct the damage from health, either from selected or targeted token

Vorteil Flink doesn't provide the GS Bonus, "Effect" synthax is wrong (GS 1 instead of +1 GS)

Fixed in next patch

Drag them from the item directory in the meantime.

Describe the bug
According to TDE rules, a character can have a magical and a karmal tradition. While the combination is rare, it is possible.

To Reproduce
Steps to reproduce the behavior:

1. Create a character
2. Add a spell, ritual or cantrip
3. Add a liturgy, ceremony or blessing
4. Character sheet displays "Magie" tab but no "Religion" tab

Expected behavior
Character sheet displays "Magie" tab and "Religion" tab.

Additional context
The main culprit is in line 446-447 of actor-dsa5.js:

//CHAR cannot be clerical and magical at the same time
magic.hasPrayers = magic.hasPrayers && !magic.hasSpells

Apart from that, the character sheet will probably have to be changed to allow for the display of both tabs.

Probably a way to create shapeshifted tokens by defining a source and a shapeshift including a list of attributes and abilities which should be copied

Create or improve equipment so provide a QS and the corresponding effect complete with the included roll and a way to consume it (Healing potion, Waffenpflegeset)

Describe the bug
Reducing Spell costs increases spell costs

To Reproduce

1. create spell
2. use spell
3. select "Kosten reduzieren -1"
4. Costs increase instead of reducing

Expected behavior
Costs reduce when costs are supposed to be reduced

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: PC
• OS: Windows
• Browser Chrome
• Version latest as of 11.02.2020

Additional context
Add any other context about the problem here.

Describe the bug
The SA Sturmangriff has a wrong effect. It should be "+2+GS/2 TP" instead of "+2+GS*2 TP".

In the Character Sheet, you can manually set the SchiPs by left-clicking on them.
You can't set it to zero, tough, because of the click behaviour.

Fertigkeitsspezialisierung makes the whole roll easier and harder. Instead, it should give you +2 Fertigkeitspunkte for that roll (like your talent would be 2 higher than it really is)

Hi,
does this project accept contributions in the form of pull requests? If so, it would be nice to have something like a CONTRIBUTING.md file that e.g. explains how to set up a development environment. My group is currently considering switching to Foundry and being able to fix bugs ourselves or add missing features would be a huge plus.

I was a bit confused by this project at first, because it's not really clear that this corresponds to the official Ulisses module announced here. I'm still not 100% certain if the whole thing is open source or if there are some required proprietary parts.

Describe the bug
Vorteile Zauberer und Geweihter werden nach Login nicht mehr auf AsP und KaP angerechnet

To Reproduce
Steps to reproduce the behavior:
Include Vorteile Geweihter und Zauberer
Maximum festlegen mittels Modifikator
Neuer Login
20 AsP und 20 KaP der Vorteile Zauberer und Geweihter tauchen im Statusbalken nicht mehr im Maximum auf

Expected behavior
20 AsP und 20 KaP tauchen im Statusbalken doch im Maximum auf

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Even after reaching 10QS, the chat still outputs "Teilerfolg" instead of Erfolg.
As soon as the target QS is reached, it should be clearly visible in Chat as such.

Gruppensammelprobe is not available at all.

Bei den Vor- und Nachteilen ist jeweils nur der Flufftext angegeben. Die expliziten Regelauswirkungen fehlen.