plus3it / terraform-aws-watchmaker Goto Github PK

Dependabot couldn't parse the main.tf found at /modules/lx-instance/main.tf.

You can mention @dependabot in the comments below to contact the Dependabot team.

Dependabot couldn't parse the main.tf found at /modules/win-instance/main.tf.

You can mention @dependabot in the comments below to contact the Dependabot team.

Dependabot couldn't parse the main.tf found at /modules/win-instance/main.tf.

You can mention @dependabot in the comments below to contact the Dependabot team.

At least, all the ones that make sense. For example, not much sense in exposing template_body/template_url, since we want to use our template....

• https://www.terraform.io/docs/providers/aws/r/cloudformation_stack.html

Dependabot couldn't parse the main.tf found at /modules/lx-instance/main.tf.

You can mention @dependabot in the comments below to contact the Dependabot team.

Dependabot couldn't parse the main.tf found at /modules/win-autoscale/main.tf.

You can mention @dependabot in the comments below to contact the Dependabot team.

Everything in this section is installing and setting up the cfn bootstrap utility. Affects both lx-instance and lx-autoscale modules.

Propose testing first if the utility is already installed and installing only if it is not present. Here's what I think is a reasonable test:

if [[ $(rpm --quiet -q aws-cfn-bootstrap || pip show --quiet aws-cfn-bootstrap)$? -ne 0 ]]
then
  # do install
fi

Dependabot couldn't parse the main.tf found at /modules/lx-autoscale/main.tf.

You can mention @dependabot in the comments below to contact the Dependabot team.

Currently, we cannot use these templates to attach autoscaling instances to a load balancer. Turns out, that is a property of the autoscaling group, and there is no other attachment method.

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-group.html

Current logic:

"01-get-cloudwatch-agent": {
  "command": {
    "Fn::Join": [
      "",
      [
        "mkdir -p /etc/cfn/scripts/ &&",
        " aws s3 cp ",
        { "Ref": "CloudWatchAgentUrl" },
        " /etc/cfn/scripts/AmazonCloudWatchAgent.zip",
        " --region ",
        { "Ref": "AWS::Region" },
        " &&",
        " chown root:root /etc/cfn/scripts/AmazonCloudWatchAgent.zip &&",
        " chmod 700 /etc/cfn/scripts/AmazonCloudWatchAgent.zip"
      ]
    ]
  }
},

Can be more-compactly expressed/require fewer linked commands:

"01-get-cloudwatch-agent": {
  "command": {
    "Fn::Join": [
      "",
      [
        "install -Dbm 700 -o root -g root /dev/null /etc/cfn/scripts/AmazonCloudWatchAgent.zip &&
        " aws s3 cp ",
        { "Ref": "CloudWatchAgentUrl" },
        " /etc/cfn/scripts/AmazonCloudWatchAgent.zip",
        " --region ",
        { "Ref": "AWS::Region" }
      ]
    ]
  }
},

It would be helpful if the Watchmaker executable was supported in the CFn/TF templates, so there is less reliance on external dependancies. PyPI for example

The CFn installation logic for CloudWatch should fail on EL6 as written — EL6 does not have the systemctl commands currently called out in the referenced JSON-block. Probably want to either change the installation-logic to account for EL6/EL7 differences or stress that cloudwatch agent should not be specified for EL6.

The bot created this issue to inform you that pyup.io has been set up on this repo.
Once you have closed it, the bot will open pull requests for updates as soon as they are available.

Output seen in CloudWatch Agent Logs:

2019-07-05T22:05:19Z E! CreateLogStream / CreateLogGroup with log group name /aws/ec2/lx/devxx-bxx stream name install_*_logs_i-xxxxx has errors. Will retry the request: InvalidParameterException: 1 validation error detected: Value 'install_*_logs_i-xxxxx' at 'logStreamName' failed to satisfy constraint: Member must satisfy regular expression pattern: [^:*]*

Dependabot couldn't find a .tf for this project.

Dependabot requires a .tf to evaluate your project's current Terraform dependencies. It had expected to find one at the path: /modules/<anything>.tf.

If this isn't a Terraform project, or if it is a library, you may wish to disable updates for it from within Dependabot.

You can mention @dependabot in the comments below to contact the Dependabot team.

When using terraform, add options to search for the AMI ID by a name pattern and owner, and default the lookup to sensible values. May be able to do the same for other variables, also.

Dependabot couldn't parse the main.tf found at /modules/lx-autoscale/main.tf.

You can mention @dependabot in the comments below to contact the Dependabot team.

Dependabot couldn't find a .tf for this project.

Dependabot requires a .tf to evaluate your project's current Terraform dependencies. It had expected to find one at the path: /modules/**/<anything>.tf.

If this isn't a Terraform project, or if it is a library, you may wish to disable updates for it from within Dependabot.

You can mention @dependabot in the comments below to contact the Dependabot team.

Presently, all the Cloudformation templates only allow http[s] paths to the Watchmakerconfig.yaml file. Watchmaker has been updated to accept sources from AWS S3 directly and local folders.

Recently rebased [cfn-gitlab() against the current watchmaker-lx-autoscale.template.cfn.json template. Deployed a testing instance with the ScaleUpSchedule/ScaleDownSchedule defined: was surprised to come in, this morning, to find that, even though the overall deployed stack's DesiredCapacity was 1, I was seeing two instances in the EC2 console. Dug through the code and found:

"ScaleUpScheduledAction": {
  "Condition": "UseScheduledAction",
  "Properties": {
    "AutoScalingGroupName": { "Ref": "GitLabASG" },
    "DesiredCapacity": { "Ref": "MaxCapacity" },
    "Recurrence": { "Ref": "ScaleUpSchedule" }
  },
  "Type": "AWS::AutoScaling::ScheduledAction"
}

It seems like it would be better if the ScaleUpScheduledAction block's:

    "DesiredCapacity": { "Ref": "MaxCapacity" },

were

    "DesiredCapacity": { "Ref": "DesiredCapacity" },

Granted, as an upstream project, Watchmaker likely makes different assumptions and I'm free to alter things to fit my project's particular needs but felt it was worth a discussion — thus I'm marking this a question rather than bug.

In particular, AWS::Region, AWS::Partition, and AWS::URLSuffix. At the very least, the cfn endpoint url can be constructed rather than an input.

Dependabot couldn't parse the main.tf found at /modules/win-autoscale/main.tf.

You can mention @dependabot in the comments below to contact the Dependabot team.