pknowles / cropall Goto Github PK

The error can be avoided by replacing line 392

c += " -resize \"" + str(resize_width) + "x" + str(resize_height) + ">\""

against

		if (resize_width > 0):
			c += " -resize \"" + str(resize_width) + "x" + str(resize_height) + ">\""
		c += " \"" + os.path.join(self.outDir, self.currentName) + "\""

Perhaps aspect ratio is the wrong word, if I drag a square over a range of 100x123 pixels that the image I want to save. After making that square I'd like to drag the handles of it to make more minor adjustments, also using the arrow keys for minor pixel adjustments would be great.

Hi. I've changed the line 422 like that:

preview = ImageOps.expand(preview, border=((bbox[2]-preview.size[0])//2, (bbox[3]-preview.size[1])//2))

to avoid that distortion.

Very helpful script.
Thank you very much!

Can be solved by replacing line 248 with

self.inputs[-1].grid(row=0, column=9, sticky="nsew")

Hi!

This program was almost excellent for me! Only thing I was missing was the option to not to rewrite cropped images (i cut scanned pages to portions of text and images).

Python is not very well known for me so I believe it can be done much better, but it's all I can do:

In "try" I added:
import time
In class MyApp(tk) I've modified getImages to make it load images sorted by name:
for i in sorted(os.listdir(dir)):
Modified binds:

		#self.bind('<space>', self.save_next)
		#self.bind('d', self.next)
		self.bind('<space>', self.next)  
		self.bind('s', self.save)        

And added complete "save" function:

	def save(self, event=None):
		box = self.getRealBox()
		filename_l, file_extension_l = os.path.splitext(self.currentName)
		currentName_l = filename_l + "-" + str(int(time.time())) + file_extension_l
		c = "convert \"" + os.path.join(self.inDir, self.currentName) + "\""
		c += " -crop " + str(box[2]-box[0]) + "x" + str(box[3]-box[1]) + "+" + str(box[0]) + "+" + str(box[1])
		if (resize_width > 0):
			c += " -resize \"" + str(resize_width) + "x" + str(resize_height) + ">\""
		c += " \"" + os.path.join(self.outDir, currentName_l) + "\""
		print c
		subprocess.Popen(c, shell=True)
		print "Running"

It adds to new file name datestamp, so nothing will be overwritten.

It might be useful for someone.

Best regards!

I just wanted to let you know that I made a fork of your code, and modified it to accommodate cropping scans of books. I feel like it does not have a place in your repo because you wrote this specifically for a different kind of workflow but feel free to pull in my changes.

The following changes have been done:

• Changed the bounding box from yellow to red
• A much more granular "zooming" factor
• Key-bindings for arrow keys, and ctrl+arrow keys
• key binding for rotating
• deskewing before cropping

Thank you for sharing your work. I found your repo from your answer in this question: http://askubuntu.com/questions/97695/is-there-a-lightweight-tool-to-crop-images-quickly

PS. That person that commented on your answer was a bit of an a**.

It'd be nice to have some way to configure the the output filename (currently it's hidden in the .ini config and it's only an output path). Maybe something like a textbox that can take a format string, e.g. crops/{original}_cropped_{datetime}.{ext}?

Hi, I am about to test the cropall.py script on Ubuntu 14.10.

For your information, here is what I had to do to get it running:

• Cloned with git clone https://github.com/pknowles/cropall.git
• Changed shebang of cropall.py from #!/bin/python to #! /usr/bin/env python2
• installed python-tk : sudo apt-get install python-tk
• installed python-imaging-tk : sudo apt-get install python-imaging-tk
• run script from terminal window with ./cropall.py

Maybe this info should be added to README.md ?