pjaskulski / nbpapi Goto Github PK

1. table_test.go:

• Define a constant instead of duplicating this literal "/tables/A/" 13 times.
• Define a constant instead of duplicating this literal "expected: err == nil, received: err != nil" 7 times.
• Define a constant instead of duplicating this literal "incorrect json content was received" 7 times.
• Define a constant instead of duplicating this literal "invalid table type, expected: %s, received: %s" 4 times.
• Define a constant instead of duplicating this literal "2006-01-02" 5 times.
• Define a constant instead of duplicating this literal "/tables/A/today/" 7 times.
• Define a constant instead of duplicating this literal "want %s, got %s" 5 times.
• Define a constant instead of duplicating this literal "/tables/C/" 10 times.
• Define a constant instead of duplicating this literal "/tables/C/2020-12-07/" 4 times.
• Define a constant instead of duplicating this literal "want err == nil, got err != nil" 3 times.
• Define a constant instead of duplicating this literal "want: err == nil, got err != nil" 6 times.
• Define a constant instead of duplicating this literal "want: err != nil, got err == nil" 8 times.
• Define a constant instead of duplicating this literal "/tables/C/today/" 5 times.
• Define a constant instead of duplicating this literal "incorrect pretty output" 4 times.

helpers_test.go:

• Define a constant instead of duplicating this literal "randomInteger returned value outside expected range" 3 times.

gold_test.go
Define a constant instead of duplicating this literal "expected: err == nil, received: err != nil" 9 times.
Define a constant instead of duplicating this literal "incorrect json content was received" 5 times.
Define a constant instead of duplicating this literal "2006-01-02" 3 times.
Define a constant instead of duplicating this literal "/today" 6 times.
line 294: if !(result[0].Price > 0) { - Use the opposite operator ("<=") instead.Why is this an issue?
Define a constant instead of duplicating this literal "want %s, got %s" 10 times.

currency_test.go
Define a constant instead of duplicating this literal "expected: err == nil, received: err != nil" 7 times.
Define a constant instead of duplicating this literal "expected: err != nil, received: err == nil" 4 times.
Define a constant instead of duplicating this literal "2020-11-13" 3 times.Why
Define a constant instead of duplicating this literal "incorrect json content was received" 3 times.
Define a constant instead of duplicating this literal "/rates/" 12 times.
Define a constant instead of duplicating this literal "/last/" 3 times.
Define a constant instead of duplicating this literal "2006-01-02" 3 times.
Define a constant instead of duplicating this literal "want %s, got %s" 5 times.
Define a constant instead of duplicating this literal "want: err == nil, got: err != nil" 4 times.
Define a constant instead of duplicating this literal "/rates/C/CHF/" 3 times.