pixieditor / colorpicker Goto Github PK

PortableColorPicker seems to currently not obey the normal automatic resizing rules. Would be nice to be able to put it an a grid and it would fill the whole cell with color.

enter #00000000 to reproduce

Basically so that you can do something like this

<PortableColorPicker>
    <PortableColorPicker.ColorPicker>
        <StackPanel>
            <StandardColorPicker />
            <Button>idk</Button>
        </StackPanel>
    </PortableColorPicker.ColorPicker>
</PortableColorPicker>

In addition there are some redundant Grid attached properties on controls in the first cell ( Border ).

use wpf ellipse instead

The fix is to set UseLayoutRounding="False" for ColorSliders and SquarePicker

When the sliders for RGB / HSV and HSL H and S are moved to a new position the selected colour is the same as that under the thumb.

Given

L has two gradient stops - black and white.

By increasing the gradient stops HSL L reflects the effect of moving the L slider on the resulting colour.
I have used 255 equally spaced stops.

New code required in here

I used

            if (SliderHslType == "L")
            {
                var colorStart = GetColorForSelectedArgb(0);
                var colorEnd = GetColorForSelectedArgb(255);
                LeftCapColor.Color = colorStart;
                RightCapColor.Color = colorEnd;
                var backgroundGradient = new GradientStopCollection();
                
                var numStops = 255;
                for (var i = 0; i < numStops; i++)
                {
                    var ratio = (double)i / numStops;
                    var value = 255 * ratio;
                    backgroundGradient.Add(new GradientStop(GetColorForSelectedArgb((int)value), ratio));
                }
                BackgroundGradient = backgroundGradient;
                return;
            }

a certain someone hardcoded a color

A simple example:

A picked color of hex:

• 255
• 215
• 128
• 255

return Scalar values of

• 1
• 0.679
• 0.215
• 1

when you'd expect it to return (float / 255), therefore:

• 1
• 0.84
• 0.5
• 1

I am using SelectedColor to bind a PortableColorPicker to a color.

Some code examples:

public Color SelectedColor
    {
        get => _selectedColor;
        set
        {
            OnPropertyChanging();
            _selectedColor = value;
            X = value.ScR;
            Y = value.ScG;
            Z = value.ScB;
            W = value.ScA;
            OnPropertyChanged();
        }
    }

    public float X
    {
        get => Value.X;
        set
        {
            if (Value.X.Equals(value) && _selectedColor.ScR.Equals(value)) return;
            OnPropertyChanging();
            OnPropertyChanging(nameof(SelectedColor));
            Value = Value with { X = value };
            _selectedColor.ScR = value;
            OnPropertyChanged();
            OnPropertyChanged(nameof(SelectedColor));
        }
    }

I don't think anything in my code is causing this.

Could the next release be strongly named? It will make it much easier to consume.

possibly invalid, see https://stackoverflow.com/a/56240223

Can AlphaSlider be vertical?

Hue slider too even though HSV H and HSL H can be used.

I would like to restyle some of the controls to fit the rest of my application, but I can't because tons of the library is marked as internal, or parts of it are hardcoded in a way that I can't restyle (such as HexColorTextBox's 70 width).

Examples:

• I can't just create my own control template for HexColorTextBox, because it uses TextBoxFocusBehavior and ColorToHexConverter, both of which are internal
• I cannot change the height of the sliders in ColorSliders or the size of the text boxes to the right, because the styles reference HslColorSlider etc which are internal
• I can't use SquareSlider on its own (without the hue circle around it) because it's internal

Would it be possible to make more of these internals public?

for example, on the hue slider, the leftmost position signifies pure red, but the color below the slider head in this position is orange-ish

Probably caused by too many controls bound together. The only potential solution seems to be removing the bindings and instead updating all controls on mouse up. For whatever reason, the lag spikes disappear after attaching a debugger. Detaching it bring them back immediately.

Drop support for out-of-support (end-of-life) .NET runtime version. In this case:

• .NET Framework 4.5.2 (target 4.6.2 for now, it will be supported till 2027)
• .NET Core 3.1
• .NET 5

See also:

• https://learn.microsoft.com/en-us/lifecycle/products/microsoft-net-framework
• https://devblogs.microsoft.com/dotnet/net-framework-4-5-2-4-6-4-6-1-will-reach-end-of-support-on-april-26-2022/
• https://learn.microsoft.com/en-us/lifecycle/products/microsoft-net-and-net-core

Hi,

thank you for your work.

I've added a PortableColorPicker to a DataGridTemplateColumn of a DataGrid. Everything looks fine so far, but I can't switch between the primary and secondary colors.

What am I doing wrong? If I use the PortableColorPicker outside of the DataGrid, the switch between the colors is possible. Even if I add the StandardColorPicker into the DataGridTemplateColumn everything is ok.

Here is my example:

<Window x:Class="MainWindow"
        xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
        xmlns:local="clr-namespace:WpfAppTest"
        xmlns:cp="clr-namespace:ColorPicker;assembly=ColorPicker"
        mc:Ignorable="d"
        Title="MainWindow" Height="450" Width="800">

    <Window.Resources>
        <XmlDataProvider x:Key="MockList" XPath="/MockObjects/*" >
            <x:XData >
                <MockObjects xmlns="">
                    <MockObject />
                </MockObjects>
            </x:XData>
        </XmlDataProvider>
    </Window.Resources>

    <Grid DataContext="{Binding Source={StaticResource MockList}}">
        <DataGrid ItemsSource="{Binding Mode=Default, XPath=/MockObjects/MockObject}" 
                  AutoGenerateColumns="False">
            
            <DataGrid.Columns>

                <DataGridTemplateColumn Header="PortableColorPicker">
                    <DataGridTemplateColumn.CellTemplate>
                        <DataTemplate>
                            <cp:PortableColorPicker ShowAlpha="True" Height="14"/>
                        </DataTemplate>
                    </DataGridTemplateColumn.CellTemplate>
                </DataGridTemplateColumn>

                <DataGridTemplateColumn Header="StandardColorPicker">
                    <DataGridTemplateColumn.CellTemplate>
                        <DataTemplate>
                            <cp:StandardColorPicker ShowAlpha="True" />
                        </DataTemplate>
                    </DataGridTemplateColumn.CellTemplate>
                </DataGridTemplateColumn>

            </DataGrid.Columns>
        </DataGrid>

    </Grid>
</Window>

Thank you für your help

Addition:
The selected items will not work in this case.

Place the ColorPicker inside a Popup and try to use the color wheel. You will notice that the Popup will close like it whould if you clicked outside of the popup.

The RGB values next to the sliders are rounded to the nearest whole number (N0), but the RGB values in the hex string are obtained by rounding the original values down. Because of that, the RGB values next to the sliders are sometimes off by 1.

This will be fixed soon (in the next release).

Please add the ability to remove the background on the Border in the PortableColorPicker:
<Border.Background>

</Border.Background>

https://github.com/stevemonaco/ImageMagitek/tree/master/TileShop.WPF.Controls/PixiEditor.ColorPicker

The readme mentions the controls not being compatible with theming of some library, there might be a way to make them compatible.

Color property contains nested properties you may bind to or use to retrieve the color in code-behind:
Color.A: Current Alpha, a double ranging from 0 to 255
Color.RGB_R, Color.RGB_G, Color.RGB_B: Dimensions of the RGB color space, each is a 0-255 double
Color.HSV_H: Hue in the HSV color space, a 0-360 double
Color.HSV_S: Saturation in the HSV color space, a 0-100 double
Color.HSV_V: Value in the HSV color space, a 0-100 double
Color.HSL_H: Hue in the HSL color space, a 0-360 double
Color.HSL_S: Saturation in the HSL color space, a 0-100 double
Color.HSL_L: Lightness in the HSL color space, a 0-100 double

Reading this, I assumed "A double ranging from 0 to 255" to mean that the value in the number can be between 0.0 and 255.0.

In my application, I have colors and alpha saved as float ranging from 0 to 1. Reading the README for this color picker, my assumption was that I had to multiply these values by 255 to receive the values the color picker wants.

I could achieve that with the following:

        var color = new Color(); // Windows.Media
        color.ScA = W;
        color.ScR = X;
        color.ScG = Y;
        color.ScB = Z;
        var colorState = new ColorState();
        colorState.SetARGB(color.A, color.R, color.G, color.B);
        _colorState = colorState;

This would feed my 0-1 floats into a Color class, then spit them out as 0-255 bytes. This is what I assumed the ColorState wants, based on the description.

Yet in fact, I had to do this:

        var colorState = new ColorState();
        colorState.SetARGB(W, X, Y, Z);
        _colorState = colorState;

because, it seems, the color state actually expects a double from 0 to 1, not from 0 to 255.

No matter what I try the circular Hue slider in all controls is empty. Not filled with the colour range.

Errors:

I just followed the instructions on the main page. Am I missing something stupid? Apologies, I am relatively new to C#.

Edit:

Somehow I got past the above errors by restarting Visual Studio, but now It's telling me that it can't find the assembly. It's definitely imported and it exists in the path VS is expecting it to be at:

After this, I tried opening the demo solution and still run into the same issue.

XDG0008 The name "StandardColorPicker" does not exist in the namespace "clr-namespace:ColorPicker;assembly=ColorPicker".

Any help at all would be greatly appreciated

.

While the sliders for HSL/HSV use decimal values, RGB uses integers. Is it possible to add integer support for all sliders?