pixelrevision / ios_file_browser Goto Github PK

Hi, thanks for sharing the class, I'd just like to point out some problems I found while customizing it for use with my app:

• There is no option to list all file types (I added a nil or @"*" recognition for the file types filtering)
• All of your retained properties are leaking. On the dealloc you are using "property = nil", either you must [property release] or self.property = nil ...
• The delegate property should be a non-retaining property, else you create a retain cycle that will prevent the calling class to be released.
• The updateSizeForOrientation function does not take into account the FaceUp and FaceDown device orientations, normally I grab the UINavigationController's transform property to rely on the last interface orientation it had (navigationController.view.transform.a == 1 means portrait, 0 means landscape, -1 portrait upside down)
• browseForFile... sets the saveOption hidden , however its outlet won't be set until viewDidLoad (after presenting the dialog), had to change the visibility in viewDidLoad with saveOptions.hidden = (browserMode == kPXRFileBrowserModeLoad);
• The method fileShouldBeHidden doesn't take account for folders/files of name length == 1, thus trying to make a invalid substring with them and raising an exception

Regards!
nobre

Hi, we have been using the File browser for a while, but we have been doing some code auditting recently, and noticed your project does not state its distribution license, what would it be ? Can you please include it in the project Readme ?
I see your other site http://code.google.com/p/pixelrevisionutilities/ uses MIT license , is this also the case?
Our concern is wether your code can be used on a commercial application.

Thank you.
Rafael