pixelbo / pelco_and_arduino Goto Github PK

messFromCamera shold be instead raw_command; indeed, the command is properly sent, but wrong string is displayed in serial monitor:

Cam 1: Wrong checksum, updating to right checksum
Cam 1: sending message 00 00 00 00 00 00 00 

My Arduino compiler complains about a missing return statement at the end of the function:

e:\documenti\Arduino\libraries\Pelco_And_Arduino\src\PelcoBus.cpp: In member function 'bool PelcoBus::command(uint8_t, bool, uint8_t, uint16_t, uint8_t)':
e:\documenti\Arduino\libraries\Pelco_And_Arduino\src\PelcoBus.cpp:264:1: error: control reaches end of non-void function [-Werror=return-type]
  264 | }
      | ^
cc1plus.exe: some warnings being treated as errors

It's the closing bracket of "if (!disableACK) {"

Is disableAck working? I always get a "missing ack error", whatever value I specify, true or false.

Shouldn't this return "true" if disableAck is true?

Arduino compiler complains about possibly undefined value for "baud"; I think it depends on lack of "default" branch in switch/case above: after adding "default: baud = 2400;" the warning disappeared.

https://github.com/Pixelbo/Pelco_And_Arduino/blob/5c4c4367be48858c0e1fbb1efee25626cd4064a0/src/PelcoBus.cpp#L206C52-L206C66

I think messFromcamera should be ACKmessFromCamera

Noticed your Pelco-D command jpeg had call preset as "0x05" and clear preset as "0x07" but everywhere else I've seen the command list, 0x05 is clear preset and 0x07 is call preset.