pistonnoob / ai4u Goto Github PK

What steps will reproduce the problem?
1. launch the game
2. make a move

What is the expected output? What do you see instead?
second move is played by X again, instead of O.

The Minimax implementation only contains a one level implementation.
Extend it to get a depth threshold. 

I was looking at the code, and got a bit perplexed. The goal of the method 
is to return a random value from a given collection. It could all be summed 
in a line reading:

return collection[nextInt(collection.size())];

Or in more lines, if iterators are used. But the loop was there in between 
the really necessary lines of code. It seemed to me then that the entire 
purpose of the loop is to add randomness to the method, but it does so in a 
confusing manner. Since it is very unclear from reading the loop how long 
it will run.
When I tried to calculate the amount of steps of the loop they seemed to me 
random by themselves. The chance that the loop will stop at the next step 
is bigger from the previous by a constant factor.

My point is that if the entire purpose of the loop is to add more 
randomness to the method, why not create a simpler one or skip it 
altogether as is done in the other pickRandom method?