pipe-cd / pipecd Goto Github PK

https://github.com/pipe-cd/pipe/blob/6425e845f75a3354a011efd74ab2a57eff141b1d/pkg/app/piped/executor/analysis/analysis.go#L295-L298

This was created by todo plugin since "TODO:" was found in https://github.com/kapetaniosci/pipe/commit/6425e845f75a3354a011efd74ab2a57eff141b1d when #183 was merged. cc: @nakabonne.

https://github.com/pipe-cd/pipe/blob/5ca20f87efa515622280dec0d97d09126f5ad1ce/pkg/app/api/api/piped_api.go#L152-L154

What would you like to be added:

Why is this needed:

/assign @nghialv
/label area/piped

What would you like to be added:

Why is this needed:

/assign @nghialv

What would you like to be added:

• Looking into how Kayenta compares: https://www.spinnaker.io/guides/user/canary/judge/
• Read thoroughly the Experiment feature of Argo: https://argoproj.github.io/argo-rollouts/features/experiment
  • How to use Kayenta?
• Thinks about time-series database
  • Does Kayenta support only the metrics providers having time-series database?
• https://docs.harness.io/article/trmrvs1egp-why-cv#static_rules_versus_dynamic_data

Why is this needed:

https://github.com/pipe-cd/pipe/blob/4df6a870e92095686ea8181f1e2dc4673a21798c/pkg/app/piped/executor/kubernetes/canary.go#L186-L189

This was created by todo plugin since "TODO:" was found in 4df6a87 when #122 was merged. cc: @nghialv.

What would you like to be added:

Why is this needed:

/assign @nghialv
/label area/piped

実際のユースケースに近いクエリで検証

• container_cpu_usage_seconds_total
• カスタムクエリ色々書く

What would you like to be added:
We can pre-define it because queries for Istio are fixed.

Refer to the following order when templates are specified:

• custom template
• built-in template

Why is this needed:

What would you like to be added:

Executor

• Primary Variant
• Canary Vairant
• Baseline Variant
• PlainYAML
• Helm
• Kustomize
• Rollback

Planner

• Decide pipeline based on commit changes
• Register rollback executor

Why is this needed:

/assign @nghialv
/label area/piped

https://github.com/pipe-cd/pipe/blob/4df6a870e92095686ea8181f1e2dc4673a21798c/pkg/app/piped/executor/kubernetes/canary.go#L185-L188

This was created by todo plugin since "TODO:" was found in 4df6a87 when #122 was merged. cc: @nghialv.

What would you like to be added:

Why is this needed:

https://github.com/pipe-cd/pipe/blob/e539348803f376ac6ac45a12cd2694ca22974616/pkg/app/api/api/piped_api.go#L178-L181

Image Watcher lets us spawn Deployment when an image tag stored at a container registry is udpated.

What would you like to be added:

Why is this needed:

What would you like to be added:

Why is this needed:

/assign @nghialv
/label area/piped

https://github.com/pipe-cd/pipe/blob/c7fa9f48c8b151dc0790b9e7d2ae055632db53b1/pkg/config/deployment.go#L279-L282

What would you like to be added:

• Register metrics from each piped components
• Collect piped metrics
• Send metrics to control-plane

Why is this needed:

https://github.com/pipe-cd/pipe/blob/994783652c4e3bd0f958ae59e42bd7e6ea723f50/pkg/app/web/src/pages/applications/detail.tsx#L26-L29

This was created by todo plugin since "TODO:" was found in 9947836 when #76 was merged. cc: @cakecatz.

What would you like to be added:

Why is this needed:

What would you like to be added:

• TLSの設定
• IAPの設定
• Ingress, BackendConfig, Serviceの設定

Why is this needed:

What would you like to be added:
https://github.com/pipe-cd/pipe/tree/master/pkg/app/api/service/pipedservice

PipedService

• Ping
• ReportPipedMeta
• ListApplications
• ReportApplicationSyncState
• ReportMostRecentSuccessfulDeployment
• ListNotCompletedDeployments
• GetMostRecentDeployment
• CreateDeployment
• ReportDeploymentPlanned
• ReportDeploymentStatusChanged
• ReportDeploymentCompleted
• SaveDeploymentMetadata
• SaveStageMetadata
• ReportStageLogs
• ReportStageLogsFromLastCheckpoint
• ReportStageStatusChanged
• ListUnhandledCommands
• ReportCommandHandled
• ReportApplicationLiveState
• ReportApplicationLiveStateEvents

Why is this needed:

What would you like to be added:
It could be thought tough to perform adequate load testing with the current analysis by HTTP provider alone.

HTTP:

• https://github.com/rakyll/hey
• https://github.com/tsenart/vegeta

gRPC:

• https://github.com/bojand/ghz

• https://github.com/lotusload/lotus

Why is this needed:

What would you like to be added:

Why is this needed:

https://github.com/pipe-cd/pipe/blob/f195b7815ff8e51802a2642264d94a9a56defcd1/pkg/rpc/rpcauth/interceptor.go#L133-L136

This was created by todo plugin since "TODO:" was found in f195b78 when #108 was merged. cc: @nghialv.

What would you like to be added:

Why is this needed:

What would you like to be added:

• Docs
• Workload
• LB, Domain, TLS

Why is this needed:

https://github.com/pipe-cd/pipe/blob/0f129c7862c269bbe51b0411eed23f462c337cee/pkg/app/api/stagelogstore/filestore.go#L72-L75

https://github.com/pipe-cd/pipe/blob/a620bb73de0566b1ba0880630098e9ef1aadaa25/pkg/app/api/api/web_api.go#L198-L200

What would you like to be added:

Why is this needed:

What would you like to be added:
It currently has no way to re-sync the latest commit history after the repository is force updated. We need to provider two features like:

• Show clear messages what's happened
• A way to refresh commit history of the repo

Why is this needed:
It would be important to provide options for repair while telling them that it's abnormal.

What would you like to be added:

Why is this needed:

https://github.com/pipe-cd/pipe/blob/8f8bdfbf91a15db75656cc5bc1acb026cd739759/pkg/app/web/src/components/log-viewer.tsx#L63-L66

This was created by todo plugin since "TODO:" was found in 8f8bdfb when #43 was merged. cc: @cakecatz.

What happened:
Despite the app whose id is pipecd:dev:kubernetes-analysis-by-metrics-nakabonne obviously exists, Firestore emits Not found error.

log:

10:00:14	failed to report application sync state	{"application-id": "pipecd:dev:kubernetes-analysis-by-metrics-nakabonne", "state": {"status":3,"short_reason":"There are 1 missing manifests and 2 redundant manifests.","reason":"There are 1 missing manifests- v1:Service:default:analysis-by-metricsThere are 2 redundant manifests- apps/v1:Deployment:default:analysis-by-metrics-canary- v1:Service:default:analysis-by-metrics","timestamp":1592442014}, "error": "rpc error: code = InvalidArgument desc = application is not found"}

Occurred at:
https://github.com/pipe-cd/pipe/blob/9619d29c35d00999d32379509abaf55f4a491512/pkg/datastore/firestore/firestore.go#L189-L193

What you expected to happen:

How to reproduce it:

Environment:

• Kubernetes version (use kubectl version):
• Cloud provider or hardware configuration:
• OS (e.g. from /etc/os-release):
• Others:

https://github.com/pipe-cd/pipe/blob/2248e90545ee17c0d023e08381281fbd3c727ffe/pkg/app/api/api/piped_api.go#L376-L379

This was created by todo plugin since "TODO:" was found in 2248e90 when #24 was merged. cc: @stormcat24.

What would you like to be added:
canary variantに対してクエリを投げるために、Analysis configからcanary variantを識別できるようにする必要がある。
つまり、pod label pipecd.dev/variant=canary を使ってクエリをフィルタリングする必要がある。それをユーザーに任せる。

ユーザーに任せるメリット

• canaryとprimaryを比較するようなクエリなども自由に書ける
• k8s pod labelでフィルタリングするのは少し複雑になるため、任せたほうがシンプルになる

TODO:

• ArgoとFlaggerがどのように識別してるか調査
• {{ .Labels.CanaryPod }}などで参照できるように
• Deployment configから直接使いたいため、AnalysisTemplate以外でもGo Template Engineを使えるようにする？

Why is this needed:

https://github.com/pipe-cd/pipe/blob/7473eec8936a5aa72639899c92cda16438736137/pkg/app/piped/planner/kubernetes/kubernetes.go#L95-L100

This was created by todo plugin since "TODO:" was found in d43aa40 when #143 was merged. cc: @nghialv.

https://github.com/pipe-cd/pipe/blob/2248e90545ee17c0d023e08381281fbd3c727ffe/pkg/app/api/api/piped_api.go#L377-L379

This was created by todo plugin since "TODO:" was found in 2248e90 when #24 was merged. cc: @stormcat24.

What would you like to be added:

Why is this needed:

What would you like to be added:
https://pipecd.dev/docs/user-guide/configuring-deployment/lamda/

Why is this needed:

What would you like to be added:

Why is this needed:

What would you like to be added:

Why is this needed:

https://github.com/pipe-cd/pipe/blob/c7fa9f48c8b151dc0790b9e7d2ae055632db53b1/pkg/app/piped/analysisprovider/http/http.go#L66-L69

Idea1

Compare with the specific value in the JSON body, like Argo Rollouts: https://argoproj.github.io/argo-rollouts/features/analysis/#web-metrics

          https:
            - url: https://canary-endpoint.dev
              method: GET
              expectedCode: 200
              expectedValue: true
              jsonPath: "{$.results.ok}"

Pros:

• simple

Cons:

• The response must be JSON format

links

• https://argoproj.github.io/argo-rollouts/features/analysis/#web-metrics
• https://flagger.app/usage/webhooks.html

This was created by todo plugin since "TODO:" was found in https://github.com/kapetaniosci/pipe/commit/8e251542d85152397e9b0c5e9025e76d98090e65 when #141 was merged. cc: @nakabonne.

What would you like to be added:
https://github.com/pipe-cd/pipe/tree/master/pkg/app/api/service/webservice

Environment

• AddEnvironment
• UpdateEnvironmentDesc
• ListEnvironments

Piped

• RegisterPiped (p2)
• DisablePiped
• ListPipeds
• GetPiped

Application

• AddApplication (p2)
• DisableApplication
• ListApplications (p2)
• SyncApplication
• GetApplication

Deployment

• ListDeployments (p2)
• GetDeployment (p1)
• GetStageLog (p1)
• CancelDeployment
• ApproveStage

ApplicationLiveState

• GetApplicationLiveState (p1)

Account

• GetProject
• GetMe

Command

• GetCommand

Why is this needed:

https://github.com/pipe-cd/pipe/blob/507722f42602019c46f023efc8ec15a58539bae8/pkg/app/api/api/piped_api.go#L224-L227

This was created by todo plugin since "TODO:" was found in 507722f when #85 was merged. cc: @stormcat24.

What would you like to be added:
Currently, if there is even one error log then it fails. Consider if it's really enough.

Why is this needed:

What would you like to be added:

Why is this needed:

What would you like to be added:

Why is this needed:

https://github.com/pipe-cd/pipe/blob/4df6a870e92095686ea8181f1e2dc4673a21798c/pkg/app/piped/executor/wait/wait.go#L46-L49

This was created by todo plugin since "TODO:" was found in 4df6a87 when #122 was merged. cc: @nghialv.

https://github.com/pipe-cd/pipe/blob/2248e90545ee17c0d023e08381281fbd3c727ffe/pkg/app/api/api/piped_api.go#L375-L378

This was created by todo plugin since "TODO:" was found in 2248e90 when #24 was merged. cc: @stormcat24.