Add site field on models.py about django-mailer HOT 3 CLOSED

What specific issue do you have? Why does Message need to have a connection to Site at all? The API it implements (sending of email) doesn't use the Sites framework, so it's difficult to see how this could be implemented, or why it is wanted. See https://docs.djangoproject.com/en/1.6/topics/email/#django.core.mail.send_mail - it doesn't accept a Site instance.

from django-mailer.

I have got multiple sites and I want to specified messages for which site it is.

It gives more flexibility to know from wich site messages are going or filter for specific site.

Implementation is not that difficult just adding fields on models.py check the way django comments or redirects frameworks are done.

Its just enhancement not specific issue.

from django-mailer.

The only way of populating a 'site' field on Message, MessageLog etc. is if you are manually constructing instances of those models yourself. However, that isn't public API. The public API is:

• setting EMAIL_BACKEND to "mailer.backend.DbBackend"
• or, changing imports to using from mailer import sendmail

With either of these, it's impossible to pass in the site object. Having a Message.site field is only going to be useful if we made the Message model a public API.

So, on that basis, I don't think this is an enhancement we want to do.

Sorry!

from django-mailer.