Code Monkey home page Code Monkey logo

Comments (7)

spookylukey avatar spookylukey commented on September 25, 2024 1

You can always pip install from a git repo - https://adamj.eu/tech/2019/03/11/pip-install-from-a-git-repository/

from django-mailer.

spookylukey avatar spookylukey commented on September 25, 2024

Re-opening until I address this.

Current blockers:

from django-mailer.

GabrielNexT avatar GabrielNexT commented on September 25, 2024

Spooky, I have a problem at the company I work for, a momentary delay in sending some emails, have you ever had a similar problem? It happened on an old project, I suspect that the email queue got too big and the mailer couldn't send them all quickly.

Testing the app, I noticed that it doesn't really send emails very quickly and looking at the code, I got to the function

def send_all():

I'm not a python master but it seems to me that this function is sequential, wouldn't it be better to parallel it?

I'm thinking of a solution and maybe do a PR.

from django-mailer.

spookylukey avatar spookylukey commented on September 25, 2024

Sending emails will take time, because the data has to go over the network. How long was the delay, how many emails were there and how big were they?

Sending them in parallel may make things faster, but if you try to do too many in parallel almost certainly you will cause problems and could actually make things go slower, because of network congestion and the way the server might respond. In some cases, you could get throttling errors (e.g. if you backend was an HTTP API, which many people are using now).

So, overall, the change might not be worth it. We should also not that doing it in parallel will require multiple process or multiple threads, which can be a very tricky thing in this context, and would introduce a significant amount of fragility.

from django-mailer.

GabrielNexT avatar GabrielNexT commented on September 25, 2024

I don't know exactly how many emails were in the queue, but in some cases it took a few minutes to send the emails.
We currently use Sendgrid SMTP.

Thanks for the explanations.
All my doubts were resolved, whenever you want, you can close the issue.

from django-mailer.

syre avatar syre commented on September 25, 2024

Now that #152 is merged, perhaps a new release can be made?

from django-mailer.

spookylukey avatar spookylukey commented on September 25, 2024

2.2 has been released now.

from django-mailer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.