piecemaker / recipe-api Goto Github PK

The test titled it should search using "like" comparison currently performs an identity check. It sorts two recipe arrays and then compares them. However, it sorts and compares the same array. It never sorts and compares the recipes returned from the API request.

Tests need to run and pass in GitHub before PRs can be merged. Since MongoDB is required for the tests, MongoDB GitHub actions need to be explored.

https://github.com/marketplace/actions/mongodb-in-github-actions

The API is intended to return Recipe objects, which have id as the identifier. However, the API is currently returning MongoRecipe objects, which have _id as the identifier.

Multiple functions were added to the API test spec to streamline test writing. However, all of these functions have been added to the top of the spec file and it is starting to get cluttered. These functions need to be moved to a test utility file.

The RecipeRA.search method is supposed to paginate results. The function definition even expects this by accepting a page argument. However, this argument was never implemented.

Pagination needs to be implemented by using the page argument and the .skip() Mongo function.