piacarrot / pokeorange Goto Github PK

The one in Navel Rock is immobile. I tried compiling the commit when it was added, 015688d, but the bug was already present then.

sorry, github is making me jump through too many hoops to send you a one line change, and honestly, fuck github, however, i think this is a bug and here is a fix

dmitrygr@vwm:/tmp/pokeorange$ git show
commit 1530dfb10b4bbe587864b3fb3da0e2496c5f0526 (HEAD -> master)
Author: Dmitry Grinberg <[email protected]>
Date:   Tue Feb 6 23:13:55 2024 -0600

    Fix bug on copying <16 1bpp tiles when display is past line 135
    
    If Get1bpp() is called with the display on, it will call Request1bpp()
    If the current display line is >= 0x88, it'll fall through to ".loop"
    As there are fewer than 16 tiles requested, it'll jump to
    ".copyRemainingTilesAndExit". There it'll set up for the copy in VBLANK
    and then wait for the irq to happen, BUT, hRequested1bpp is never set
    to the proper number of tiles, instead that val is written to hTilesPerCycle
    by error (and immediately overwritten). The VBLANK IRQ does nothing,
    DelayFrame() returns, and no copy happened.
    
    I suspect this was a typo or a copy-and-paste error. The fix is trivial

diff --git a/home/copy.asm b/home/copy.asm
index e376aa0e..b616b439 100644
--- a/home/copy.asm
+++ b/home/copy.asm
@@ -256,7 +256,7 @@ Request1bpp:: ; f1e
        jr nz, .copySixteenTilesAndContinue
 .copyRemainingTilesAndExit
        add 16
-       ld [hTilesPerCycle], a
+       ld [hRequested1bpp], a
        xor a
        ld [hTilesPerCycle], a
        call DelayFrame
@@ -378,4 +378,4 @@ WriteVCopyRegistersToHRAM:
        ld [hRequestedVTileDest + 1], a
        ld a, c
        ld [hTilesPerCycle], a
-       ret
\ No newline at end of file
+       ret

The link to “Aizawa's Discord server“ doesn’t work, “The invite link is invalid or has expired”.

I tried running the make command in the terminal, but it outputs:

`gcc -O3 -flto -std=c11 -o tools/lzcomp tools/lz/global.c tools/lz/main.c tools/lz/merging.c tools/lz/mpcomp.c tools/lz/nullcomp.c tools/lz/options.c tools/lz/output.c tools/lz/packing.c tools/lz/repcomp.c tools/lz/spcomp.c tools/lz/uncomp.c tools/lz/util.c
gcc -O3 -o tools/scan_includes tools/scan_includes.c

sort pokeorange.sym -o pokeorange.sym
Input file specified two times.

make: *** [Makefile:65: orange] Error 1`

I installed exactly the 0.5.2 version of rgbds, but neither that nor newer versions work.

P.S.: i run windows 10 64 bits

It seems like there is a problem with the current version of rgbs:
python dedenc.py audio/ded/dragalge.wav audio/ded/dragalge.ded
make: python: No such file or directory
make: *** [Makefile:121: audio/ded/dragalge.ded] Error 127

It turns the screen white and immediately goes back to the Pack.

HI, loving the hack!

I was wondering if you've thought about adding pokerides instead of having HMs? This should free up a slot on the team without an HM slave.

Squirtle sprite in battle is Poliwhirl.

The INSTALL.md for building on Windows in Cygwin states that the package "python" is needed. The Cygwin Setup is telling me that "python" has been obsoleted by "python2". Is the original "python" package actually needed, or are we good to just use "python2" like Cygwin wants us to?