Adding RRest about physiozoo HOT 7 OPEN

@peterhcharlton any feedback on this?

from physiozoo.

from physiozoo.

@peterhcharlton Thanks for your feedback.

Ok, so I will begin by restructuring the project into two packages and incorporate your code.
Later on, after that works and you can maintain it without issue, we'll focus on adding documentation for RRest you our documentation generator.

from physiozoo.

Hi,

My apologies, I haven't understood what you meant by "restructuring the project" - would you mind passing on further details? I am hoping to make time this week to get the code running with some example data, as discussed previously.

Best wishes,

Pete

from physiozoo.

I meant split the physiozoo code into two matlab packages, one for hrv and for respiration.
This will prevent name collisions an confusion about what RR is. It also means that users will need to call the code with the package name, e.g. mhrv.ecgrr(...) instead of just ecgrr(...).
(see also example in my first message in this thread).

I haven't yet got around to doing this ...

from physiozoo.

That sounds like a good idea. It will also make it easier to add further packages in the future.

I'll try to update you on my progress over the coming days

Thanks,

Pete

from physiozoo.

Hi @peterhcharlton,
I'm done restructuring and project.
Sorry for the delay. I also had to fix the documentation generator to work with the new package-based structure so it took a bit longer than I thought as there were some technical issues.

The new structure is in the package branch and i created a new PR (#8) to track the changes and progress.

You can now look at that branch and see what you need to do. Basically:

• add your code under lib/resp.
• add a new section in the documentation (just copy what mhrv is doing there). I will gladly help if you have questions about this.

You can add your changes to the package branch and we can discuss them on the PR page (#8).

Thanks again.

from physiozoo.