Translations from other tables are lost about ios-sdk HOT 11 CLOSED

@h-leroy-betclic Thank you for your report. We need to investigate your use case a bit more to provide a solution for this, too. Keeping you updated here.

@theSoenke I think this might be a new issue which is quite different from our common use case.

from ios-sdk.

Hi @h-leroy-betclic, which version of the SDK are you currently using? Could you check with the latest SDK 4.1? https://github.com/phrase/ios-sdk/releases/tag/4.1.0 The issue with multiple tables should be resolved in the version 4.1

from ios-sdk.

Hi @theSoenke, @winkelsdorf, yes it's on 4.1.0.
The difference i notice from this issue #50 is the problem happens after the first sync has been done (not setup).

from ios-sdk.

@theSoenke, @winkelsdorf do you reproduce the issue ?
For information, we have postponed OTA feature delivery (again), so the fix is very expected.
Thank's

from ios-sdk.

Hi @h-leroy-betclic, I'm sorry for the inconvenience and causing the delay in rolling out OTA. We're now looking into this and expect to have a solution in the next 1-2 weeks. I'll keep you posted here once there as soon as there is an update.

from ios-sdk.

@theSoenke , @winkelsdorf any news ?

from ios-sdk.

@h-leroy-betclic unfortunately no update yet. We will need a few more days to tackle this

from ios-sdk.

@h-leroy-betclic I was able to identify a problem related to the fallback to the iOS main bundle and there will be an update for it in a couple of days.

We ensured the following will be working:

• Downloading a translation for the Main Bundle and use it using either with
  a) Phrase.shared.localizedString or
  b) the swizzled methods Bundle.main.localizedString / NSLocalizedString
  (In both cases with table set to nil or Localizable)
• If the swizzled methods are unable to retrieve a translation, they will fallback to iOS default behavior, internally using localizedString(forKey: key, value: value, table: tableName) on the Main bundle, thus keeping your table Parameter. Phrase.shared.localizedString will just return nil to allow implementing a custom fallback logic.

This allows us to support different scenarios:

• Providing translations for the Main Bundle, but fall back to shipped Main Bundle translations automatically (when using the swizzled methods as outlined above)
• Do not interfere with different tables

Support for downloading translations for different tables and/or translating for them unfortunately is something we currently don't support. Please see the last comment in #25.

cc @theSoenke

Edit: Related to #50

from ios-sdk.

@theSoenke , @winkelsdorf any news ??

from ios-sdk.

@h-leroy-betclic Thank you for your patience. We have just released a new release that addresses the issue (v4.2.0). We are looking forward to your feedback!

from ios-sdk.

Closed, as very likely fixed. Feel free to reopen if there are comments.

from ios-sdk.