Comments (11)
@h-leroy-betclic Thank you for your report. We need to investigate your use case a bit more to provide a solution for this, too. Keeping you updated here.
@theSoenke I think this might be a new issue which is quite different from our common use case.
from ios-sdk.
Hi @h-leroy-betclic, which version of the SDK are you currently using? Could you check with the latest SDK 4.1? https://github.com/phrase/ios-sdk/releases/tag/4.1.0 The issue with multiple tables should be resolved in the version 4.1
from ios-sdk.
Hi @theSoenke, @winkelsdorf, yes it's on 4.1.0.
The difference i notice from this issue #50 is the problem happens after the first sync has been done (not setup).
from ios-sdk.
@theSoenke, @winkelsdorf do you reproduce the issue ?
For information, we have postponed OTA feature delivery (again), so the fix is very expected.
Thank's
from ios-sdk.
Hi @h-leroy-betclic, I'm sorry for the inconvenience and causing the delay in rolling out OTA. We're now looking into this and expect to have a solution in the next 1-2 weeks. I'll keep you posted here once there as soon as there is an update.
from ios-sdk.
@theSoenke , @winkelsdorf any news ?
from ios-sdk.
@h-leroy-betclic unfortunately no update yet. We will need a few more days to tackle this
from ios-sdk.
@h-leroy-betclic I was able to identify a problem related to the fallback to the iOS main bundle and there will be an update for it in a couple of days.
We ensured the following will be working:
- Downloading a translation for the Main Bundle and use it using either with
a)Phrase.shared.localizedString
or
b) the swizzled methodsBundle.main.localizedString
/NSLocalizedString
(In both cases with table set tonil
orLocalizable
) - If the swizzled methods are unable to retrieve a translation, they will fallback to iOS default behavior, internally using
localizedString(forKey: key, value: value, table: tableName)
on the Main bundle, thus keeping yourtable
Parameter.Phrase.shared.localizedString
will just returnnil
to allow implementing a custom fallback logic.
This allows us to support different scenarios:
- Providing translations for the Main Bundle, but fall back to shipped Main Bundle translations automatically (when using the swizzled methods as outlined above)
- Do not interfere with different tables
Support for downloading translations for different tables and/or translating for them unfortunately is something we currently don't support. Please see the last comment in #25.
cc @theSoenke
Edit: Related to #50
from ios-sdk.
@theSoenke , @winkelsdorf any news ??
from ios-sdk.
@h-leroy-betclic Thank you for your patience. We have just released a new release that addresses the issue (v4.2.0). We are looking forward to your feedback!
from ios-sdk.
Closed, as very likely fixed. Feel free to reopen if there are comments.
from ios-sdk.
Related Issues (20)
- [Binary upload error] Multiple binaries with same code sign path HOT 3
- unchecked "use default language as locale" setting in OTA doesn't work HOT 2
- Two languages being returned when using "localeOverride" HOT 12
- Planning for OTA SwiftUI support? HOT 3
- String is not localised when running test plan with multiple configs HOT 4
- Preferred language automatically switch to Localization native development region HOT 5
- Xcode 14 preview error HOT 3
- tableName parameter is ignored, Phrase always returns from Localizable HOT 9
- New strings values are not available on updateTranslation completion handler HOT 11
- Can we get a new "Example App" HOT 3
- Latencies after switching from 4.0.1 to 4.1.0 HOT 7
- Configure OTA with two different distributions HOT 3
- Support mac catalyst
- Support mac catalyst HOT 3
- Phrase App Inconsistency update error HOT 7
- Malformed Archive Error and SPM Compatibility Issue HOT 5
- Add Privacy Manifest file to library if needed HOT 5
- Phrase OTA on iOS native project, with KMP moko library HOT 3
- Fallback issue when using `Phrase.shared.localizedString` HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ios-sdk.