Comments (9)
Hi @winkelsdorf, could you maybe take a look at this issue and whether the behavior between the versions changed? Thanks!
from ios-sdk.
Hey @winkelsdorf @theSoenke . Why was the ticket closed? I did not have a chance to reply yet.
Regarding your question I may give you more details and clarify your question.
Our app has two tables.
- Localizable.strings
- Localizable-Tenant.strings
Both tables are available in for DE and EN.
We access the values as follows:
if let value = NSLocalizedString("key", tableName: "Localizable-Tenant", value: "", comment: "") {
return value
} else if let value = NSLocalizedString("key", tableName: "Localizable", value: "", comment: "") {
return value
}
The key exists in both tables.
Before calling setup of Phrase, the logic above returns the values as wanted, here from Localizable-Tenant.
After calling setup, the first NSLocalizedString(...) still returns a value. But the value / string returned is from the Localizable table. This has led us to believe that tableName is ignored.
Additionally, for some of our apps there is only Localizable-Tenant. Here, after setup, no value is returned.
I hope the explanation helped and we kindly ask to reopen the ticket.
from ios-sdk.
Hi Tobias,
Thanks for reaching out to us.
We'll look into this and get back to you as soon as possible accordingly.
Donβt hesitate to reach out again in case needed in the meantime, and have a great week ahead!
Best,
Erika from the Phrase Technical Support Team
Comment by Erika
from ios-sdk.
@honkmaster Thank you for your issue report. We're currently re-evaluating the new logic to fit your needs, too.
I'll keep you updated here.
from ios-sdk.
Thanks!
This ticket will reopen whenever you reply to it with any further questions or feedback.
Have a great week ahead.
Best,
Erika from the Phrase Technical Support Team
Comment by Erika
from ios-sdk.
@honkmaster Could you please provide more information about your Bundle/Table Setup?
Using another Table e.g. OtherTable.strings
I was able to access the strings using the swizzled method.
let otherTableValue2 = NSLocalizedString("othertable_test_key", tableName: "OtherTable", value: "", comment: "")
debugPrint("Other table", otherTableValue2)
That returned my value from the other Table correctly.
Am I right that you want to translate keys that might exist in both tables? In the example you would have a othertable_test_key
in the OTA release and your other tables, too?
from ios-sdk.
@honkmaster Sorry, that happened automatically by referencing it from our upcoming Release. Looking into your details later and giving you an update.
from ios-sdk.
Thank you for the valuable input! We were able to fix the underlying issue and going to release later today. That said: Your custom tenant will work, but the Phrase OTA SDK only supports translating the Main Bundle (i.e. Localizable.strings
). But it will not interfere with custom Tables anymore.
from ios-sdk.
@honkmaster Release 4.1.0 has just been published. Please check if your problem has been solved, I am looking forward to your feedback.
from ios-sdk.
Related Issues (20)
- Code signing fail when adding as sub-dependency HOT 5
- Provide DSYM files for xcframework HOT 1
- Preferred language is ignored HOT 10
- [Binary upload error] Multiple binaries with same code sign path HOT 3
- unchecked "use default language as locale" setting in OTA doesn't work HOT 2
- Two languages being returned when using "localeOverride" HOT 12
- Planning for OTA SwiftUI support? HOT 3
- String is not localised when running test plan with multiple configs HOT 4
- Preferred language automatically switch to Localization native development region HOT 5
- Xcode 14 preview error HOT 3
- New strings values are not available on updateTranslation completion handler HOT 11
- Can we get a new "Example App" HOT 3
- Translations from other tables are lost HOT 11
- Latencies after switching from 4.0.1 to 4.1.0 HOT 7
- Configure OTA with two different distributions HOT 3
- Support mac catalyst
- Support mac catalyst HOT 3
- Phrase App Inconsistency update error HOT 7
- Malformed Archive Error and SPM Compatibility Issue HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ios-sdk.