phpro / annotated-cache Goto Github PK

Phpro\AnnotatedCache\Interceptor\CacheableInterceptor::interceptSuffix returns Cache\Adapter\Common\CacheItem;

but Symfony\Component\Cache\Adapter interacts only with Symfony\Component\Cache\CacheItem otherwise will skip save to cache

@see Symfony\Component\Cache\Adapter\AbstractAdapter::save()

    public function save(CacheItemInterface $item)
    {
        if (!$item instanceof CacheItem) {
            return false;
        }
        $this->deferred[$item->getKey()] = $item;

        return $this->commit();
    }

Or there should be fix on Symfony side in this method?

Edit: Symfony is logging some debug info via static method CacheItem::log, thats missing in standardized Cache\Adapter\Common\CacheItem;

Edit2: I have created new SymfonyInterceptor
https://github.com/insekticid/phpro-annotated-cache-symfony-cache

Hi there,

Nice looking library. I want to give it try. But I'm new to all the PSR-6 cache handling. So maybe I just didnt understand something about that yet...

Lets say I have a service with 2 methods, each method is a getSomething($key), so I annotate them like this:

/**
 * @Cacheable(pools="products")
 */
public function hasProduct($productCode)
{
...
}

/**
 * @Cacheable(pools="products")
 */
public function getProductName($productCode)
{
....
}

I want to have all arguments as the key, so I omit the key="" attribute. Why is it that even if I use different pools for both methods that I end up having only one key written in my cache backend (which is redis). I thought that the method's name is taken into account when generating the key, or at least the pool's name...

I'm stuck :(

Your code looks awesome and its definitely a better implementation than the one from https://github.com/TheBigBrainsCompany/TbbcCacheBundle (which is also good)

Thanks for any hint
Markus