phpcsstandards / phpcsdevtools Goto Github PK

The phpcsdoc.xsd schema does not conform to v1.0 of the XML schema spec because of the wildcard in the rulegroup Model Group.

Since the schema has no targetNamespace, the element wildcard in that model group (<xs:any minOccurs="0"/>), as written, violates the Unique Particle Attribution constraint (since the wildcard could potentially match any unqualified element, including those specifically named in the model group).

XML Schema 1.1 loosened UPA so that wildcard is OK as specified provided that a v1.1 schema processor is used.

Since there are not that many v1.1 schema processors out there (especially in PHP, and most IDEs), it would probably be a good idea to modify the schema to conform to v1.0 of the schema spec.

I have some other suggestions for improvements to the schema, but it would be a good idea to have some general discussions around the "goals" of the schema (and validation in general) before jumping into opening a PR.

Note: I came across the schema when I saw WordPress/WordPress-Coding-Standards#2084.

The current develop branch contains quite some changes, some which are ready (overdue) for release, others which aren't ready for release yet.

Ready for release

• PHPCS Docs XSD and everything related to that, see #80.
• Debug sniff whitespace visualization changes.
• Some minor tweaks/bugfixes for the FeatureComplete tool.

Not ready for release

• Refactor of the FeatureComplete tool.
  There are still some issues with:
  • The use of STDOUT vs STDERR.
  • The exclude feature not working well enough.

As what is ready for release is valuable to get out there, I'm cherrypicking those commits into the stable branch and adding the changelog and such to allow for a release.
All cherrypicked PRs have been re-milestoned to 1.2.0.

As this means I will be pushing the cherrypicked commits and the changelog directly to stable, I'm opening this issue to document the release steps.

Release checklist:

• Update the version number in the VERSION file.
• Add changelog for 1.2.0.
• Merge this PR
• Add release tag against stable (careful, GH defaults to develop!) & copy & paste the changelog to it
• Close the milestone
• Open a new milestone for the next release
• If any open PRs/issues which were milestoned for this release did not make it into the release, update their milestone. (not applicable)
• Tweet about the release.
• Fast-forward develop to stable & push it. Back-merge stable to develop & push it.

A lot of repos for external PHPCS standards will need similar build scripts for Travis.

Since last week Travis now offers the ability to import re-usable Travis script snippets.

It may be useful to offer some typical snippets needed in Travis scripts for external PHPCS standards as a new feature in this repo.

Refs:

• https://blog.travis-ci.com/2019-11-11-build-config-imports
• http://docs.travis-ci.com/user/build-config-imports