photo / openphoto-ruby Goto Github PK

View Code? Open in Web Editor NEW

14.0 14.0 0.0 104 KB

A Ruby OAuth client for OpenPhoto

Home Page: http://theopenphotoproject.org

Ruby 100.00%

openphoto-ruby's People

Contributors

Stargazers

Watchers

openphoto-ruby's Issues

Method GET and params

Is it normal that, as opposed to POST, the GET method doesn’t take parameters in the params hash?

client.connect( :get, '/hello.json', { 'foo' => 'bar' } ).json
# => {"message"=>"Hello, world!", "code"=>200, "result"=>{"__route__"=>"/hello.json"}} 

client.connect( :get, '/hello.json?foo=bar' ).json
# => {"message"=>"Hello, world!", "code"=>200, "result"=>{"__route__"=>"/hello.json", "foo"=>"bar"}}

Require either a dotfile or -c / --config file for secrets

See openphoto/openphoto-python#5

Invalid JSON response when running example code

I'm running the example code, having defined @site as "http://trovebox.com" and all other instance variables as required. I have an account on trovebox and generated all tokens.

require 'rubygems'
require 'openphoto-ruby'

@client = Openphoto::Client.new(@site, @consumer_key, @consumer_secret, @access_token, @access_token_secret)
photo = @client.connect(:post, "/photo/upload.json", {"photo"=>"/tmp/photo.png", "permission"=>"1", "title"=>"test upload"})
puts "#{photo.message} #{@site}/photo/#{photo.result["id"]}/view"

I get the following error:

[rekado@mango openphoto-ruby]$ bundle exec ruby test-upload.rb 
/home/rekado/dev/openphoto-ruby/vendor/ruby/1.9.1/gems/json-1.7.6/lib/json/common.rb:155:in `initialize': A JSON text must at least contain two octets! (JSON::ParserError)
    from /home/rekado/dev/openphoto-ruby/vendor/ruby/1.9.1/gems/json-1.7.6/lib/json/common.rb:155:in `new'
    from /home/rekado/dev/openphoto-ruby/vendor/ruby/1.9.1/gems/json-1.7.6/lib/json/common.rb:155:in `parse'
    from /home/rekado/dev/openphoto-ruby/lib/openphoto-ruby.rb:50:in `json'
    from /home/rekado/dev/openphoto-ruby/lib/openphoto-ruby.rb:54:in `result'
    from test-upload.rb:25:in `<main>'

It appears that the result is empty, so the parse fails. Are there any obvious problems with the code?

Use multipart post for upload

The library currently encodes the image inline as base64 in the post data.
It would be better to send a multipart/related request instead.

One way to do it would be to add an upload method, eg:

module Openphoto
  require 'net/http/post/multipart'

  class Client
    def upload photo, params = {}
      params["photo"] = UploadIO.new(File.open(photo), "image/jpeg", File.basename(photo))
      access_token = prepare_access_token
      request = Net::HTTP::Post::Multipart.new('/photo/upload.json', params)
      access_token.sign! request
      url = URI.parse @hostname
      response = Net::HTTP.start(url.host, url.port, :use_ssl => true) do |http|
        http.request request
      end
      response.extend Openphoto::Response
      response
    end
  end
end

(used in https://github.com/jo/trovebox-uploader)

One could also enhance the connect method.

photo / openphoto-ruby Goto Github PK

openphoto-ruby's People

Contributors

Stargazers

Watchers

openphoto-ruby's Issues

Method GET and params

Require either a dotfile or -c / --config file for secrets

Invalid JSON response when running example code

Use multipart post for upload

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent