phlak / config Goto Github PK

Can you add support for 8.3 and 8.4 is only a few months away so keep this in mind too.

Hello,
could you please upgrade symfony/yaml in your library?
from:
"symfony/yaml": "^3.0 || ^4.0 || ^5.0",
to:
"symfony/yaml": "^3.0 || ^4.0 || ^5.0 || ^6.0",
Because now it doesn't allow us to use latest symfony/yaml v6.0 and php 8.2
Thanks!

I'm using this in a couple of WordPress plugins. It would be nice if it not throw an Exception if the file syntax is invalid. Example:

$config = new Config\Config('/path/to/app/config.json');

If config.json has invalid syntax, it throws a nasty exception.

I'm not sure how I would address this, but maybe you could return an Exception() object if there is an error. I'm just brainstorming...

$config = new Config\Config('/path/to/app/my_config.json');

if( is_object( $config ) && get_class( $config ) == 'Exception' ) {
  // Let the user know
  echo $config->GetMessage();
} else {
  // Do magical things
}

Better maybe better?:

$config = new Config\Config('/path/to/app/my_config.json');

if( $result = $config->get_error() ) {
  // Show some sort of pretty panel/notice
  echo 'An error has occurred: ' . $result;
} else {
  // Do magical things
}

Thank you,
Daniel

Currently InvalidFileException does not contain a message when thrown. This could be improved by including the name of or path to the file which is invalid. See #2

For example:

Invalid file detected at $path

or

Unable to parse file at $path

I'm wondering if using the namespace Config could run into conflicts.

Perhaps Phlak\Config?

Hello!
Trying to use your lib, but faced a problem:

require 'vendor/autoload.php';

use PHLAK\Config\Config;

$array1 = [
	'assoc_key' => 'testvalue',
	'key' => [1,2,3,4],
];
$array2 = [
	'assoc_key' => 'override',
	'key' => ['somevalue'],
];

$config1 = new Config($array1);
$config2 = new Config($array2);
print_r($config1->merge($config2)->toArray());

It returns:

Array
(
    [assoc_key] => override
    [key] => Array
        (
            [0] => somevalue
            [1] => 2
            [2] => 3
            [3] => 4
        )

)

But should return:

Array
(
    [assoc_key] => override
    [key] => Array
        (
            [0] => somevalue
        )

)

Add a Config::unset() method.

Hey there,
isn't supposed that the set method update the config file ?
I'm using PHP configuration and nothing seems to happen when i use set except changing the value in memory only.

$config = new Config([
    'whitelist' => [
        'ips' => [
            '127.0.0.1',
            '192.168.0.1'
        ]
    ]
]);

$config->append('whitelist.ips', '10.10.0.1');

Should result in

[
    'whitelist' => [
        'ips' => [
            '127.0.0.1',
            '192.168.0.1',
            '10.10.0.1'
        ]
    ]
]

This should also be able to accept an array of values.