philsa / polymorphicstructs Goto Github PK

View Code? Open in Web Editor NEW

56.0 56.0 11.0 10.71 MB

License: The Unlicense

C# 100.00%

polymorphicstructs's People

Contributors

Stargazers

Watchers

Forkers

unitycoder xseagullx duanma laicasaane jjmac surprisingstudio

polymorphicstructs's Issues

Generic Fields Break Generated Naming Scheme

Problem:

PolymorphicStructs that are have generics used as a field, can't compile due to the name generated. Common use case will likely be BlobAssetReferences, but for sake of example, I quickly created a generic struct below. Breaks compilation.

Example

namespace Playground.ExamplePoly {
    [PolymorphicStruct]
    public interface IPoly {
        public void DoThing();
    }
}

namespace Playground.ExamplePoly {
    public partial struct PolyA : IPoly {
        public Example<int> Test;
        public void DoThing() {
        }
    }

    public struct Example<T> where T : unmanaged {
        public T Value;
    }
}

Current Result

public Example<int> Example<int>_0;

Different Namespaces are not Generated

Problem:

PolymorphicStructs that are created in a different namespace than the interface are not generated in their using statements of the generated struct file, breaking compilation.

Example

namespace Playground.ExamplePoly {
    [PolymorphicStruct]
    public interface IPoly {
        public void DoThing();
    }
}

namespace Playground.ExamplePoly.Test {
    public partial struct PolyC : IPoly {
        public void DoThing() { }
    }
}

Current Temporary Workaround

In another IPoly struct, add the using namespace of what ever namespace is nested. These are picked up by the source generator.

Nested Structs lose `partial` keyword

Problem:

PolymorphicStructs that are created in a nested structs, according to the IDE (Rider), don't have a partial sibling related to it.. This breaks compilation.

Example

namespace Playground.ExamplePoly {
    [PolymorphicStruct]
    public interface IPoly {
        public void DoThing();
    }
}

namespace Playground.ExamplePoly {
    public class NestedExample {
        public partial struct PolyB : IPoly {
            public void DoThing() { }
        }
    }
}

Potential Related Issues

Static or type definition using statements are lost on source generation. Examples below of what is written vs what is generated.

using static Playground.ExamplePoly.NestedExample.PolyB; //This example is not using both at the same time, but the result is the same.
using PolyB = Playground.ExamplePoly.NestedExample.PolyB;

Result:

using Playground.ExamplePoly.NestedExample.PolyB;

philsa / polymorphicstructs Goto Github PK

polymorphicstructs's People

Contributors

Stargazers

Watchers

Forkers

polymorphicstructs's Issues

Problem:

Example

Current Result

Problem:

Example

Current Temporary Workaround

Problem:

Example

Potential Related Issues

Recommend Projects

Recommend Topics

Recommend Org