philfung / add-to-homescreen Goto Github PK

Hi,

I think it's great what you do to notify with a PWA app message, thank you very much.

I have three problems:

1. On Windows 11 PC I cannot close the installation message in any browser, I can close the message in Chrome and Samsung browser on Android. (allowUserToCloseModal: true,)

On the other hand, the message on PC about widows 11 chrome shows that it cannot be installed, when it can be installed PWA

2. If I install the PWA application, the installation message still appears. Can you stop reporting the PWA installation message?

3. On Android when browsing, Edge shows the installation message with the up arrow, but the correct thing is that it will show the down arrow, in the direction of the edge setting button.

Best regards,

Eugenio

I'm using bootstrap as my CSS framework. That framework defines a css class called .modal. That causes the add-to-homescreen modal to be stretched out since it also uses the .modal classname. You probably want to have webpack (or something else) add a namespace/prefix to all of the classnames used, or have your css rules only apply within the top level div made by the library.

The file ios-add-to-home-screen-button.svg is a graphic that contains both the icon and the text "Add to homescreen". Therefore the text is not part of the localization. I think the the text should be removed from the svg and the icon should be used alone with a localized text.

Hi,

On both Chrome and Safari on a Mac, when I set showErrorMessageForUnsupportedBrowsers to false, the black background which would show up behind the modal window still appears. The modal and message itself isn't there, just a blank background. Is this a known issue?

In Chrome Browser instead of the text :
Please open this website on a mobile device.
Installing to your home screen is currently only supported on IOS and Android.

maybe show the user the steps to install PWA in Chrome ?

The webpage in chrome browsers offer to the users the option to install app in windows,
maybe place a modal with the steps to install the PWA in chrome browsers ?

It would be very helpful for analysis if installation or critical events are supported to be sent to GA.

Hi Partner
The Modal POPUP dont disappear on click outside in desktop PC browsers
allowUserToCloseModal: true,

Best Regards

in chrome iOS, after saved to home screen and then relaunching, The app does not launch as an app but instead launches again into chrome which triggers the your popup again.
The solution is to use the correct Meta tags and add a few lines in your manifest.json file
Here is the full explanation https://naildrivin5.com/blog/2023/08/24/braindump-of-pwa-on-ios.html

Please consider to add multi language support with language files, for the modal and modal texts.
Best Regards.

how to close guides？How to not display the guidance process for the second time？

addEventListener 'beforeinstallprompt'
deferredPrompt
Support in desktop chrome

Wouldn't it make sense to read the name and icon of the app from the manifest.json? It is json anyway and linked in the of the page.
I am using the script in a multi-site installation and it is invoked from inside a javascript file that is not site specific. So I don't have the information about the name in the first place. At first I thought about reading the application name and icon path from some data-attribute (in body or html tag). But the manifest has to be linked anyway for this to work and the name and icon could be used as the default.

Hi,
Works very well as intended
but I have noticed that your add-to-homescreen seems to be domain specific and not page specific
I set it to run only 2 times when user land on the page.
However, Once it has ran twice, your add-to-homescreen does not run again on another page i also need it to run on.
I want add-to-homescreen to be able to run two time on all pages I select it to run it on
Is there a way to achieve this.
Thanks